Skip to content

Add an example of scrolling in CDK Drag and Drop #31528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

cutiepoka
Copy link
Contributor

@cutiepoka cutiepoka commented Jul 11, 2025

This is to fix the issue that many people miss that you need an extra bit for scrolling to work with the CDK drag and drop.
#31519, #29161, and maybe this one #24553. There were a few others, but I cant find them now.

This adds documentation that shows you need to include the CdkScrollable otherwise scrolling wont work.

@cutiepoka cutiepoka requested a review from a team as a code owner July 11, 2025 21:44
@cutiepoka cutiepoka requested review from wagnermaciel and ok7sai and removed request for a team July 11, 2025 21:44
Copy link

google-cla bot commented Jul 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but the PR is missing a CLA and there are CI failures.

@cutiepoka cutiepoka force-pushed the drag-and-drop-scroll branch from 2b42f48 to 4ae187c Compare July 14, 2025 22:19
@cutiepoka
Copy link
Contributor Author

I think I fixed them. It should be good now.

@cutiepoka cutiepoka requested a review from crisbeto July 14, 2025 22:22
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jul 14, 2025
@mmalerba mmalerba added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Jul 15, 2025
@mmalerba mmalerba merged commit 5b5808d into angular:main Jul 15, 2025
22 of 23 checks passed
mmalerba pushed a commit that referenced this pull request Jul 15, 2025
…#31528)

* Add an example of scrolling in CDK Drag and Drop

* fixup! Add an example of scrolling in CDK Drag and Drop

(cherry picked from commit 5b5808d)
@cutiepoka
Copy link
Contributor Author

@mmalerba Did I mess something up?

image

I dont remember adding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants