Add an example of scrolling in CDK Drag and Drop #31528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cutiepoka
requested review from
wagnermaciel and
ok7sai
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
crisbeto
reviewed
Jul 13, 2025
cutiepoka
force-pushed
the
drag-and-drop-scroll
branch
from
2b42f48 to
4ae187c
Compare
|
I think I fixed them. It should be good now. |
mmalerba
approved these changes
Jul 14, 2025
mmalerba
added
action: merge
mmalerba
added
the
merge: fix commit message
|
@mmalerba Did I mess something up? 
I dont remember adding tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix the issue that many people miss that you need an extra bit for scrolling to work with the CDK drag and drop.
#31519, #29161, and maybe this one #24553. There were a few others, but I cant find them now.
This adds documentation that shows you need to include the
CdkScrollableotherwise scrolling wont work.