Skip to content

Commit 1d6eb1c

Browse files
authored
Merge pull request #209 from evanlok/fix-browser-compatibility
Remove ES6 code to fix old browser compatibility
2 parents bad9a73 + 6977fc1 commit 1d6eb1c

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

src/modules/adapter.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class Adapter {
3737
throw error;
3838
}
3939

40-
Object.assign(adapterOnScope, this.publicContext);
40+
angular.extend(adapterOnScope, this.publicContext);
4141
this.publicContext = adapterOnScope;
4242
}
4343

@@ -130,7 +130,7 @@ class Adapter {
130130
}
131131
// out-of-buffer case: deletion may affect Paddings
132132
else if(index >= this.buffer.getAbsMinIndex() && index <= this.buffer.getAbsMaxIndex()) {
133-
if(Array.isArray(newItems) && !newItems.length) {
133+
if(angular.isArray(newItems) && !newItems.length) {
134134
this.viewport.removeCacheItem(index, index === this.buffer.minIndex);
135135
if(index === this.buffer.getAbsMinIndex()) {
136136
this.buffer.incrementMinIndex();
@@ -143,7 +143,7 @@ class Adapter {
143143
}
144144

145145
applyUpdate(wrapper, newItems) {
146-
if (!Array.isArray(newItems)) {
146+
if (!angular.isArray(newItems)) {
147147
return;
148148
}
149149
let position = this.buffer.indexOf(wrapper);
@@ -200,4 +200,4 @@ class Adapter {
200200

201201
}
202202

203-
export default Adapter;
203+
export default Adapter;

src/modules/buffer.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export default function ScrollBuffer(elementRoutines, bufferSize, startIndex) {
22
const buffer = Object.create(Array.prototype);
33

4-
Object.assign(buffer, {
4+
angular.extend(buffer, {
55
size: bufferSize,
66

77
reset(startIndex) {
@@ -67,7 +67,7 @@ export default function ScrollBuffer(elementRoutines, bufferSize, startIndex) {
6767

6868
// removes elements from buffer
6969
remove(arg1, arg2) {
70-
if (Number.isInteger(arg1)) {
70+
if (angular.isNumber(arg1)) {
7171
// removes items from arg1 (including) through arg2 (excluding)
7272
for (let i = arg1; i < arg2; i++) {
7373
elementRoutines.removeElement(buffer[i]);
@@ -151,4 +151,4 @@ export default function ScrollBuffer(elementRoutines, bufferSize, startIndex) {
151151
buffer.reset(startIndex);
152152

153153
return buffer;
154-
}
154+
}

src/modules/jqLiteExtras.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export default class JQLiteExtras {
199199
var self;
200200
self = this;
201201
if (typeof value !== 'undefined') {
202-
if (Number.isInteger(value)) {
202+
if (angular.isNumber(value)) {
203203
value = value + 'px';
204204
}
205205
return css.call(self, 'height', value);

src/modules/viewport.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default function Viewport(elementRoutines, buffer, element, viewportContr
1717
return viewport.outerHeight() * padding; // some extra space to initiate preload
1818
}
1919

20-
Object.assign(viewport, {
20+
angular.extend(viewport, {
2121
getScope() {
2222
return scope;
2323
},

src/ui-scroll-grid.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ angular.module('ui.scroll.grid', [])
4444
// controller api methods
4545

4646
this.applyLayout = function(layout) {
47-
this.css = Object.assign({}, layout.css);
47+
this.css = angular.extend({}, layout.css);
4848
this.mapTo = layout.mapTo;
4949
applyCss(this.header, this.css);
5050
};
@@ -158,7 +158,7 @@ angular.module('ui.scroll.grid', [])
158158
let result = [];
159159
columns.forEach((column, index) => result.push({
160160
index: index,
161-
css: Object.assign({}, column.css),
161+
css: angular.extend({}, column.css),
162162
mapTo: column.mapTo
163163
}));
164164
return result;

src/ui-scroll.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,9 @@ angular.module('ui.scroll', [])
110110
function persistDatasourceIndex(datasource, propName) {
111111
let getter;
112112
// need to postpone min/maxIndexUser processing if the view is empty
113-
if(Number.isInteger(datasource[propName])) {
113+
if(angular.isNumber(datasource[propName])) {
114114
getter = datasource[propName];
115-
if(Number.isInteger(getter)) {
115+
if(angular.isNumber(getter)) {
116116
onRenderHandlers = onRenderHandlers.filter(handler => handler.id !== propName);
117117
onRenderHandlers.push({
118118
id: propName,
@@ -502,4 +502,4 @@ angular.module('ui.scroll', [])
502502
}
503503

504504
}
505-
]);
505+
]);

0 commit comments

Comments
 (0)