Skip to content

Commit 9fced64

Browse files
josephperrottthePunderWoman
authored andcommitted
ci: remove circleci as we no longer rely on it (angular#58615)
Remove CircleCI artifacts and configuration PR Close angular#58615
1 parent c421ffd commit 9fced64

22 files changed

+6
-312
lines changed

.bazelrc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,12 +78,6 @@ query --output=label_kind
7878
# By default, failing tests don't print any output, it goes to the log file
7979
test --test_output=errors
8080

81-
################################
82-
# Settings for CircleCI #
83-
################################
84-
85-
# Bazel flags for CircleCI are in /.circleci/bazel.linux.rc and /.circleci/bazel.windows.rc
86-
8781
##################################
8882
# Remote Build Execution support #
8983
# Turn on these settings with #

.circleci/README.md

Lines changed: 0 additions & 19 deletions
This file was deleted.

.circleci/bazel.common.rc

Lines changed: 0 additions & 16 deletions
This file was deleted.

.circleci/bazel.linux.rc

Lines changed: 0 additions & 23 deletions
This file was deleted.

.circleci/bazel.windows.rc

Lines changed: 0 additions & 17 deletions
This file was deleted.

.circleci/config.yml

Lines changed: 0 additions & 16 deletions
This file was deleted.

.circleci/env-helpers.inc.sh

Lines changed: 0 additions & 76 deletions
This file was deleted.

.circleci/env.linux.sh

Lines changed: 0 additions & 4 deletions
This file was deleted.

.circleci/env.sh

Lines changed: 0 additions & 88 deletions
This file was deleted.

.circleci/env.windows.sh

Lines changed: 0 additions & 13 deletions
This file was deleted.

.circleci/setup_cache.sh

Lines changed: 0 additions & 11 deletions
This file was deleted.

.devcontainer/recommended-Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# Image metadata and config.
22
# Ideally, the Node.js version should match what we use on CI.
3-
# See `executors > default-executor` in `.circleci/config.yml`.
43
FROM cimg/node:18.13.0@sha256:45d0ee279f522c4562a464df71108104cc9b2187205333ffd0707d4f05589731
54

65

@@ -12,7 +11,7 @@ LABEL name="Angular dev environment" \
1211
EXPOSE 4000 4200 4433 5000 8080 9876
1312

1413

15-
# Switch to `root` (CircleCI images use `circleci` as the user).
14+
# Switch to `root`.
1615
USER root
1716

1817

.gitignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66
*.log
77
/node_modules/
88

9-
# CircleCI temporary file for cache key computation.
10-
# See `save_month_to_file` in `.circleci/config.yml`.
11-
month.txt
12-
139
# Include when developing application packages.
1410
pubspec.lock
1511
.c9

.pullapprove.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,6 @@ groups:
634634
- >
635635
contains_any_globs(files.exclude('.pullapprove.yml'), [
636636
'{*,.*}',
637-
'.circleci/**/{*,.*}',
638637
'.devcontainer/**/{*,.*}',
639638
'.github/**/{*,.*}',
640639
'.husky/**/{*,.*}',

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ The `<type>` and `<summary>` fields are mandatory, the `(<scope>)` field is opti
260260
Must be one of the following:
261261
262262
* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
263-
* **ci**: Changes to our CI configuration files and scripts (examples: CircleCi, SauceLabs)
263+
* **ci**: Changes to our CI configuration files and scripts (examples: Github Actions, SauceLabs)
264264
* **docs**: Documentation only changes
265265
* **feat**: A new feature
266266
* **fix**: A bug fix

README.md

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@
2424
</p>
2525

2626
<p align="center">
27-
<a href="https://circleci.com/gh/angular/workflows/angular/tree/main">
28-
<img src="https://img.shields.io/circleci/build/github/angular/angular/main.svg?logo=circleci&logoColor=fff&label=CircleCI" alt="CI status" />
29-
</a>&nbsp;
3027
<a href="https://www.npmjs.com/@angular/core">
3128
<img src="https://img.shields.io/npm/v/@angular/core.svg?logo=npm&logoColor=fff&label=NPM+package&color=limegreen" alt="Angular on npm" />
3229
</a>&nbsp;
@@ -35,12 +32,6 @@
3532
</a>
3633
</p>
3734

38-
<p align="center">
39-
<a href="https://app.circleci.com/insights/github/angular/angular/workflows/default_workflow?branch=main">
40-
<img src="https://dl.circleci.com/insights-snapshot/gh/angular/angular/main/default_workflow/badge.svg" alt="InsightsSnapshot" />
41-
</a>
42-
</p>
43-
4435
<hr>
4536

4637
## Documentation

integration/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ And from the flags that the Karma `ChromeHeadless` browser passes to Chrome: htt
156156

157157
The `--disable-dev-shm-usage` flag disables the usage of `/dev/shm` because it causes Chrome to crash on some environments.
158158

159-
On CircleCI, the puppeteer provisioned Chrome crashes with `CI we get Root cause: org.openqa.selenium.WebDriverException: unknown error: DevToolsActivePort file doesn't exist which resolves` without this flag.
159+
On CI, the puppeteer provisioned Chrome crashes with `CI we get Root cause: org.openqa.selenium.WebDriverException: unknown error: DevToolsActivePort file doesn't exist which resolves` without this flag.
160160

161161
See: https://github.com/puppeteer/puppeteer/blob/v1.0.0/docs/troubleshooting.md#tips
162162
See: https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t

integration/run_tests.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
set -u -e -o pipefail
44

5-
# see https://circleci.com/docs/2.0/env-vars/#circleci-built-in-environment-variables
65
CI=${CI:-false}
76

87
cd "$(dirname "$0")"

karma-js.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ module.exports = function (config) {
130130
// the tunnel. We do this because devices are sometimes not able to properly resolve
131131
// `localhost` or `127.0.0.1` through the SauceLabs tunnel. Using a domain that does not
132132
// resolve to anything on SauceLabs VMs ensures that such requests are always resolved through
133-
// the tunnel, and resolve to the actual tunnel host machine (commonly the CircleCI VMs).
133+
// the tunnel, and resolve to the actual tunnel host machine (commonly the GHA VMs).
134134
// More context can be found in: https://github.com/angular/angular/pull/35171.
135135
if (process.env.SAUCE_LOCALHOST_ALIAS_DOMAIN) {
136136
conf.hostname = process.env.SAUCE_LOCALHOST_ALIAS_DOMAIN;

0 commit comments

Comments
 (0)