refactor(core): remove compileComponents invocations (angular#61032)

JeanMeche · alxhub · commit 3eeea56ba025 · 2025-05-09T10:27:14.000-07:00
Those weren't necessary. PR Close angular#61032
diff --git a/adev/shared-docs/components/navigation-list/navigation-list.component.spec.ts b/adev/shared-docs/components/navigation-list/navigation-list.component.spec.ts
@@ -43,7 +43,7 @@ describe('NavigationList', () => {
         {provide: NavigationState, useClass: FakeNavigationListState},
         provideZonelessChangeDetection(),
       ],
-    }).compileComponents();
+    });
     fixture = TestBed.createComponent(NavigationList);
     fixture.componentRef.setInput('navigationItems', []);
 
diff --git a/adev/shared-docs/components/table-of-contents/table-of-contents.component.spec.ts b/adev/shared-docs/components/table-of-contents/table-of-contents.component.spec.ts
@@ -49,7 +49,7 @@ describe('TableOfContents', () => {
           useValue: fakeWindow,
         },
       ],
-    }).compileComponents();
+    });
 
     const tableOfContentsLoaderSpy = TestBed.inject(TableOfContentsLoader);
     spyOn(tableOfContentsLoaderSpy, 'buildTableOfContent').and.returnValue();
diff --git a/adev/shared-docs/components/viewers/docs-viewer/docs-viewer.component.spec.ts b/adev/shared-docs/components/viewers/docs-viewer/docs-viewer.component.spec.ts
@@ -86,7 +86,7 @@ describe('DocViewer', () => {
         {provide: EXAMPLE_VIEWER_CONTENT_LOADER, useValue: exampleContentSpy},
         {provide: NavigationState, useValue: navigationStateSpy},
       ],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(DocViewer);
     fixture.detectChanges();
diff --git a/adev/shared-docs/components/viewers/example-viewer/example-viewer.component.spec.ts b/adev/shared-docs/components/viewers/example-viewer/example-viewer.component.spec.ts
@@ -40,7 +40,7 @@ describe('ExampleViewer', () => {
         {provide: EXAMPLE_VIEWER_CONTENT_LOADER, useValue: exampleContentSpy},
         {provide: ActivatedRoute, useValue: {snapshot: {fragment: 'fragment'}}},
       ],
-    }).compileComponents();
+    });
     fixture = TestBed.createComponent(ExampleViewer);
     component = fixture.componentInstance;
     componentRef = fixture.componentRef;
diff --git a/adev/src/app/core/layout/navigation/navigation.component.spec.ts b/adev/src/app/core/layout/navigation/navigation.component.spec.ts
@@ -49,7 +49,7 @@ describe('Navigation', () => {
           useValue: fakeSearch,
         },
       ],
-    }).compileComponents();
+    });
 
     TestBed.overrideProvider(ThemeManager, {useValue: fakeThemeManager});
     TestBed.overrideProvider(VersionManager, {useValue: fakeVersionManager});
diff --git a/adev/src/app/core/layout/progress-bar/progress-bar.component.spec.ts b/adev/src/app/core/layout/progress-bar/progress-bar.component.spec.ts
@@ -18,7 +18,7 @@ describe('ProgressBarComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [ProgressBarComponent, RouterTestingModule],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(ProgressBarComponent);
     component = fixture.componentInstance;
diff --git a/adev/src/app/editor/code-editor/code-editor.component.spec.ts b/adev/src/app/editor/code-editor/code-editor.component.spec.ts
@@ -80,7 +80,7 @@ describe('CodeEditor', () => {
           },
         },
       ],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(CodeEditor);
     loader = TestbedHarnessEnvironment.loader(fixture);
diff --git a/adev/src/app/editor/preview/preview.component.spec.ts b/adev/src/app/editor/preview/preview.component.spec.ts
@@ -43,7 +43,7 @@ describe('Preview', () => {
           useValue: fakeNodeRuntimeState,
         },
       ],
-    }).compileComponents();
+    });
 
     const fixture = TestBed.createComponent(Preview);
 
diff --git a/adev/src/app/editor/terminal/terminal.component.spec.ts b/adev/src/app/editor/terminal/terminal.component.spec.ts
@@ -36,7 +36,7 @@ describe('Terminal', () => {
           useValue: fakeWindow,
         },
       ],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(Terminal);
     component = fixture.componentInstance;
diff --git a/adev/src/app/features/home/animation/animation.spec.ts b/adev/src/app/features/home/animation/animation.spec.ts
@@ -83,7 +83,7 @@ describe('Animation', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [AnimationHost],
-    }).compileComponents();
+    });
 
     fixture = TestBed.createComponent(AnimationHost);
     component = fixture.componentInstance;
diff --git a/adev/src/app/features/home/home.component.spec.ts b/adev/src/app/features/home/home.component.spec.ts
@@ -26,7 +26,7 @@
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [Home],
-    }).compileComponents();
+    });
 
     TestBed.overrideProvider(HomeAnimation, {useValue: fakeHomeAnimation});
 
diff --git a/adev/src/app/features/tutorial/tutorial.component.spec.ts b/adev/src/app/features/tutorial/tutorial.component.spec.ts
@@ -111,7 +111,7 @@ describe('Tutorial', () => {
       },
     });
 
-    await TestBed.compileComponents();
+    await TestBed;
 
     fixture = TestBed.createComponent(Tutorial);
     component = fixture.componentInstance;
diff --git a/adev/src/content/examples/angular-compiler-options/src/app/app.component.spec.ts b/adev/src/content/examples/angular-compiler-options/src/app/app.component.spec.ts
@@ -5,7 +5,7 @@ describe('AppComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       declarations: [AppComponent],
-    }).compileComponents();
+    });
   });
 
   it('should create the app', () => {
diff --git a/adev/src/content/examples/forms-overview/src/app/app.component.spec.ts b/adev/src/content/examples/forms-overview/src/app/app.component.spec.ts
@@ -8,7 +8,7 @@ describe('AppComponent', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       declarations: [AppComponent],
-    }).compileComponents();
+    });
   }));
 
   it('should create the app', waitForAsync(() => {
diff --git a/adev/src/content/examples/forms-overview/src/app/reactive/favorite-color/favorite-color.component.spec.ts b/adev/src/content/examples/forms-overview/src/app/reactive/favorite-color/favorite-color.component.spec.ts
@@ -10,7 +10,7 @@ describe('Favorite Color Component', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       declarations: [FavoriteColorReactiveComponent],
-    }).compileComponents();
+    });
   }));
 
   beforeEach(() => {
diff --git a/adev/src/content/examples/forms-overview/src/app/template/favorite-color/favorite-color.component.spec.ts b/adev/src/content/examples/forms-overview/src/app/template/favorite-color/favorite-color.component.spec.ts
@@ -10,7 +10,7 @@ describe('FavoriteColorComponent', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       declarations: [FavoriteColorTemplateComponent],
-    }).compileComponents();
+    });
   }));
 
   beforeEach(() => {
diff --git a/adev/src/content/examples/schematics-for-libraries/projects/my-lib/src/lib/my-lib.component.spec.ts b/adev/src/content/examples/schematics-for-libraries/projects/my-lib/src/lib/my-lib.component.spec.ts
@@ -7,7 +7,7 @@ describe('MyLibComponent', () => {
   let fixture: ComponentFixture<MyLibComponent>;
 
   beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({declarations: [MyLibComponent]}).compileComponents();
+    TestBed.configureTestingModule({declarations: [MyLibComponent]});
   }));
 
   beforeEach(() => {
diff --git a/adev/src/content/examples/setup/src/app/app.component.spec.ts b/adev/src/content/examples/setup/src/app/app.component.spec.ts
@@ -10,7 +10,7 @@ describe('AppComponent', () => {
   let fixture: ComponentFixture<AppComponent>;
 
   beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({declarations: [AppComponent]}).compileComponents();
+    TestBed.configureTestingModule({declarations: [AppComponent]});
   }));
 
   beforeEach(() => {
diff --git a/adev/src/content/examples/testing/src/app/app-initial.component.spec.ts b/adev/src/content/examples/testing/src/app/app-initial.component.spec.ts
@@ -15,7 +15,7 @@ describe('AppComponent (initial CLI version)', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       imports: [AppComponent],
-    }).compileComponents();
+    });
   }));
   it('should create the app', waitForAsync(() => {
     const fixture = TestBed.createComponent(AppComponent);
diff --git a/adev/src/content/examples/testing/src/app/app.component.router.spec.ts b/adev/src/content/examples/testing/src/app/app.component.router.spec.ts
@@ -39,7 +39,7 @@ describe('AppComponent & router testing', () => {
           ]),
         ],
       }),
-    ).compileComponents();
+    );
   }));
 
   it('should navigate to "Dashboard" immediately', fakeAsync(() => {
@@ -87,7 +87,7 @@ import {provideHttpClient} from '@angular/common/http';
 ///////// Can't get lazy loaded Heroes to work yet
 xdescribe('AppComponent & Lazy Loading (not working yet)', () => {
   beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule(appConfig).compileComponents();
+    TestBed.configureTestingModule(appConfig);
   }));
 
   beforeEach(fakeAsync(() => {
diff --git a/adev/src/content/examples/testing/src/app/app.component.spec.ts b/adev/src/content/examples/testing/src/app/app.component.spec.ts
@@ -38,7 +38,7 @@ describe('AppComponent & TestModule', () => {
       }),
     )
       // #enddocregion testbed-stubs
-      .compileComponents()
+
       .then(() => {
         fixture = TestBed.createComponent(AppComponent);
         comp = fixture.componentInstance;
@@ -65,7 +65,7 @@ describe('AppComponent & NO_ERRORS_SCHEMA', () => {
       }),
     )
       // #enddocregion no-errors-schema, mixed-setup
-      .compileComponents()
+
       .then(() => {
         fixture = TestBed.createComponent(AppComponent);
         comp = fixture.componentInstance;
diff --git a/adev/src/content/examples/testing/src/app/banner/banner-external.component.spec.ts b/adev/src/content/examples/testing/src/app/banner/banner-external.component.spec.ts
@@ -28,7 +28,7 @@ describe('BannerComponent (external files)', () => {
     beforeEach(async () => {
       await TestBed.configureTestingModule({
         imports: [BannerComponent],
-      }).compileComponents(); // compile template and css
+      }); // compile template and css
     });
     // #enddocregion async-before-each
 
@@ -49,7 +49,7 @@ describe('BannerComponent (external files)', () => {
     beforeEach(async () => {
       await TestBed.configureTestingModule({
         imports: [BannerComponent],
-      }).compileComponents();
+      });
       fixture = TestBed.createComponent(BannerComponent);
       component = fixture.componentInstance;
       h1 = fixture.nativeElement.querySelector('h1');
diff --git a/adev/src/content/examples/testing/src/app/banner/banner-initial.component.spec.ts b/adev/src/content/examples/testing/src/app/banner/banner-initial.component.spec.ts
@@ -24,7 +24,7 @@ describe('BannerComponent (initial CLI generated)', () => {
   let fixture: ComponentFixture<BannerComponent>;
 
   beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({imports: [BannerComponent]}).compileComponents();
+    TestBed.configureTestingModule({imports: [BannerComponent]});
   }));
 
   beforeEach(() => {
diff --git a/adev/src/content/examples/testing/src/app/dashboard/dashboard-hero.component.spec.ts b/adev/src/content/examples/testing/src/app/dashboard/dashboard-hero.component.spec.ts
@@ -110,9 +110,8 @@ describe('DashboardHeroComponent when inside a test host', () => {
     TestBed.configureTestingModule({
       providers: appProviders,
       imports: [DashboardHeroComponent, TestHostComponent],
-    })
-      // #enddocregion test-host-setup
-      .compileComponents();
+    });
+    // #enddocregion test-host-setup
   }));
 
   beforeEach(() => {
diff --git a/adev/src/content/examples/testing/src/app/demo/demo.testbed.spec.ts b/adev/src/content/examples/testing/src/app/demo/demo.testbed.spec.ts
@@ -162,7 +162,7 @@ describe('demo (with TestBed):', () => {
     // beforeEach(waitForAsync(() => {
     //   TestBed.configureTestingModule()
     //     // Compile everything in DemoModule
-    //     .compileComponents();
+    //     ;
     // }));
 
     it('should create a component with inline template', () => {
diff --git a/adev/src/content/examples/testing/src/app/hero/hero-detail.component.spec.ts b/adev/src/content/examples/testing/src/app/hero/hero-detail.component.spec.ts
@@ -67,9 +67,8 @@ function overrideSetup() {
       // #docregion override-component-method
       .overrideComponent(HeroDetailComponent, {
         set: {providers: [{provide: HeroDetailService, useClass: HeroDetailServiceSpy}]},
-      })
-      // #enddocregion override-component-method
-      .compileComponents();
+      });
+    // #enddocregion override-component-method
   });
   // #enddocregion setup-override
 
@@ -137,7 +136,7 @@ function heroModuleSetup() {
           provideHttpClientTesting(),
         ],
       }),
-    ).compileComponents();
+    );
   });
   // #enddocregion setup-hero-module
 
@@ -226,7 +225,7 @@ function formsModuleSetup() {
           provideRouter([{path: 'heroes/:id', component: HeroDetailComponent}]),
         ],
       }),
-    ).compileComponents();
+    );
   });
   // #enddocregion setup-forms-module
 
@@ -252,7 +251,7 @@ function sharedModuleSetup() {
           provideHttpClientTesting(),
         ],
       }),
-    ).compileComponents();
+    );
   });
   // #enddocregion setup-shared-module
 
diff --git a/adev/src/content/examples/testing/src/app/hero/hero-list.component.spec.ts b/adev/src/content/examples/testing/src/app/hero/hero-list.component.spec.ts
@@ -34,7 +34,7 @@ describe('HeroListComponent', () => {
         ],
       }),
     )
-      .compileComponents()
+
       .then(createComponent);
   }));
 
diff --git a/adev/src/content/examples/testing/src/app/shared/canvas.component.spec.ts b/adev/src/content/examples/testing/src/app/shared/canvas.component.spec.ts
@@ -20,7 +20,7 @@ describe('CanvasComponent', () => {
   beforeEach(async () => {
     await TestBed.configureTestingModule({
       imports: [CanvasComponent],
-    }).compileComponents();
+    });
   });
 
   it('should be able to generate blob data from canvas', fakeAsync(() => {
diff --git a/integration/platform-server-hydration/src/app/app.component.spec.ts b/integration/platform-server-hydration/src/app/app.component.spec.ts
@@ -2,10 +2,10 @@ import {TestBed} from '@angular/core/testing';
 import {AppComponent} from './app.component';
 
 describe('AppComponent', () => {
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
+  beforeEach(() => {
+    TestBed.configureTestingModule({
       imports: [AppComponent],
-    }).compileComponents();
+    });
   });
 
   it('should create the app', () => {
diff --git a/integration/trusted-types/src/app/app.component.spec.ts b/integration/trusted-types/src/app/app.component.spec.ts
@@ -3,11 +3,11 @@ import {RouterModule} from '@angular/router';
 import {AppComponent} from './app.component';
 
 describe('AppComponent', () => {
-  beforeEach(async () => {
-    await TestBed.configureTestingModule({
+  beforeEach(() => {
+    TestBed.configureTestingModule({
       imports: [RouterModule.forRoot([])],
       declarations: [AppComponent],
-    }).compileComponents();
+    });
   });
 
   it('should create the app', () => {
diff --git a/packages/core/test/acceptance/signal_debug_spec.ts b/packages/core/test/acceptance/signal_debug_spec.ts
@@ -94,7 +94,7 @@ describe('getSignalGraph', () => {
         );
       }
     }
-    TestBed.configureTestingModule({imports: [WithEffect]}).compileComponents();
+    TestBed.configureTestingModule({imports: [WithEffect]});
     const fixture = TestBed.createComponent(WithEffect);
 
     tick();
@@ -131,7 +131,7 @@ describe('getSignalGraph', () => {
         debugName: 'computedSignal',
       });
     }
-    TestBed.configureTestingModule({imports: [WithComputed]}).compileComponents();
+    TestBed.configureTestingModule({imports: [WithComputed]});
     const fixture = TestBed.createComponent(WithComputed);
 
     tick();
@@ -192,7 +192,7 @@ describe('getSignalGraph', () => {
         debugName: 'computedSignal',
       });
     }
-    TestBed.configureTestingModule({imports: [WithUnusedReactiveNodes]}).compileComponents();
+    TestBed.configureTestingModule({imports: [WithUnusedReactiveNodes]});
     const fixture = TestBed.createComponent(WithUnusedReactiveNodes);
 
     tick();
@@ -212,7 +212,7 @@ describe('getSignalGraph', () => {
       primitiveSignal = signal(123, {debugName: 'primitiveSignal'});
       primitiveSignalEffect = effect(() => {}, {debugName: 'primitiveSignalEffect'});
     }
-    TestBed.configureTestingModule({imports: [WithNoEffectSignalDependencies]}).compileComponents();
+    TestBed.configureTestingModule({imports: [WithNoEffectSignalDependencies]});
     const fixture = TestBed.createComponent(WithNoEffectSignalDependencies);
 
     tick();
@@ -229,7 +229,7 @@ describe('getSignalGraph', () => {
   it('should return the signal graph for a component with no signal dependencies in the template or component effects', fakeAsync(() => {
     @Component({selector: 'component-with-no-effect-dependencies', template: ``})
     class WithNoEffectDependencies {}
-    TestBed.configureTestingModule({imports: [WithNoEffectDependencies]}).compileComponents();
+    TestBed.configureTestingModule({imports: [WithNoEffectDependencies]});
     const fixture = TestBed.createComponent(WithNoEffectDependencies);
 
     tick();
@@ -267,7 +267,7 @@ describe('getSignalGraph', () => {
         );
       }
     }
-    TestBed.configureTestingModule({imports: [WithExternalService]}).compileComponents();
+    TestBed.configureTestingModule({imports: [WithExternalService]});
     const fixture = TestBed.createComponent(WithExternalService);
 
     tick();
diff --git a/packages/core/test/test_bed_spec.ts b/packages/core/test/test_bed_spec.ts
