- Improve scoping.

- Refactor.
- Get rid of dead code.

Author: android10

app/src/main/java/com/fernandocejas/android10/sample/app/core/di/components/ActivityComponent.java

@@ -29,7 +29,7 @@
  */
 @PerActivity
 @Component(dependencies = ApplicationComponent.class, modules = ActivityModule.class)
-public interface ActivityComponent {
+interface ActivityComponent {
   //Exposed to sub-graphs.
   Activity activity();
 }

app/src/main/java/com/fernandocejas/android10/sample/app/core/executor/JobExecutor.java

@@ -15,7 +15,7 @@
  */
 package com.fernandocejas.android10.sample.app.core.executor;
 
-import java.util.concurrent.BlockingQueue;
+import android.support.annotation.NonNull;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.ThreadPoolExecutor;
@@ -28,43 +28,23 @@
  */
 @Singleton
 public class JobExecutor implements ThreadExecutor {
-
-  private static final int INITIAL_POOL_SIZE = 3;
-  private static final int MAX_POOL_SIZE = 5;
-
-  // Sets the amount of time an idle thread waits before terminating
-  private static final int KEEP_ALIVE_TIME = 10;
-
-  // Sets the Time Unit to seconds
-  private static final TimeUnit KEEP_ALIVE_TIME_UNIT = TimeUnit.SECONDS;
-
-  private final BlockingQueue<Runnable> workQueue;
-
   private final ThreadPoolExecutor threadPoolExecutor;
 
-  private final ThreadFactory threadFactory;
-
   @Inject
-  public JobExecutor() {
-    this.workQueue = new LinkedBlockingQueue<>();
-    this.threadFactory = new JobThreadFactory();
-    this.threadPoolExecutor = new ThreadPoolExecutor(INITIAL_POOL_SIZE, MAX_POOL_SIZE,
-        KEEP_ALIVE_TIME, KEEP_ALIVE_TIME_UNIT, this.workQueue, this.threadFactory);
+  JobExecutor() {
+    this.threadPoolExecutor = new ThreadPoolExecutor(3, 5, 10, TimeUnit.SECONDS,
+        new LinkedBlockingQueue<>(), new JobThreadFactory());
   }
 
-  @Override public void execute(Runnable runnable) {
-    if (runnable == null) {
-      throw new IllegalArgumentException("Runnable to execute cannot be null");
-    }
+  @Override public void execute(@NonNull Runnable runnable) {
     this.threadPoolExecutor.execute(runnable);
   }
 
   private static class JobThreadFactory implements ThreadFactory {
-    private static final String THREAD_NAME = "android_";
     private int counter = 0;
 
-    @Override public Thread newThread(Runnable runnable) {
-      return new Thread(runnable, THREAD_NAME + counter++);
+    @Override public Thread newThread(@NonNull Runnable runnable) {
+      return new Thread(runnable, "android_" + counter++);
     }
   }
 }

app/src/main/java/com/fernandocejas/android10/sample/app/core/executor/UIThread.java

@@ -15,7 +15,6 @@
  */
 package com.fernandocejas.android10.sample.app.core.executor;
 
-import com.fernandocejas.android10.sample.app.core.executor.PostExecutionThread;
 import javax.inject.Inject;
 import javax.inject.Singleton;
 import rx.Scheduler;
@@ -29,7 +28,7 @@
 public class UIThread implements PostExecutionThread {
 
   @Inject
-  public UIThread() {}
+  UIThread() {}
 
   @Override public Scheduler getScheduler() {
     return AndroidSchedulers.mainThread();

app/src/main/java/com/fernandocejas/android10/sample/app/data/ApiConnection.java

@@ -29,7 +29,7 @@
  * Implements {@link java.util.concurrent.Callable} so when executed asynchronously can
  * return a value.
  */
-public class ApiConnection implements Callable<String> {
+class ApiConnection implements Callable<String> {
 
   private static final String CONTENT_TYPE_LABEL = "Content-Type";
   private static final String CONTENT_TYPE_VALUE_JSON = "application/json; charset=utf-8";
@@ -41,7 +41,7 @@ private ApiConnection(String url) throws MalformedURLException {
     this.url = new URL(url);
   }
 
-  public static ApiConnection createGET(String url) throws MalformedURLException {
+  static ApiConnection createGET(String url) throws MalformedURLException {
     return new ApiConnection(url);
   }
 
@@ -52,7 +52,7 @@ public static ApiConnection createGET(String url) throws MalformedURLException {
    * @return A string response
    */
   @Nullable
-  public String requestSyncCall() {
+  String requestSyncCall() {
     connectToApi();
     return response;
   }

app/src/main/java/com/fernandocejas/android10/sample/app/data/FileManager.java

@@ -69,7 +69,7 @@ public String readFileContent(File file) {
         FileReader fileReader = new FileReader(file);
         BufferedReader bufferedReader = new BufferedReader(fileReader);
         while ((stringLine = bufferedReader.readLine()) != null) {
-          fileContentBuilder.append(stringLine + "\n");
+          fileContentBuilder.append(stringLine).append("\n");
         }
         bufferedReader.close();
         fileReader.close();

app/src/main/java/com/fernandocejas/android10/sample/app/exception/NetworkConnectionException.java

@@ -24,14 +24,6 @@ public NetworkConnectionException() {
     super();
   }
 
-  public NetworkConnectionException(final String message) {
-    super(message);
-  }
-
-  public NetworkConnectionException(final String message, final Throwable cause) {
-    super(message, cause);
-  }
-
   public NetworkConnectionException(final Throwable cause) {
     super(cause);
   }

app/src/main/java/com/fernandocejas/android10/sample/app/exception/RepositoryErrorBundle.java

@@ -15,14 +15,16 @@
  */
 package com.fernandocejas.android10.sample.app.exception;
 
+import com.fernandocejas.frodo.core.strings.Strings;
+
 /**
  * Wrapper around Exceptions used to manage errors in the repository.
  */
-public class RepositoryErrorBundle implements ErrorBundle {
+class RepositoryErrorBundle implements ErrorBundle {
 
   private final Exception exception;
 
-  public RepositoryErrorBundle(Exception exception) {
+  RepositoryErrorBundle(Exception exception) {
     this.exception = exception;
   }
 
@@ -33,7 +35,7 @@ public Exception getException() {
 
   @Override
   public String getErrorMessage() {
-    String message = "";
+    String message = Strings.EMPTY;
     if (this.exception != null) {
       message = this.exception.getMessage();
     }

app/src/main/java/com/fernandocejas/android10/sample/app/users/GetUserList.java

@@ -30,7 +30,7 @@ public class GetUserList extends UseCase {
   private final UserRepository userRepository;
 
   @Inject
-  public GetUserList(UserRepository userRepository, ThreadExecutor threadExecutor,
+  GetUserList(UserRepository userRepository, ThreadExecutor threadExecutor,
       PostExecutionThread postExecutionThread) {
     super(threadExecutor, postExecutionThread);
     this.userRepository = userRepository;

app/src/main/java/com/fernandocejas/android10/sample/app/users/User.java

@@ -77,7 +77,7 @@ void setFollowers(int followers) {
   }
 
   @Override public String toString() {
-    StringBuilder stringBuilder = new StringBuilder();
+    final StringBuilder stringBuilder = new StringBuilder();
 
     stringBuilder.append("***** User Details *****\n");
     stringBuilder.append("id=" + this.getUserId() + "\n");

app/src/main/java/com/fernandocejas/android10/sample/app/users/UserDataRepository.java

@@ -36,7 +36,7 @@ public class UserDataRepository implements UserRepository {
    * @param userEntityDataMapper {@link UserEntityDataMapper}.
    */
   @Inject
-  public UserDataRepository(UserDataStoreFactory dataStoreFactory,
+  UserDataRepository(UserDataStoreFactory dataStoreFactory,
       UserEntityDataMapper userEntityDataMapper) {
     this.userDataStoreFactory = dataStoreFactory;
     this.userEntityDataMapper = userEntityDataMapper;