added missing return, accepted test baselines

vladima · vladima · commit 92dddd099af2 · 2015-02-24T17:08:55.000-08:00
diff --git a/src/services/formatting/smartIndenter.ts b/src/services/formatting/smartIndenter.ts
@@ -153,7 +153,7 @@ module ts.formatting {
             // previous token is comma that separates items in list - find the previous item and try to derive indentation from it
             var commaItemInfo = findListItemInfo(commaToken);
             if (commaItemInfo && commaItemInfo.listItemIndex > 0) {
-                deriveActualIndentationFromList(commaItemInfo.list.getChildren(), commaItemInfo.listItemIndex - 1, sourceFile, options);
+                return deriveActualIndentationFromList(commaItemInfo.list.getChildren(), commaItemInfo.listItemIndex - 1, sourceFile, options);
             }
             else {
                 // handle broken code gracefully
diff --git a/tests/baselines/reference/APISample_compile.js b/tests/baselines/reference/APISample_compile.js
@@ -869,6 +869,7 @@ declare module "typescript" {
         getConstantValue(node: EnumMember | PropertyAccessExpression | ElementAccessExpression): number;
         isValidPropertyAccess(node: PropertyAccessExpression | QualifiedName, propertyName: string): boolean;
         getAliasedSymbol(symbol: Symbol): Symbol;
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
     }
     interface SymbolDisplayBuilder {
         buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;
diff --git a/tests/baselines/reference/APISample_compile.types b/tests/baselines/reference/APISample_compile.types
@@ -2718,6 +2718,12 @@ declare module "typescript" {
 >getAliasedSymbol : (symbol: Symbol) => Symbol
 >symbol : Symbol
 >Symbol : Symbol
+>Symbol : Symbol
+
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
+>getExportsOfExternalModule : (node: ImportDeclaration) => Symbol[]
+>node : ImportDeclaration
+>ImportDeclaration : ImportDeclaration
 >Symbol : Symbol
     }
     interface SymbolDisplayBuilder {
diff --git a/tests/baselines/reference/APISample_linter.js b/tests/baselines/reference/APISample_linter.js
@@ -900,6 +900,7 @@ declare module "typescript" {
         getConstantValue(node: EnumMember | PropertyAccessExpression | ElementAccessExpression): number;
         isValidPropertyAccess(node: PropertyAccessExpression | QualifiedName, propertyName: string): boolean;
         getAliasedSymbol(symbol: Symbol): Symbol;
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
     }
     interface SymbolDisplayBuilder {
         buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;
diff --git a/tests/baselines/reference/APISample_linter.types b/tests/baselines/reference/APISample_linter.types
@@ -2864,6 +2864,12 @@ declare module "typescript" {
 >getAliasedSymbol : (symbol: Symbol) => Symbol
 >symbol : Symbol
 >Symbol : Symbol
+>Symbol : Symbol
+
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
+>getExportsOfExternalModule : (node: ImportDeclaration) => Symbol[]
+>node : ImportDeclaration
+>ImportDeclaration : ImportDeclaration
 >Symbol : Symbol
     }
     interface SymbolDisplayBuilder {
diff --git a/tests/baselines/reference/APISample_transform.js b/tests/baselines/reference/APISample_transform.js
@@ -901,6 +901,7 @@ declare module "typescript" {
         getConstantValue(node: EnumMember | PropertyAccessExpression | ElementAccessExpression): number;
         isValidPropertyAccess(node: PropertyAccessExpression | QualifiedName, propertyName: string): boolean;
         getAliasedSymbol(symbol: Symbol): Symbol;
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
     }
     interface SymbolDisplayBuilder {
         buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;
diff --git a/tests/baselines/reference/APISample_transform.types b/tests/baselines/reference/APISample_transform.types
@@ -2814,6 +2814,12 @@ declare module "typescript" {
 >getAliasedSymbol : (symbol: Symbol) => Symbol
 >symbol : Symbol
 >Symbol : Symbol
+>Symbol : Symbol
+
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
+>getExportsOfExternalModule : (node: ImportDeclaration) => Symbol[]
+>node : ImportDeclaration
+>ImportDeclaration : ImportDeclaration
 >Symbol : Symbol
     }
     interface SymbolDisplayBuilder {
diff --git a/tests/baselines/reference/APISample_watcher.js b/tests/baselines/reference/APISample_watcher.js
@@ -938,6 +938,7 @@ declare module "typescript" {
         getConstantValue(node: EnumMember | PropertyAccessExpression | ElementAccessExpression): number;
         isValidPropertyAccess(node: PropertyAccessExpression | QualifiedName, propertyName: string): boolean;
         getAliasedSymbol(symbol: Symbol): Symbol;
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
     }
     interface SymbolDisplayBuilder {
         buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;
diff --git a/tests/baselines/reference/APISample_watcher.types b/tests/baselines/reference/APISample_watcher.types
@@ -2987,6 +2987,12 @@ declare module "typescript" {
 >getAliasedSymbol : (symbol: Symbol) => Symbol
 >symbol : Symbol
 >Symbol : Symbol
+>Symbol : Symbol
+
+        getExportsOfExternalModule(node: ImportDeclaration): Symbol[];
+>getExportsOfExternalModule : (node: ImportDeclaration) => Symbol[]
+>node : ImportDeclaration
+>ImportDeclaration : ImportDeclaration
 >Symbol : Symbol
     }
     interface SymbolDisplayBuilder {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ module ts.formatting {`
`153`	`153`	`// previous token is comma that separates items in list - find the previous item and try to derive indentation from it`
`154`	`154`	`var commaItemInfo = findListItemInfo(commaToken);`
`155`	`155`	`if (commaItemInfo && commaItemInfo.listItemIndex > 0) {`
`156`		`- deriveActualIndentationFromList(commaItemInfo.list.getChildren(), commaItemInfo.listItemIndex - 1, sourceFile, options);`
	`156`	`+ return deriveActualIndentationFromList(commaItemInfo.list.getChildren(), commaItemInfo.listItemIndex - 1, sourceFile, options);`
`157`	`157`	`}`
`158`	`158`	`else {`
`159`	`159`	`// handle broken code gracefully`
Original file line number	Diff line number	Diff line change
`@@ -869,6 +869,7 @@ declare module "typescript" {`
`869`	`869`	`getConstantValue(node: EnumMember \| PropertyAccessExpression \| ElementAccessExpression): number;`
`870`	`870`	`isValidPropertyAccess(node: PropertyAccessExpression \| QualifiedName, propertyName: string): boolean;`
`871`	`871`	`getAliasedSymbol(symbol: Symbol): Symbol;`
	`872`	`+ getExportsOfExternalModule(node: ImportDeclaration): Symbol[];`
`872`	`873`	`}`
`873`	`874`	`interface SymbolDisplayBuilder {`
`874`	`875`	`buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;`
Original file line number	Diff line number	Diff line change
`@@ -900,6 +900,7 @@ declare module "typescript" {`
`900`	`900`	`getConstantValue(node: EnumMember \| PropertyAccessExpression \| ElementAccessExpression): number;`
`901`	`901`	`isValidPropertyAccess(node: PropertyAccessExpression \| QualifiedName, propertyName: string): boolean;`
`902`	`902`	`getAliasedSymbol(symbol: Symbol): Symbol;`
	`903`	`+ getExportsOfExternalModule(node: ImportDeclaration): Symbol[];`
`903`	`904`	`}`
`904`	`905`	`interface SymbolDisplayBuilder {`
`905`	`906`	`buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;`
Original file line number	Diff line number	Diff line change
`@@ -901,6 +901,7 @@ declare module "typescript" {`
`901`	`901`	`getConstantValue(node: EnumMember \| PropertyAccessExpression \| ElementAccessExpression): number;`
`902`	`902`	`isValidPropertyAccess(node: PropertyAccessExpression \| QualifiedName, propertyName: string): boolean;`
`903`	`903`	`getAliasedSymbol(symbol: Symbol): Symbol;`
	`904`	`+ getExportsOfExternalModule(node: ImportDeclaration): Symbol[];`
`904`	`905`	`}`
`905`	`906`	`interface SymbolDisplayBuilder {`
`906`	`907`	`buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;`
Original file line number	Diff line number	Diff line change
`@@ -938,6 +938,7 @@ declare module "typescript" {`
`938`	`938`	`getConstantValue(node: EnumMember \| PropertyAccessExpression \| ElementAccessExpression): number;`
`939`	`939`	`isValidPropertyAccess(node: PropertyAccessExpression \| QualifiedName, propertyName: string): boolean;`
`940`	`940`	`getAliasedSymbol(symbol: Symbol): Symbol;`
	`941`	`+ getExportsOfExternalModule(node: ImportDeclaration): Symbol[];`
`941`	`942`	`}`
`942`	`943`	`interface SymbolDisplayBuilder {`
`943`	`944`	`buildTypeDisplay(type: Type, writer: SymbolWriter, enclosingDeclaration?: Node, flags?: TypeFormatFlags): void;`