Skip to content

Commit 113907e

Browse files
fixup! defining a wrapper connection handler with the objective of being generic
1 parent bde6c73 commit 113907e

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

src/GenericConnectionHandler.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ NetworkConnectionState GenericConnectionHandler::update_handleDisconnected() {
9292
return _ch != nullptr ? _ch->update_handleDisconnected() : NetworkConnectionState::INIT;
9393
}
9494

95+
#if not defined(BOARD_HAS_LORA)
9596
unsigned long GenericConnectionHandler::getTime() { // FIXME _ch may be nullptr
9697
return _ch->getTime();
9798
}
@@ -103,3 +104,4 @@ Client & GenericConnectionHandler::getClient() { // FIXME _ch may be nullptr
103104
UDP & GenericConnectionHandler::getUDP() { // FIXME _ch may be nullptr
104105
return _ch->getUDP();
105106
}
107+
#endif

src/GenericConnectionHandler.h

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,15 @@ class GenericConnectionHandler : public ConnectionHandler
3838

3939
GenericConnectionHandler(): _ch(nullptr) {}
4040

41-
unsigned long getTime() override;
42-
Client & getClient() override;
43-
UDP & getUDP() override;
41+
#if defined(BOARD_HAS_NOTECARD) || defined(BOARD_HAS_LORA)
42+
virtual bool available() = 0;
43+
virtual int read() = 0;
44+
virtual int write(const uint8_t *buf, size_t size) = 0;
45+
#else
46+
unsigned long getTime() override;
47+
Client & getClient() override;
48+
UDP & getUDP() override;
49+
#endif
4450

4551
bool updateSetting(const models::NetworkSetting& s) override;
4652

0 commit comments

Comments
 (0)