Skip to content

Commit 330af38

Browse files
Remove the lightning app code (Lightning-AI#20039)
* remove source, tests, docs, workflows * update checkgroup * update codeowners * update workflows * package setup * config files * update * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove entry point * docs * __main__ * remove store * leftover store removals --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 90f23b3 commit 330af38

File tree

898 files changed

+25
-73832
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

898 files changed

+25
-73832
lines changed

.actions/assistant.py

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@
1414
import glob
1515
import logging
1616
import os
17-
import pathlib
1817
import re
1918
import shutil
20-
import tarfile
2119
import tempfile
2220
import urllib.request
2321
from distutils.version import LooseVersion
@@ -35,11 +33,6 @@
3533
"requirements/pytorch/strategies.txt",
3634
"requirements/pytorch/examples.txt",
3735
),
38-
"app": (
39-
"requirements/app/app.txt",
40-
"requirements/app/cloud.txt",
41-
"requirements/app/ui.txt",
42-
),
4336
"fabric": (
4437
"requirements/fabric/base.txt",
4538
"requirements/fabric/strategies.txt",
@@ -216,30 +209,6 @@ def distribute_version(src_folder: str, ver_file: str = "version.info") -> None:
216209
shutil.copy2(ver_template, fpath)
217210

218211

219-
def _download_frontend(pkg_path: str, version: str = "v0.0.0"):
220-
"""Downloads an archive file for a specific release of the Lightning frontend and extracts it to the correct
221-
directory."""
222-
223-
try:
224-
frontend_dir = pathlib.Path(pkg_path, "ui")
225-
download_dir = tempfile.mkdtemp()
226-
227-
shutil.rmtree(frontend_dir, ignore_errors=True)
228-
# TODO: remove this once lightning-ui package is ready as a dependency
229-
frontend_release_url = f"https://lightning-packages.s3.amazonaws.com/ui/{version}.tar.gz"
230-
response = urllib.request.urlopen(frontend_release_url)
231-
232-
file = tarfile.open(fileobj=response, mode="r|gz")
233-
file.extractall(path=download_dir) # noqa: S202
234-
235-
shutil.move(download_dir, frontend_dir)
236-
print("The Lightning UI has successfully been downloaded!")
237-
238-
# If installing from source without internet connection, we don't want to break the installation
239-
except Exception:
240-
print("The Lightning UI downloading has failed!")
241-
242-
243212
def _load_aggregate_requirements(req_dir: str = "requirements", freeze_requirements: bool = False) -> None:
244213
"""Load all base requirements from all particular packages and prune duplicates.
245214
@@ -466,7 +435,7 @@ def pull_docs_files(
466435
raise RuntimeError(f"Requesting file '{zip_url}' does not exist or it is just unavailable.")
467436

468437
with zipfile.ZipFile(zip_file, "r") as zip_ref:
469-
zip_ref.extractall(tmp) # noqa: S202
438+
zip_ref.extractall(tmp)
470439

471440
zip_dirs = [d for d in glob.glob(os.path.join(tmp, "*")) if os.path.isdir(d)]
472441
# check that the extracted archive has only repo folder

.azure/app-cloud-e2e.yml

Lines changed: 0 additions & 206 deletions
This file was deleted.

.github/CODEOWNERS

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
/.actions/ @borda @ethanwharris @justusschock
1212
/.github/ @borda @ethanwharris @justusschock
1313
/.azure/ @borda @ethanwharris @justusschock
14-
/.azure/app-cloud-e2e.yml @awaelchli @ethanwharris @lantiga
1514
/dockers/ @borda @ethanwharris @justusschock
1615
*.yml @borda @ethanwharris @justusschock
1716

@@ -25,7 +24,6 @@
2524
/docs/source-pytorch/conf.py @borda @awaelchli
2625
/docs/source-pytorch/index.rst @williamfalcon @lantiga
2726
/docs/source-pytorch/levels @williamfalcon @lantiga
28-
/docs/source-app/ @williamfalcon @lantiga @tchaton
2927

3028
# PyTorch Lightning
3129
/src/lightning/pytorch @lantiga @borda @tchaton @awaelchli @justusschock
@@ -36,18 +34,10 @@
3634
# Lightning Fabric
3735
/src/lightning/fabric @lantiga @borda @tchaton @awaelchli @justusschock
3836

39-
# Lightning App
40-
/src/lightning/app @tchaton @lantiga @awaelchli @ethanwharris
41-
/src/lightning_app @tchaton @lantiga @awaelchli @ethanwharris
42-
/tests/tests_app @tchaton @lantiga @awaelchli @ethanwharris
43-
/tests/integrations_app @tchaton @lantiga @awaelchli @ethanwharris
44-
/examples/app_* @tchaton @lantiga @awaelchli @ethanwharris
45-
4637
/.github/CODEOWNERS @williamfalcon
4738
/SECURITY.md @williamfalcon @lantiga
4839
/README.md @williamfalcon @lantiga
4940
/setup.py @williamfalcon @borda
5041
/src/pytorch_lightning/__about__.py @williamfalcon @borda
51-
/src/lightning_app/__about__.py @williamfalcon @lantiga @borda
5242
/src/lightning_fabric/__about__.py @williamfalcon @borda @awaelchli
5343
/src/*/__setup__.py @borda @justusschock

.github/CONTRIBUTING.md

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -310,20 +310,6 @@ and the last true master commit is `ccc111` and your first commit is `mmm222`.
310310
git push -f
311311
```
312312

313-
#### How to run an app on the cloud with a local version of lightning
314-
315-
The lightning cloud uses the latest release by default. However, you might want to run your app with some local changes you've made to the lightning framework. To use your local version of lightning on the cloud, set the following environment variable:
316-
317-
```bash
318-
git clone https://github.com/Lightning-AI/lightning.git
319-
cd lightning
320-
pip install -e .
321-
export PACKAGE_LIGHTNING=1 # <- this is the magic to use your version (not mainstream PyPI)!
322-
lightning run app app.py --cloud
323-
```
324-
325-
By setting `PACKAGE_LIGHTNING=1`, lightning packages the lightning source code in your local directory in addition to your app source code and uploads them to the cloud.
326-
327313
### Bonus Workflow Tip
328314

329315
If you don't want to remember all the commands above every time you want to push some code/setup a Lightning Dev environment on a new VM, you can set up bash aliases for some common commands. You can add these to one of your `~/.bashrc`, `~/.zshrc`, or `~/.bash_aliases` files.

.github/ISSUE_TEMPLATE/1_bug_report.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,7 @@ body:
9191
<summary>Current environment</summary>
9292
9393
```
94-
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
9594
#- PyTorch Lightning Version (e.g., 1.5.0):
96-
#- Lightning App Version (e.g., 0.5.2):
9795
#- PyTorch Version (e.g., 2.0):
9896
#- Python version (e.g., 3.9):
9997
#- OS (e.g., Linux):

.github/actions/pkg-install/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ runs:
2525
run: |
2626
import os, glob
2727
28-
lut = {'app': 'lightning_app', 'fabric': 'lightning_fabric', 'pytorch': 'pytorch_lightning'}
28+
lut = {'fabric': 'lightning_fabric', 'pytorch': 'pytorch_lightning'}
2929
act_pkg = lut.get('${{inputs.pkg-name}}', 'lightning')
3030
pkg_sdist = glob.glob('*.tar.gz')[0]
3131
pkg_wheel = glob.glob('*.whl')[0]

.github/actions/prep-apps/action.yml

Lines changed: 0 additions & 38 deletions
This file was deleted.

0 commit comments

Comments
 (0)