Skip to content

Get multiple items in a single function call #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SebastienMelki opened this issue Jul 19, 2022 · 5 comments · May be fixed by #379
Open

Get multiple items in a single function call #324

SebastienMelki opened this issue Jul 19, 2022 · 5 comments · May be fixed by #379
Labels
enhancement

Comments

@SebastienMelki
Copy link

Hello, I was wondering if bigcache could support a getMulti(keys []string) function or if there was a technical limitation preventing it.

Thanks!
@janisz janisz added enhancement and removed bug labels Jul 21, 2022
@janisz
Copy link
Collaborator

janisz commented Jul 21, 2022

Hey, I think it's not a bug but enhancement. I thin it make sens to expose get/set for multiple items as it can boost performance as there will be only single lock. This may be useful to setup/backup the cache.

@cristaloleg WDYT?

@SebastienMelki
Copy link
Author

Hey, I think it's not a bug but enhancement. I thin it make sens to expose get/set for multiple items as it can boost performance as there will be only single lock. This may be useful to setup/backup the cache.

@cristaloleg WDYT?

Yea sorry the bug label came by default and I wasn't able to remove it. I completely agree @janisz , if you can point me to what I should look at I can take a jab at implementing the multi approach.

@cristaloleg
Copy link
Collaborator

Yeah, sounds good. With a multiget we can increase throughput because we will take lock once.

@Hojun-Cho Hojun-Cho mentioned this issue Sep 8, 2022
Closed
@raeidish
Copy link
Contributor

Is this available?

@cristaloleg
Copy link
Collaborator

@raeidish looks so

@raeidish raeidish linked a pull request Oct 15, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get multiple cached values raeidish/bigcache
4 participants
@cristaloleg @janisz @SebastienMelki @raeidish