Open
Description
Feature Request
Add scons to the build workflow
Description
Add Scons to the build and deploy workflow files in GitHub actions. If it fails scons for build/deploy workflow, do not block the PR/deployment (yet).
Additionally, you may consolidate the build and deploy workflows to be a single workflow if you are comfortable doing so.
Additional context
This will allow the AAA to verify that code coming in compiles/transpiles automatically. It paves the way for validating the output of the code to keep the quality of algorithms in the AAA high.
For Algorithm Archive Developers
- This feature can be added to the Master Overview (if it cannot be, explain why in a comment below -- lack of technical expertise, not relevant to the scope of this project, too ambitious)There is a timeline for when this feature can be implementedThe feature has been added to the Master OverviewThe feature has been implemented ( Use Scons in CI with container #959 )
Metadata
Metadata
Assignees
Labels
No labels
Activity
leios commentedon Dec 3, 2021
Is it possible for scons to only build on the "new" content in the PR?
Amaras commentedon Dec 3, 2021
We would then need to keep artifacts.
We can also speed up total compilation time by using parallel compilation (e.g.
scons -j4 --random
for 4 concurrent compilation threads and random to reduce the probability of target collision). However, the longest part of the build checking is pulling the Dockerfile, so is this really a problem for now?ntindle commentedon Dec 4, 2021
I understand the desire for this but we discussed on discord the merits of building the whole thing every time and I encourage you to review it
ntindle commentedon Dec 4, 2021
Fixed in #959