[Obs AI Assistant] Remove semantic_text migration (elastic#220886)

## Background
The semantic text migration was added in 8.17 along with the move to
semantic_text field (elastic#186499).

## Suggestion

We should remove the semantic_text migration starting in 9.1. Reasons:

- The migration has recently caused severe disruption on a number of
clusters (elastic#220255).
- The migration may no longer be needed. Users are required to upgrade
Elasticsearch to 8.18 in order to update to 9.0, or 8.19 to upgrade to
9.1. This could mean that users are guaranteed to have run the migration
previously, when upgrading Kibana to 9.1 (needs to be double checked
with Kibana folks)

---------

Co-authored-by: Viduni Wickramarachchi <[email protected]>
Co-authored-by: kibanamachine <[email protected]>

Author: 3 people

x-pack/platform/packages/shared/kbn-ai-assistant/src/knowledge_base/welcome_message_knowledge_base.test.tsx

@@ -83,7 +83,6 @@ describe('WelcomeMessageKnowledgeBase', () => {
       status: {
         value: {
           enabled: true,
-          endpoint: { inference_id: 'inference_id' },
           kbState: KnowledgeBaseState.DEPLOYING_MODEL,
           concreteWriteIndex: 'my-index',
           currentInferenceId: 'inference_id',
@@ -130,7 +129,6 @@ describe('WelcomeMessageKnowledgeBase', () => {
         value: {
           ...kb.status.value,
           enabled: true,
-          endpoint: { inference_id: 'inference_id' },
           kbState: KnowledgeBaseState.READY,
           concreteWriteIndex: 'my-index',
           currentInferenceId: 'inference_id',
@@ -156,7 +154,6 @@ describe('WelcomeMessageKnowledgeBase', () => {
       status: {
         value: {
           enabled: true,
-          endpoint: { inference_id: 'inference_id' },
           kbState: KnowledgeBaseState.DEPLOYING_MODEL,
           concreteWriteIndex: 'my-index',
           currentInferenceId: 'inference_id',
@@ -190,7 +187,6 @@ describe('WelcomeMessageKnowledgeBase', () => {
       status: {
         value: {
           enabled: true,
-          endpoint: { inference_id: 'inference_id' },
           kbState: KnowledgeBaseState.ERROR,
           concreteWriteIndex: 'my-index',
           currentInferenceId: 'inference_id',
@@ -226,7 +222,6 @@ describe('WelcomeMessageKnowledgeBase', () => {
       status: {
         value: {
           enabled: true,
-          endpoint: { inference_id: 'inference_id' },
           kbState: KnowledgeBaseState.DEPLOYING_MODEL,
           concreteWriteIndex: 'my-index',
           currentInferenceId: 'inference_id',
@@ -258,7 +253,6 @@ describe('WelcomeMessageKnowledgeBase', () => {
       status: {
         value: {
           kbState: KnowledgeBaseState.READY,
-          endpoint: { inference_id: 'inference_id' },
           enabled: true,
           concreteWriteIndex: 'my-index',
           currentInferenceId: 'inference_id',

x-pack/platform/plugins/shared/observability_ai_assistant/server/routes/knowledge_base/route.ts

@@ -34,7 +34,7 @@ const getKnowledgeBaseStatus = createObservabilityAIAssistantServerRoute({
   ): Promise<{
     errorMessage?: string;
     enabled: boolean;
-    endpoint?: Partial<InferenceInferenceEndpointInfo>;
+    endpoint?: InferenceInferenceEndpointInfo;
     modelStats?: Partial<MlTrainedModelStats>;
     kbState: KnowledgeBaseState;
     currentInferenceId?: string | undefined;

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts

@@ -70,7 +70,6 @@ import { ObservabilityAIAssistantPluginStartDependencies } from '../../types';
 import { ObservabilityAIAssistantConfig } from '../../config';
 import { waitForKbModel, warmupModel } from '../inference_endpoint';
 import { reIndexKnowledgeBaseWithLock } from '../knowledge_base_service/reindex_knowledge_base';
-import { populateMissingSemanticTextFieldWithLock } from '../startup_migrations/populate_missing_semantic_text_fields';
 import { createOrUpdateKnowledgeBaseIndexAssets } from '../index_assets/create_or_update_knowledge_base_index_assets';
 import { getInferenceIdFromWriteIndex } from '../knowledge_base_service/get_inference_id_from_write_index';
 
@@ -675,16 +674,15 @@ export class ObservabilityAIAssistantClient {
 
     logger.debug(`Setting up knowledge base with inference_id: ${nextInferenceId}`);
 
-    const currentInferenceId = await getInferenceIdFromWriteIndex(esClient).catch(() => {
-      logger.debug(
-        `Current KB write index does not have an inference_id. This is to be expected for indices created before 8.16`
-      );
-      return undefined;
-    });
-
+    const currentInferenceId = await getInferenceIdFromWriteIndex(esClient, logger);
     if (currentInferenceId === nextInferenceId) {
       logger.debug('Inference ID is unchanged. No need to re-index knowledge base.');
-      warmupModel({ esClient, logger, inferenceId: nextInferenceId }).catch(() => {});
+      const warmupModelPromise = warmupModel({ esClient, logger, inferenceId: nextInferenceId });
+      if (waitUntilComplete) {
+        logger.debug('Waiting for warmup to complete...');
+        await warmupModelPromise;
+        logger.debug('Warmup completed.');
+      }
       return { reindex: false, currentInferenceId, nextInferenceId };
     }
 
@@ -711,12 +709,6 @@ export class ObservabilityAIAssistantClient {
           logger,
           esClient,
         });
-        await populateMissingSemanticTextFieldWithLock({
-          core,
-          logger,
-          config: this.dependencies.config,
-          esClient: this.dependencies.esClient,
-        });
       })
       .catch((e) => {
         if (isLockAcquisitionError(e)) {
@@ -730,7 +722,9 @@ export class ObservabilityAIAssistantClient {
       });
 
     if (waitUntilComplete) {
+      logger.debug('Waiting for knowledge base setup to complete...');
       await kbSetupPromise;
+      logger.debug('Knowledge base setup completed.');
     }
 
     return { reindex: true, currentInferenceId, nextInferenceId };

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/index_assets/create_or_update_conversation_index_assets.ts

@@ -19,7 +19,7 @@ export async function createOrUpdateConversationIndexAssets({
   core: CoreSetup<ObservabilityAIAssistantPluginStartDependencies>;
 }) {
   try {
-    logger.debug('Setting up index assets');
+    logger.debug('Setting up conversation index assets');
     const [coreStart] = await core.getStartServices();
     const { asInternalUser } = coreStart.elasticsearch.client;
 

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/index_assets/create_or_update_knowledge_base_index_assets.ts

@@ -53,15 +53,15 @@ export async function createOrUpdateKnowledgeBaseIndexAssets({
       },
     });
 
-    const writeIndexInferenceId = await getInferenceIdFromWriteIndex(esClient).catch(
-      () => undefined
-    );
-    logger.debug(`Current write index inference id: ${writeIndexInferenceId}`);
+    const writeIndexInferenceId = await getInferenceIdFromWriteIndex(esClient, logger);
 
     // Knowledge base: write index
     // `createConcreteWriteIndex` will create the write index, or update the index mappings if the index already exists
     // only invoke `createConcreteWriteIndex` if the write index does not exist or the inferenceId in the component template is the same as the one in the write index
     if (!writeIndexInferenceId || writeIndexInferenceId === componentTemplateInferenceId) {
+      logger.debug(
+        `Creating or updating mappings for knowledge base write index. Inference ID: ${componentTemplateInferenceId}`
+      );
       const kbAliasName = resourceNames.writeIndexAlias.kb;
       await createConcreteWriteIndex({
         esClient: asInternalUser,
@@ -76,6 +76,10 @@ export async function createOrUpdateKnowledgeBaseIndexAssets({
         },
         dataStreamAdapter: getDataStreamAdapter({ useDataStreamForAlerts: false }),
       });
+    } else {
+      logger.debug(
+        `Knowledge base write index already exists with a different inference ID (${writeIndexInferenceId}) than the inference ID in the component template (${componentTemplateInferenceId}). Skipping update.`
+      );
     }
 
     logger.info('Successfully set up knowledge base index assets');

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/index_assets/update_existing_index_assets.ts

@@ -6,7 +6,6 @@
  */
 
 import type { CoreSetup, Logger } from '@kbn/core/server';
-import { ELSER_ON_ML_NODE_INFERENCE_ID } from '../../../common';
 import type { ObservabilityAIAssistantPluginStartDependencies } from '../../types';
 import { createOrUpdateConversationIndexAssets } from './create_or_update_conversation_index_assets';
 import { createOrUpdateKnowledgeBaseIndexAssets } from './create_or_update_knowledge_base_index_assets';
@@ -43,13 +42,9 @@ export async function updateExistingIndexAssets({
   if (doesKbIndexExist) {
     logger.debug('Found index for knowledge base. Updating index assets.');
 
-    const currentInferenceId = await getInferenceIdFromWriteIndex(esClient).catch(() => {
-      logger.debug(
-        `Current KB write index does not have an inference_id. This is to be expected for indices created before 8.16`
-      );
-      return ELSER_ON_ML_NODE_INFERENCE_ID;
-    });
-
-    await createOrUpdateKnowledgeBaseIndexAssets({ logger, core, inferenceId: currentInferenceId });
+    const inferenceId = await getInferenceIdFromWriteIndex(esClient, logger);
+    if (inferenceId) {
+      await createOrUpdateKnowledgeBaseIndexAssets({ logger, core, inferenceId });
+    }
   }
 }

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/inference_endpoint.ts

@@ -107,23 +107,22 @@ export async function getKbModelStatus({
   isReIndexing: boolean;
 }> {
   const enabled = config.enableKnowledgeBase;
-  const concreteWriteIndex = await getConcreteWriteIndex(esClient);
+  const concreteWriteIndex = await getConcreteWriteIndex(esClient, logger);
   const isReIndexing = await isReIndexInProgress({ esClient, logger, core });
+  const currentInferenceId = await getInferenceIdFromWriteIndex(esClient, logger);
 
-  const currentInferenceId = await getInferenceIdFromWriteIndex(esClient).catch(() => undefined);
   if (!inferenceId) {
     if (!currentInferenceId) {
-      logger.error('Inference id not provided and not found in write index');
       return {
         enabled,
-        errorMessage: 'Inference id not found',
+        errorMessage: 'Inference ID not found in write index',
+        currentInferenceId: undefined,
         kbState: KnowledgeBaseState.NOT_INSTALLED,
         concreteWriteIndex,
         isReIndexing,
       };
     }
 
-    logger.debug(`Using current inference id "${currentInferenceId}" from write index`);
     inferenceId = currentInferenceId;
   }
 
@@ -226,8 +225,8 @@ export async function getKbModelStatus({
     enabled,
     modelStats,
     kbState,
-    currentInferenceId,
     concreteWriteIndex,
+    currentInferenceId,
     isReIndexing,
   };
 }
@@ -245,17 +244,27 @@ export async function waitForKbModel({
   config: ObservabilityAIAssistantConfig;
   inferenceId: string;
 }) {
+  logger.debug(`Waiting for knowledge base model to be ready for inference ID "${inferenceId}" !!`);
+
   // Run a dummy inference to trigger the model to deploy
   // This is a workaround for the fact that the model may not be deployed yet
   await warmupModel({ esClient, logger, inferenceId }).catch(() => {});
 
   return pRetry(
     async () => {
-      const { kbState } = await getKbModelStatus({ core, esClient, logger, config, inferenceId });
+      logger.debug(`Checking knowledge base model status for inference ID "${inferenceId}"`);
+      const { kbState } = await getKbModelStatus({
+        core,
+        esClient,
+        logger,
+        config,
+        inferenceId,
+      });
 
       if (kbState !== KnowledgeBaseState.READY) {
-        logger.debug('Knowledge base model is not yet ready. Retrying...');
-        throw new Error('Knowledge base model is not yet ready');
+        const message = `Knowledge base model is not yet ready. kbState = ${kbState}, `;
+        logger.debug(message);
+        throw new Error(message);
       }
 
       logger.debug('Knowledge base model is ready.');
@@ -273,7 +282,7 @@ export async function warmupModel({
   logger: Logger;
   inferenceId: string;
 }) {
-  logger.debug(`Running inference to trigger model deployment for "${inferenceId}"`);
+  logger.debug(`Warming up model for "${inferenceId}"`);
   await pRetry(
     () =>
       esClient.asInternalUser.inference.inference({
@@ -282,6 +291,6 @@ export async function warmupModel({
       }),
     { retries: 10 }
   ).catch((error) => {
-    logger.error(`Unable to run inference on endpoint "${inferenceId}": ${error.message}`);
+    logger.error(`Unable to warm up model for "${inferenceId}": ${error.message}`);
   });
 }

x-pack/platform/plugins/shared/observability_ai_assistant/server/service/knowledge_base_service/get_inference_id_from_write_index.ts

@@ -8,36 +8,54 @@
 import { ElasticsearchClient } from '@kbn/core-elasticsearch-server';
 import { MappingSemanticTextProperty } from '@elastic/elasticsearch/lib/api/types';
 import { first } from 'lodash';
+import { Logger } from '@kbn/logging';
 import { resourceNames } from '..';
 
-export async function getConcreteWriteIndex(esClient: { asInternalUser: ElasticsearchClient }) {
+export async function getConcreteWriteIndex(
+  esClient: { asInternalUser: ElasticsearchClient },
+  logger: Logger
+) {
   try {
     const res = await esClient.asInternalUser.indices.getAlias({
       name: resourceNames.writeIndexAlias.kb,
     });
 
     return first(Object.keys(res));
   } catch (error) {
+    logger.debug(
+      `Unable to get concrete write index for index alias "${resourceNames.writeIndexAlias.kb}": ${error}`
+    );
     return;
   }
 }
 
-export async function getInferenceIdFromWriteIndex(esClient: {
-  asInternalUser: ElasticsearchClient;
-}): Promise<string> {
-  const response = await esClient.asInternalUser.indices.getMapping({
-    index: resourceNames.writeIndexAlias.kb,
-  });
+export async function getInferenceIdFromWriteIndex(
+  esClient: {
+    asInternalUser: ElasticsearchClient;
+  },
+  logger: Logger
+): Promise<string | undefined> {
+  try {
+    const response = await esClient.asInternalUser.indices.getMapping({
+      index: resourceNames.writeIndexAlias.kb,
+    });
 
-  const [indexName, indexMappings] = Object.entries(response)[0];
+    const [indexName, indexMappings] = Object.entries(response)[0];
 
-  const inferenceId = (
-    indexMappings.mappings?.properties?.semantic_text as MappingSemanticTextProperty
-  )?.inference_id;
+    const inferenceId = (
+      indexMappings.mappings?.properties?.semantic_text as MappingSemanticTextProperty
+    )?.inference_id;
 
-  if (!inferenceId) {
-    throw new Error(`inference_id not found in field mappings for index ${indexName}`);
-  }
+    if (!inferenceId) {
+      logger.debug(`Inference ID missing in field mappings for index ${indexName}.`);
+      return undefined;
+    }
 
-  return inferenceId;
+    return inferenceId;
+  } catch (error) {
+    logger.debug(
+      `Unable to get index mapping for index alias "${resourceNames.writeIndexAlias.kb}": ${error}`
+    );
+    return undefined;
+  }
 }