Fish: Allow cd aliasing

[fennewald]

Really cool plugin, just started using it with fish.

Ran into issue trying to alias cd to z, where zoxide tries to call my alias, which calls zoxide, which calls my alias, until stack overflow.

zoxide init fish outputs this internal command (among other things):

function __zoxide_cd
    cd $argv
    and commandline -f repaint
end

However, it should be:

function __zoxide_cd
    command cd $argv
    and commandline -f repaint
end

In fish, command makes sure to call out instead of calling functions.

I'm not familiar with zoxide's codebase, so I didn't know where to put the fix, otherwise I'd PR myself.

[thaliaarchi]

The fix looks like it would be on this line.

[dnlmlr]

I would like to reopen this issue since it still (or more like again) exists

Since the referenced pullrequest was merged, the line in question was first changed in 7b00d5a and then fully reverted in acc9059 .

I just started trying out fish, so I don't know a lot about it. Anyways: As far as I understand, the problem is that fish provides a builtin cd command, as well as a function wrapping the builtin command with extra functionality. So just using builtin cd in the fish template would remove that added functionality.

I also have an idea on how this could be solved:

The recursion problem occurs when using alias cd=z because zoxides z will simply call cd in the end and therefore call itself again.
One solution might be to use functions -c to copy fishs original cd function into something like __fish_cd and use that in zoxides fish template.

That might look like this:

# At the beginning of the fish template create the copy, but only if it doesn't exists yet to keep idempotency
if ! type -q __fish_cd
    functions -c cd __fish_cd
end

And then in the __zoxide_cd function use __fish_cd $argv instead of cd $argv

I'll create a pull request when I find the time, except if you give a reason why this is bad before that 😄

[ajeetdsouza]

@dnlmlr that's a great idea, go ahead.

[federicotorrielli]

This problem is still present for me: I'm multiple-sourcing the config.fish (starship and zoxide) and placing the alias after the source, but it's still creating the recursive call @ajeetdsouza

[ajeetdsouza]

@federicotorrielli are you compiling and running the latest commit from GitHub? Because this feature hasn't made it into a point release yet.

[federicotorrielli]

I'm so stupid, I forgot to check the release tab!
No I just installed the AUR package and that's all, sorry again! @ajeetdsouza

[ajeetdsouza]

Haha, that's alright! I'll create a release for this sometime soon.

[pnunn]

I've just done a fresh install of zoxide from apt on a kde neon install and have the infinite loop issue with fish still.

The initial apt install was an old version by the looks of things so I have now purged that and got 0.8.3 deb and installed that, but, I get the same effect if I alias cd z in my config.fish.

Peter.

[ajeetdsouza]

@pnunn can you verify that you're actually on the latest version?

zoxide --version

[pnunn]

Thanks @ajeetdsouza. That returns 0.8.3 so it seems to be the correct version.