Hide skip sponsor button while YouTube's own ads are playing #2280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajayyy Can you tell me why you closed the pr? |
|
It is not a good solution to just hide it with css |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
What does the change do: SponsorBlock will now be hidden during YouTube's own ads.
The skip sponsor button can appear during YouTube ads. If you accidentally click skip, as sometimes YouTube ads start just before a sponsorBlock, YouTube will notify the user that it thinks that an adblocker is being used.
Example of what happened before the change:
