Skip to content

fix: remove stale inert after performing keyboard drag and drop in virtualized tree #8574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

fix: remove stale inert after performing keyboard drag and drop in virtualized tree #8574

merged 1 commit into from
Jul 18, 2025
+53 −6

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Jul 18, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu LFDanLu changed the title fix: Fix stale inert after performing keyboard drag and drop in virtualized tree fix: stale inert after performing keyboard drag and drop in virtualized tree Jul 18, 2025
@LFDanLu LFDanLu changed the title fix: stale inert after performing keyboard drag and drop in virtualized tree fix: remove stale inert after performing keyboard drag and drop in virtualized tree Jul 18, 2025
@rspbot
Copy link

rspbot commented Jul 18, 2025

Build successful! 🎉

reidbarber
reidbarber approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can't reproduce the original issue

@LFDanLu LFDanLu added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit 5653514 Jul 18, 2025
31 of 34 checks passed
@LFDanLu LFDanLu deleted the fix_tree_dnd_reorder branch July 18, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LFDanLu @rspbot @snowystinger @reidbarber