[Bug]: Cannot add decimal to filter for Amount while typing

[cculbertson81]

Verified issue does not already exist?

• I have searched and found no existing issue

What happened?

When attempting to filter by Amount, I am unable to enter a decimal amount by typing the amount in its natural order. I must arrow back and insert the decimal in the proper location. Copy/pasting an amount with a decimal included works as expected.

How can we reproduce the issue?

1. Attempt to filter transactions by Amount.
2. Type any amount that includes a decimal.
3. Note that the decimal is not added in the normal course of typing.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 11

[misu-dev]

Could you check if this is fixed here: https://deploy-preview-5639.demo.actualbudget.org/ ?

[cculbertson81]

Could you check if this is fixed here: https://deploy-preview-5639.demo.actualbudget.org/ ?

I can confirm that I can enter decimals normally in the preview build.

One interesting side effect of the update is that when filtering on Amount, Amount (inflow), or Amount (outflow), extra care needs to be taken to toggle the -/+ in the entry box, or unexpected results may be returned. This is especially apparent where Amount (inflow) and Amount (outflow) are always considered positive.

[misu-dev]

Thanks, i did not catch that yet. I will have a look into it

[misu-dev]

I updated the PR. It should now behave more intuitively

[cculbertson81]

I updated the PR. It should now behave more intuitively

I see that Amount (inflow) defaults to + now, which is great. Amount (outflow) is still defaulting to -, which gives unexpected results. When filtering by inflow and outflow, the amount should always be positive.

Another piece of feedback is that in the PR build, the input defaults to 0.00, so I need to select all or press Backspace to remove the default value to enter my filter criteria.

[misu-dev]

Ok, I see what you mean. I will have a look at it again

[misu-dev]

Sorry it took me this long. I updated it again, now the outflow is also always positive and it should behave better