Address review comments

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

CHANGELOG.rst

@@ -31,6 +31,9 @@ Unreleased
   by adding "#from" or "#to" fragments at the end of the download URLs.
   https://github.com/nexB/scancode.io/issues/708
 
+- Add an add-on pipeline for collecting DWARF debug symbol compilation 
+  unit paths when available from elfs https://github.com/nexB/purldb/issues/260.
+
 v33.0.0 (2024-01-16)
 --------------------
 

…anpipe/pipelines/get_dwarfs_from_elfs.py …anpipe/pipelines/inspect_elf_binaries.pyscanpipe/pipelines/get_dwarfs_from_elfs.py renamed to scanpipe/pipelines/inspect_elf_binaries.py scanpipe/pipelines/get_dwarfs_from_elfs.py renamed to scanpipe/pipelines/inspect_elf_binaries.py

@@ -39,7 +39,7 @@ def steps(cls):
 
     def collect_dwarf_source_path_references(self):
         """
-        Update ``extra_data`` of project with
+        Update ``extra_data`` of elf files with
         dwarf data extracted from elf files.
         """
         for elf in self.project.codebaseresources.elfs():

scanpipe/tests/test_models.py

@@ -2087,44 +2087,49 @@ def test_scanpipe_codebase_resource_queryset_has_directory_content_fingerprint(
 
     def test_scanpipe_codebase_resource_queryset_elfs(self):
         project = Project.objects.create(name="Test")
-        resource_starting_with_elf_and_executable_in_file_type = CodebaseResource.objects.create(
+        resource_starting_with_elf_and_executable_in_file_type = CodebaseResource(
             file_type="""ELF 32-bit LSB executable, ARM, version 1 (ARM), statically
              linked, with debug_info, not stripped""",
             project=project,
             path="a",
             type=CodebaseResource.Type.FILE,
         )
-        resource_with_executable_in_file_type = CodebaseResource.objects.create(
+        resource_starting_with_elf_and_executable_in_file_type.save()
+        resource_with_executable_in_file_type = CodebaseResource(
             file_type="""32-bit LSB executable, ARM, version 1 (ARM), statically
               linked, with debug_info, not stripped""",
             project=project,
             path="b",
             type=CodebaseResource.Type.FILE,
         )
-        resource_starting_with_elf_in_file_type = CodebaseResource.objects.create(
+        resource_with_executable_in_file_type.save()
+        resource_starting_with_elf_in_file_type = CodebaseResource(
             file_type="""ELF 32-bit LSB resourcable, ARM, version 1 (ARM), statically
              linked, with debug_info, not stripped""",
             project=project,
             path="c",
             type=CodebaseResource.Type.FILE,
         )
-        resource = CodebaseResource.objects.create(
+        resource_starting_with_elf_in_file_type.save()
+        resource = CodebaseResource(
             file_type="""32-bit LSB relocatable, ARM, version 1 (ARM), statically
               linked, with debug_info, not stripped""",
             project=project,
             path="d",
             type=CodebaseResource.Type.FILE,
         )
-        resource_starting_with_elf_and_relocatable_in_file_type = CodebaseResource.objects.create(
+        resource.save()
+        resource_starting_with_elf_and_relocatable_in_file_type = CodebaseResource(
             file_type="""ELF 32-bit LSB relocatable, ARM, version 1 (ARM), statically
               linked, with debug_info, not stripped""",
             project=project,
             path="e",
             type=CodebaseResource.Type.FILE,
         )
+        resource_starting_with_elf_and_relocatable_in_file_type.save()
         paths = [str(resource.path) for resource in project.codebaseresources.elfs()]
-        assert "e" in paths
-        assert "a" in paths
+        self.assertTrue("e" in paths)
+        self.assertTrue("a" in paths)
 
 
 class ScanPipeModelsTransactionTest(TransactionTestCase):

setup.cfg

@@ -127,7 +127,7 @@ scancodeio_pipelines =
     analyze_root_filesystem_or_vm_image = scanpipe.pipelines.root_filesystem:RootFS
     analyze_windows_docker_image = scanpipe.pipelines.docker_windows:DockerWindows
     find_vulnerabilities = scanpipe.pipelines.find_vulnerabilities:FindVulnerabilities
-    get_dwarfs_from_elfs = scanpipe.pipelines.get_dwarfs_from_elfs:InspectElfBinaries
+    inspect_elf_binaries = scanpipe.pipelines.inspect_elf_binaries:InspectElfBinaries
     inspect_packages = scanpipe.pipelines.inspect_packages:InspectPackages
     load_inventory = scanpipe.pipelines.load_inventory:LoadInventory
     map_deploy_to_develop = scanpipe.pipelines.deploy_to_develop:DeployToDevelop