Skip to content

Commit a805a79

Browse files
oblomov-devoblomov-dev
authored
update atc check (#507)
1 parent 16a9a5c commit a805a79

10 files changed

+38
-56
lines changed

‎src/z2ui5_cl_demo_app_058.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ CLASS z2ui5_cl_demo_app_058 IMPLEMENTATION.
212212
lo_columns->column(
213213
minscreenwidth = shift_right( CONV string( lv_width ) ) && `px`
214214
demandpopin = abap_true
215-
width = lr_field->length )->text( text = CONV char10( lr_field->title ) ).
215+
width = lr_field->length )->text( text = CONV string( lr_field->title ) ).
216216
lv_width = lv_width + 10.
217217
ENDLOOP.
218218

‎src/z2ui5_cl_demo_app_116.clas.abap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ CLASS z2ui5_cl_demo_app_116 DEFINITION
3737

3838
DATA prodh_nodes TYPE ty_prodh_nodes .
3939
DATA is_initialized TYPE abap_bool .
40-
DATA gv_user TYPE uname.
40+
DATA gv_user TYPE c length 12.
4141
DATA gv_date TYPE d.
4242

4343
DATA mv_run_js TYPE abap_bool VALUE abap_false.
@@ -145,8 +145,8 @@ CLASS Z2UI5_CL_DEMO_APP_116 IMPLEMENTATION.
145145
text = 'Date:'
146146
)->get_parent(
147147
)->vertical_layout( class = 'sapUiSmallMarginBeginEnd'
148-
)->text( text = client->_bind( gv_user )
149-
)->text( text = client->_bind( gv_date ) ).
148+
)->text( client->_bind( gv_user )
149+
)->text( client->_bind( gv_date ) ).
150150

151151

152152
DATA(sections) = page->sections( ).

‎src/z2ui5_cl_demo_app_126.clas.abap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ CLASS Z2UI5_CL_DEMO_APP_126 IMPLEMENTATION.
107107
UP TO 100 ROWS.
108108

109109
CATCH cx_root.
110-
111110
ENDTRY.
112111

113112
ASSIGN mt_table_tmp->* TO <table_tmp>.

‎src/z2ui5_cl_demo_app_130.clas.abap

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION
3232
ty_t_filter_pop TYPE STANDARD TABLE OF ty_s_filter_pop WITH EMPTY KEY .
3333
TYPES:
3434
BEGIN OF ty_s_fieldsdb,
35-
screen_name TYPE char10,
36-
field TYPE char10,
37-
field_doma TYPE char10,
35+
screen_name TYPE string,
36+
field TYPE string,
37+
field_doma TYPE string,
3838
END OF ty_s_fieldsdb .
3939
TYPES
4040
ty_t_fieldsdb TYPE STANDARD TABLE OF ty_s_fieldsdb WITH DEFAULT KEY .
@@ -46,33 +46,33 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION
4646
END OF ty_s_fields .
4747
TYPES:
4848
BEGIN OF ty_s_var_val,
49-
screen_name TYPE char10,
50-
var TYPE char10,
51-
field TYPE char10,
52-
guid TYPE string,
53-
sign TYPE char1,
54-
opt TYPE char2,
55-
low TYPE char255,
56-
high TYPE char255,
49+
screen_name TYPE string,
50+
var TYPE string,
51+
field TYPE string,
52+
guid TYPE string,
53+
sign TYPE string,
54+
opt TYPE string,
55+
low TYPE string,
56+
high TYPE string,
5757
END OF ty_s_var_val .
5858
TYPES
5959
ty_t_var_val TYPE STANDARD TABLE OF ty_s_var_val WITH DEFAULT KEY .
6060
TYPES:
6161
BEGIN OF ty_s_variants,
62-
screen_name TYPE char10,
63-
var TYPE char10,
62+
screen_name TYPE string,
63+
var TYPE string,
6464
descr TYPE string,
6565
END OF ty_s_variants .
6666
TYPES
6767
ty_t_variants TYPE STANDARD TABLE OF ty_s_variants WITH DEFAULT KEY .
6868
TYPES
6969
BEGIN OF ty_s_var_pop.
7070
INCLUDE TYPE ty_s_variants.
71-
TYPES: selkz TYPE xfeld,
71+
TYPES: selkz TYPE abap_bool,
7272
END OF ty_s_var_pop .
7373
TYPES:
7474
BEGIN OF ty_s_screens,
75-
screen_name TYPE char10,
75+
screen_name TYPE string,
7676
descr TYPE string,
7777
END OF ty_s_screens .
7878

@@ -127,7 +127,7 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION
127127
METHODS get_txt
128128
IMPORTING
129129
roll TYPE string
130-
type TYPE char1 OPTIONAL
130+
type TYPE string OPTIONAL
131131
RETURNING VALUE(result) TYPE string.
132132

133133
METHODS get_txt_l

‎src/z2ui5_cl_demo_app_153.clas.abap

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@ CLASS z2ui5_cl_demo_app_153 DEFINITION PUBLIC.
88
TYPES:
99
BEGIN OF ty_dataset2,
1010
label TYPE string,
11-
* type TYPE string,
1211
data TYPE string_table,
1312
border_width TYPE i,
14-
* border_color TYPE string,
1513
border_radius TYPE i,
1614
border_skipped TYPE abap_bool,
17-
border_skipped_xfeld TYPE xfeld,
15+
border_skipped_xfeld TYPE abap_bool,
1816
END OF ty_dataset2.
1917

2018
TYPES:
@@ -29,7 +27,6 @@ CLASS z2ui5_cl_demo_app_153 DEFINITION PUBLIC.
2927
show_line TYPE abap_bool,
3028
lvl2 TYPE ty_dataset2,
3129
END OF ty_dataset.
32-
3330
TYPES ty_datasets TYPE STANDARD TABLE OF ty_dataset WITH DEFAULT KEY.
3431

3532
TYPES:
@@ -43,11 +40,9 @@ CLASS z2ui5_cl_demo_app_153 DEFINITION PUBLIC.
4340
data TYPE ty_data,
4441
END OF ty_chart .
4542

46-
4743
DATA ms_struc TYPE ty_chart.
4844
DATA ms_struc2 TYPE ty_chart.
4945

50-
5146
METHODS ui5_display.
5247
METHODS ui5_event.
5348

@@ -76,8 +71,6 @@ CLASS z2ui5_cl_demo_app_153 IMPLEMENTATION.
7671
)->button(
7772
text = 'Rountrip...'
7873
press = client->_event( 'POPUP' )
79-
* )->input( value = client->_bind_edit( mv_long_long_long_long_value ) width = `10%`
80-
* )->input( value = client->_bind_edit( mv_long_long_long_long_value ) width = `10%`
8174
).
8275

8376
client->view_display( view->stringify( ) ).
@@ -95,9 +88,6 @@ CLASS z2ui5_cl_demo_app_153 IMPLEMENTATION.
9588
client->message_box_display( `structure changed error` ).
9689
RETURN.
9790
ENDIF.
98-
99-
100-
10191
client->message_toast_display( `everything works as expected` ).
10292

10393
WHEN 'BACK'.
@@ -110,36 +100,29 @@ CLASS z2ui5_cl_demo_app_153 IMPLEMENTATION.
110100

111101
METHOD z2ui5_if_app~main.
112102

113-
DATA ls_dataset TYPE ty_dataset.
114-
115103
me->client = client.
116104

117-
IF client->get( )-check_on_navigated = abap_true.
105+
IF client->check_on_navigated( ).
118106

119107
ms_struc-data-labels = VALUE #( ( `Jan` ) ( `Feb` ) ( `Mar` ) ( `Apr` ) ( `May` ) ( `Jun` ) ).
120108

109+
DATA ls_dataset TYPE ty_dataset.
121110
CLEAR ls_dataset.
122111
ls_dataset-label = 'Fully Rounded'.
123112
ls_dataset-border_width = 2.
124113
ls_dataset-border_radius = 200.
125114

126115
ls_dataset-data = VALUE #( ( `1` ) ( `-12` ) ( `19` ) ( `3` ) ( `5` ) ( `-2` ) ( `3` ) ).
127116

128-
129-
130117
APPEND ls_dataset TO ms_struc-data-datasets.
131-
132-
133-
134118
ms_struc2 = ms_struc.
135119

136-
137-
138120
ui5_display( ).
139121
RETURN.
140122
ENDIF.
141123

142124
ui5_event( ).
143125

144126
ENDMETHOD.
127+
145128
ENDCLASS.

‎src/z2ui5_cl_demo_app_187.clas.abap

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ CLASS z2ui5_cl_demo_app_187 DEFINITION PUBLIC.
33
PUBLIC SECTION.
44
INTERFACES z2ui5_if_app.
55

6+
PROTECTED SECTION.
7+
PRIVATE SECTION.
68
ENDCLASS.
79

810
CLASS z2ui5_cl_demo_app_187 IMPLEMENTATION.
@@ -35,8 +37,10 @@ CLASS z2ui5_cl_demo_app_187 IMPLEMENTATION.
3537
CASE client->get( )-event.
3638

3739
WHEN 'SY'.
38-
MESSAGE ID 'NET' TYPE 'E' NUMBER '001' INTO DATA(lv_dummy).
39-
client->message_box_display( sy ).
40+
DATA(ls_msg2) = z2ui5_cl_util=>msg_get_by_msg(
41+
id = 'NET'
42+
no = `001` ).
43+
client->message_box_display( ls_msg2 ).
4044

4145
WHEN 'BAPIRET'.
4246

‎src/z2ui5_cl_demo_app_192.clas.abap

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ CLASS z2ui5_cl_demo_app_192 DEFINITION PUBLIC.
66
DATA client TYPE REF TO z2ui5_if_client.
77

88
TYPES: BEGIN OF ty_s_key_value,
9-
fname TYPE char30,
9+
fname TYPE string,
1010
value TYPE string,
11-
tabname TYPE char30,
11+
tabname TYPE string,
1212
comp TYPE abap_componentdescr,
1313
END OF ty_s_key_value,
1414
ty_t_key_values TYPE STANDARD TABLE OF ty_s_key_value WITH EMPTY KEY.
@@ -20,8 +20,6 @@ CLASS z2ui5_cl_demo_app_192 DEFINITION PUBLIC.
2020
END OF ty_s_merged_data,
2121
ty_t_merged_data TYPE STANDARD TABLE OF ty_s_merged_data WITH EMPTY KEY.
2222

23-
24-
2523
DATA mt_new_data2 TYPE STANDARD TABLE OF REF TO z2ui5_cl_demo_app_193 WITH EMPTY KEY.
2624

2725
TYPES:
@@ -66,19 +64,18 @@ CLASS z2ui5_cl_demo_app_192 IMPLEMENTATION.
6664
navbuttonpress = client->_event( val = 'BACK' )
6765
shownavbutton = abap_true
6866
)->header_content( ).
69-
7067
client->view_display( view->stringify( ) ).
7168

7269
ENDMETHOD.
7370

7471
METHOD z2ui5_if_app~main.
75-
xml_parse( ).
7672

73+
xml_parse( ).
7774
me->client = client.
7875
get_data( ).
7976
ui5_display( ).
80-
8177
xml_stringify( ).
78+
8279
ENDMETHOD.
8380

8481
METHOD get_data.
@@ -94,7 +91,6 @@ CLASS z2ui5_cl_demo_app_192 IMPLEMENTATION.
9491
DATA(kopf) = REF #( mt_out ).
9592

9693

97-
9894
LOOP AT kopf->* ASSIGNING <fs_s_head>.
9995

10096
DATA(lo_new_data) = NEW z2ui5_cl_demo_app_193( ).

‎src/z2ui5_cl_demo_app_192.clas.locals_imp.abap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ CLASS lcl_merged_data DEFINITION.
66
PUBLIC SECTION.
77

88
TYPES: BEGIN OF ty_s_key_value,
9-
fname TYPE char30,
9+
fname TYPE string,
1010
value TYPE string,
11-
tabname TYPE char30,
11+
tabname TYPE string,
1212
comp TYPE abap_componentdescr,
1313
END OF ty_s_key_value,
1414
ty_t_key_values TYPE STANDARD TABLE OF ty_s_key_value WITH EMPTY KEY.

‎src/z2ui5_cl_demo_app_319.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ CLASS z2ui5_cl_demo_app_319 DEFINITION PUBLIC.
1111
t_tokens TYPE STANDARD TABLE OF t_token WITH EMPTY KEY.
1212
TYPES:
1313
BEGIN OF t_range,
14-
exclude TYPE boole_d,
14+
exclude TYPE abap_bool,
1515
operation TYPE string,
1616
value1 TYPE string,
1717
value2 TYPE string,

‎src/z2ui5_cl_demo_app_320.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ CLASS z2ui5_cl_demo_app_320 DEFINITION
99

1010
TYPES: BEGIN OF ty_item,
1111
id TYPE string,
12-
initials TYPE char2,
12+
initials TYPE string,
1313
fallbackicon TYPE string,
1414
src TYPE string,
1515
name TYPE string,

0 commit comments

Comments
 (0)