Mixer Missing Key Functionality

[cwilliams376]

I was having a play around with mixer and noticed that Mix_PlayChannel and the Free functions for music and chunk were not implemented which kind of defeats the purpose of the mixer package if we cant playback and cleanup audio. Mix_PlayChannel is marked with a ? in coverage so was wondering what technical issues was holding up its implementation and if I wanted to have a look into implementing that where would be the best place to start poking around?

[Zyko0]

Hello!

I haven't made any test with mixer, and I'm not really knowledgeable with this library, that's why some stuff is not implemented yet.
So, the list of mixer functions (at the time of generation) is in this file: https://github.com/Zyko0/go-sdl3/blob/main/mixer/mixer_functions.gen.go
The syscall implementation (also generated) is done here: https://github.com/Zyko0/go-sdl3/blob/main/mixer/mixer_functions.gen_impl.go

And then the exposed API wrappers have been generated as a first pass in methods.go.
And some other functions, which shouldn't be defined as pointer receivers functions, are to be manually declared in the functions.go file.

For example:

• The free chunk function is here https://github.com/Zyko0/go-sdl3/blob/main/mixer/methods.go#L43-L46, and it's probably safe to just remove the panic line for it to work, but I haven't done it since I couldn't test everything yet.
• The PlayChannel function wrapper should be written in functions.go, it will call this function: https://github.com/Zyko0/go-sdl3/blob/main/mixer/mixer_functions.gen.go#L247

Thank you for showing interest!

I hope the current organization isn't too messy haha, I'd appreciate your contributions!

[Zyko0]

The reason there's a ? in COVERAGE.md rather than a x is because it hasn't been generated as a pointer receiver function (in methods.go) as the first pass.
So because it has to be written manually, it just hasn't been covered yet 👀

^ This is valid for all sub-packages

[cwilliams376]

Thanks for the info that helped me work out what I needed to do. I have a branch ready with the changes but don't appear to have permissions to push code to the repo.

[Zyko0]

Hello, the way to do it is to create a fork of this repository, then create a branch (optionally), push your changes and create a pull request from your fork's branch to this repository's upstream
This article should be more accurate: https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project