Added decimal place moving for negative numbers.

Author: ZCG-coder

.gitignore

@@ -83,7 +83,6 @@ dist/
 downloads/
 eggs/
 .eggs/
-lib/
 lib64/
 parts/
 sdist/

lib/CMakeLists.txt

@@ -27,9 +27,12 @@ if (NOT DEFINED Python_EXECUTABLE)
     Python
     COMPONENTS Development Interpreter
     REQUIRED)
-else ()
-    set(Python_EXECUTABLE ${PYTHON_EXECUTABLE})
+    find_package(
+    Python3
+    COMPONENTS Development Interpreter
+    REQUIRED)
 endif ()
+set(Python_EXECUTABLE ${Python3_EXECUTABLE})
 
 # Detect the installed nanobind package and import it into CMake
 execute_process(

src/multiply/multiply.cpp

@@ -52,8 +52,18 @@ namespace steppable::__internals::arithmetic
         auto b = static_cast<std::string>(_b);
         const auto& [splitNumberArray, aIsNegative, bIsNegative] = splitNumber(a, b, false, false);
         bool resultIsNegative = false;
+
+        // Determine the polarity of the result.
+        if (aIsNegative and bIsNegative)
+            resultIsNegative = false; // NOLINT(bugprone-branch-clone)
+        else if (aIsNegative or bIsNegative)
+            resultIsNegative = true;
+        else
+            resultIsNegative = false;
+
         const auto& [aInteger, aDecimal, bInteger, bDecimal] = splitNumberArray;
         std::stringstream out;
+        // Multiply by zero gives zero.
         if (isZeroString(a) or isZeroString(b))
         {
             if (steps == 2)
@@ -82,14 +92,20 @@ namespace steppable::__internals::arithmetic
         {
             if (steps == 2)
                 out << "Since " << a << " is a power of 10, we can move the decimal places to obtain the result.\n";
-            out << moveDecimalPlaces(b, determineScale(a));
+            auto result = moveDecimalPlaces(b, determineScale(a));
+            if (resultIsNegative)
+                result = "-" + result; // NOLINT(performance-inefficient-string-concatenation)
+
+            out << result;
             return out.str();
         }
         if (isPowerOfTen(b))
         {
             if (steps == 2)
                 out << "Since " << b << " is a power of 10, we can move the decimal places to obtain the result.\n";
-            out << moveDecimalPlaces(a, determineScale(b));
+            auto result = moveDecimalPlaces(a, determineScale(b));
+
+            out << result;
             return out.str();
         }
 
@@ -98,13 +114,6 @@ namespace steppable::__internals::arithmetic
         std::vector<std::vector<int>> prodDigits;
         std::vector<std::vector<int>> carries;
 
-        if (aIsNegative and bIsNegative)
-            resultIsNegative = false; // NOLINT(bugprone-branch-clone)
-        else if (aIsNegative or bIsNegative)
-            resultIsNegative = true;
-        else
-            resultIsNegative = false;
-
         for (size_t indexB = 0; indexB < bStr.length(); indexB++)
         {
             const int bDigit = static_cast<int>(bStr[indexB]) - '0';

src/rounding.cpp

@@ -128,7 +128,6 @@ namespace steppable::__internals::numUtils
         auto splitNumberArray = splitNumberResult.splitNumberArray;
         auto integer = splitNumberArray[0];
         auto decimal = splitNumberArray[1];
-        bool isNegative = splitNumberResult.aIsNegative;
         auto repetitions = std::abs(places);
 
         // Move decimal places to the right
@@ -157,8 +156,6 @@ namespace steppable::__internals::numUtils
         }
 
         auto result = integer + "." + decimal;
-        if (isNegative)
-            result = '-' + result;
         return standardizeNumber(removeLeadingZeros(result));
     }
 } // namespace steppable::__internals::numUtils

src/util.cpp

@@ -23,7 +23,6 @@
 #include "util.hpp"
 
 #include <cstddef>
-#include <map>
 
 #ifdef WINDOWS
     #undef min
@@ -200,7 +199,17 @@ namespace steppable::__internals::numUtils
         if (string == "0")
             return "0";
         auto out = string;
-        out.erase(0, std::min(out.find_first_not_of('0'), out.size() - 1));
+        bool negative = false;
+        if (out.front() == '-')
+        {
+            negative = true;
+            out.erase(0, 1);
+        }
+        while (out.front() == '0')
+            out.erase(0, 1);
+
+        if (negative)
+            out.insert(0, 1, '-');
         return out;
     }