inconsistency between WEBLATE_REGISTRATION_ALLOW_BACKENDS and REGISTRATION_ALLOW_BACKENDS

[mart-e]

Describe the issue

Hello,

We have deployed weblate using docker and noticed some difference if the authentication is enabled through the environment file or via settings-override.py

docker/docker-compose.yml

services:
  cache:
    image: redis:8-alpine
    volumes:
      - /home/weblate/data/redis-data:/data
    command: [redis-server, --save, '60', '1']
    networks:
      - weblate_net

  weblate:
    image: weblate/weblate:5.12
    env_file:
      - ./environment
    volumes:
      - /home/weblate/data/weblate-data:/app/data
      - /home/weblate/data/weblate-cache:/app/cache
    extra_hosts:
      - "host.docker.internal:host-gateway"
    ports:
      - 8080:8080
    depends_on:
      - cache
    tmpfs:
      - /run
      - /tmp
    networks:
      - weblate_net

docker/environment

WEBLATE_REGISTRATION_OPEN=1
WEBLATE_REGISTRATION_ALLOW_BACKENDS=['email', 'google-oauth2']
WEBLATE_SOCIAL_AUTH_GOOGLE_OAUTH2_KEY=…
WEBLATE_SOCIAL_AUTH_GOOGLE_OAUTH2_SECRET=…

I already tried

• I've read and searched the documentation.
• I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

• When going to /accounts/login/ page, I see a sign-in form and a “Sign in with Google” button.
• When going to /accounts/register/ page, I see “Sorry, new registrations are turned off on this site.”

When changing the configuration to add in /home/weblate/data/weblate-data/settings-override.py

REGISTRATION_ALLOW_BACKENDS=['email', 'google-oauth2']

• When going to /accounts/register/ page, I see a register form and a “Create an account using Google” button.

Expected behavior

Using the docker WEBLATE_REGISTRATION_ALLOW_BACKENDS variable has the same behaviour as using settings-override.py

How do you run Weblate?

Docker container

Weblate versions

5.12.2

Weblate deploy checks

System check identified some issues:

INFOS:
?: (weblate.I021) Error collection is not set up, it is highly recommended for production use
        HINT: https://docs.weblate.org/en/weblate-5.12.2/admin/install.html#collecting-errors
?: (weblate.I028) Backups are not configured, it is highly recommended for production use
        HINT: https://docs.weblate.org/en/weblate-5.12.2/admin/backup.html

System check identified 2 issues (5 silenced).

[nijel]

The correct syntax is:

WEBLATE_REGISTRATION_ALLOW_BACKENDS=email,google-oauth2

What you've specified will be parsed as:

REGISTRATION_ALLOW_BACKENDS = ["['email'", "'google-oauth2']"]

[nijel]

#15771 adds validation of this arg.

[mart-e]

Oh I see thanks!
But then I get another error which I think is due to the fact that I am using docker-compose 1.29 (from ubuntu packages)…

Details

$ docker-compose up
docker_cache_1 is up-to-date
Recreating fc1e8570dc67_docker_weblate_1 ...

ERROR: for fc1e8570dc67_docker_weblate_1  'ContainerConfig'

ERROR: for weblate  'ContainerConfig'
Traceback (most recent call last):
  File "/usr/bin/docker-compose", line 33, in <module>
    sys.exit(load_entry_point('docker-compose==1.29.2', 'console_scripts', 'docker-compose')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/cli/main.py", line 81, in main
    command_func()
  File "/usr/lib/python3/dist-packages/compose/cli/main.py", line 203, in perform_command
    handler(command, command_options)
  File "/usr/lib/python3/dist-packages/compose/metrics/decorator.py", line 18, in wrapper
    result = fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/cli/main.py", line 1186, in up
    to_attach = up(False)
                ^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/cli/main.py", line 1166, in up
    return self.project.up(
           ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/project.py", line 697, in up
    results, errors = parallel.parallel_execute(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/parallel.py", line 108, in parallel_execute
    raise error_to_reraise
  File "/usr/lib/python3/dist-packages/compose/parallel.py", line 206, in producer
    result = func(obj)
             ^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/project.py", line 679, in do
    return service.execute_convergence_plan(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 579, in execute_convergence_plan
    return self._execute_convergence_recreate(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 499, in _execute_convergence_recreate
    containers, errors = parallel_execute(
                         ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/parallel.py", line 108, in parallel_execute
    raise error_to_reraise
  File "/usr/lib/python3/dist-packages/compose/parallel.py", line 206, in producer
    result = func(obj)
             ^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 494, in recreate
    return self.recreate_container(
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 612, in recreate_container
    new_container = self.create_container(
                    ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 330, in create_container
    container_options = self._get_container_create_options(
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 921, in _get_container_create_options
    container_options, override_options = self._build_container_volume_options(
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 960, in _build_container_volume_options
    binds, affinity = merge_volume_bindings(
                      ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 1548, in merge_volume_bindings
    old_volumes, old_mounts = get_container_data_volumes(
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/compose/service.py", line 1579, in get_container_data_volumes
    container.image_config['ContainerConfig'].get('Volumes') or {}
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'ContainerConfig'

[mart-e]

Ok with the docker-compose-v2 package installed, it works, thanks a lot!

[nijel]

It would probably work with the quotes in the old version:

WEBLATE_REGISTRATION_ALLOW_BACKENDS="email,google-oauth2"

[mart-e]

No, I tested both with and without and I got the same error in both cases. Not really sure why (maybe package issue) but it was solved with docker-compose v2 🤷