MIMETypeRegistry::getExtensionsForMIMEType() needs to handle wildcard MIME types

https://bugs.webkit.org/show_bug.cgi?id=213826

Patch by Said Abou-Hallawa <[email protected]> on 2020-07-02
Reviewed by Darin Adler.

Addressing post commit review comments for r263832.

* platform/cocoa/MIMETypeRegistryCocoa.mm:
(WebCore::extensionsForMIMETypeMap):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@263880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebCore/ChangeLog

@@ -1,3 +1,15 @@
+2020-07-02  Said Abou-Hallawa  <[email protected]>
+
+        MIMETypeRegistry::getExtensionsForMIMEType() needs to handle wildcard MIME types
+        https://bugs.webkit.org/show_bug.cgi?id=213826
+
+        Reviewed by Darin Adler.
+
+        Addressing post commit review comments for r263832.
+
+        * platform/cocoa/MIMETypeRegistryCocoa.mm:
+        (WebCore::extensionsForMIMETypeMap):
+
 2020-07-02  Brady Eidson  <[email protected]>
 
         GameController.framework soft linking refactoring

Source/WebCore/platform/cocoa/MIMETypeRegistryCocoa.mm

@@ -46,22 +46,19 @@
             size_t pos = type.reverseFind('/');
 
             ASSERT(pos != notFound);
-            auto wildcardMIMEType = makeString(type.left(pos), "/*"_s);
+            auto wildcardMIMEType = makeString(StringView(type).left(pos), "/*"_s);
 
             for (NSString *extension in extensions) {
-                if (!extension)
-                    continue;
-
                 // Add extension to wildcardMIMEType, for example add "png" to "image/*"
                 addExtension(wildcardMIMEType, extension);
                 // Add extension to its mimeType, for example add "png" to "image/png"
                 addExtension(type, extension);
             }
         };
 
-        auto allUTIs = adoptNS((__bridge NSArray<NSString *> *)_UTCopyDeclaredTypeIdentifiers());
+        auto allUTIs = adoptCF(_UTCopyDeclaredTypeIdentifiers());
 
-        for (NSString *uti in allUTIs.get()) {
+        for (NSString *uti in (__bridge NSArray<NSString *> *)allUTIs.get()) {
             auto type = adoptCF(UTTypeCopyPreferredTagWithClass((__bridge CFStringRef)uti, kUTTagClassMIMEType));
             if (!type)
                 continue;