Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit eee7154

Browse files
Use a different SPI header for some AudioToolbox enums
https://bugs.webkit.org/show_bug.cgi?id=183574 <rdar://problem/38385889> Reviewed by Anders Carlsson. Source/WebCore: * platform/audio/ios/AudioDestinationIOS.cpp: * platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp: Adjust SPI imports. Source/WebCore/PAL: * PAL.xcodeproj/project.pbxproj: * pal/spi/cocoa/AudioToolboxSPI.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@229546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 58bace2 commit eee7154

File tree

6 files changed

+59
-0
lines changed

6 files changed

+59
-0
lines changed

Source/WebCore/ChangeLog

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2018-03-12 Tim Horton <[email protected]>
2+
3+
Use a different SPI header for some AudioToolbox enums
4+
https://bugs.webkit.org/show_bug.cgi?id=183574
5+
<rdar://problem/38385889>
6+
7+
Reviewed by Anders Carlsson.
8+
9+
* platform/audio/ios/AudioDestinationIOS.cpp:
10+
* platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:
11+
Adjust SPI imports.
12+
113
2018-03-12 Danyao Wang <[email protected]>
214

315
Add a query and fragment exception to history API's unique origin restriction.

Source/WebCore/PAL/ChangeLog

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
2018-03-12 Tim Horton <[email protected]>
2+
3+
Use a different SPI header for some AudioToolbox enums
4+
https://bugs.webkit.org/show_bug.cgi?id=183574
5+
<rdar://problem/38385889>
6+
7+
Reviewed by Anders Carlsson.
8+
9+
* PAL.xcodeproj/project.pbxproj:
10+
* pal/spi/cocoa/AudioToolboxSPI.h: Added.
11+
112
2018-03-07 Tim Horton <[email protected]>
213

314
Sort and separate FeatureDefines.xcconfig

Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@
106106
1C4876D81F8D7F4E00CCEEBD /* Logging.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C4876D61F8D7F4E00CCEEBD /* Logging.cpp */; };
107107
1C4876D91F8D7F4E00CCEEBD /* Logging.h in Headers */ = {isa = PBXBuildFile; fileRef = 1C4876D71F8D7F4E00CCEEBD /* Logging.h */; };
108108
1C4876E01F8D837500CCEEBD /* LoggingCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1C4876DF1F8D837500CCEEBD /* LoggingCocoa.mm */; };
109+
2D02E93C2056FAA700A13797 /* AudioToolboxSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D02E93B2056FAA700A13797 /* AudioToolboxSPI.h */; };
109110
7A1656441F97B2B900BA3CE4 /* NSKeyedArchiverSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 7A1656431F97B2B800BA3CE4 /* NSKeyedArchiverSPI.h */; };
110111
A10265871F56746100B4C844 /* FoundationSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = A10265861F56746100B4C844 /* FoundationSPI.h */; };
111112
A10265891F56747A00B4C844 /* HIToolboxSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = A10265881F56747A00B4C844 /* HIToolboxSPI.h */; };
@@ -250,6 +251,7 @@
250251
1C4876DF1F8D837500CCEEBD /* LoggingCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = LoggingCocoa.mm; sourceTree = "<group>"; };
251252
1C67CEA11E32EDA800F80F2E /* FeatureDefines.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = FeatureDefines.xcconfig; sourceTree = "<group>"; };
252253
1C67CEA21E32EE2600F80F2E /* Version.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = Version.xcconfig; sourceTree = "<group>"; };
254+
2D02E93B2056FAA700A13797 /* AudioToolboxSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AudioToolboxSPI.h; sourceTree = "<group>"; };
253255
7A1656431F97B2B800BA3CE4 /* NSKeyedArchiverSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NSKeyedArchiverSPI.h; sourceTree = "<group>"; };
254256
93E5909C1F93BF1E0067F8CF /* UnencodableHandling.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = UnencodableHandling.h; sourceTree = "<group>"; };
255257
A10265861F56746100B4C844 /* FoundationSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FoundationSPI.h; sourceTree = "<group>"; };
@@ -349,6 +351,7 @@
349351
0C2DA1201F3BE9E700DBC317 /* cocoa */ = {
350352
isa = PBXGroup;
351353
children = (
354+
2D02E93B2056FAA700A13797 /* AudioToolboxSPI.h */,
352355
0C2DA1221F3BEB4900DBC317 /* AVKitSPI.h */,
353356
0C2DA1231F3BEB4900DBC317 /* CFNSURLConnectionSPI.h */,
354357
0C2DA1241F3BEB4900DBC317 /* CoreTextSPI.h */,
@@ -601,6 +604,7 @@
601604
isa = PBXHeadersBuildPhase;
602605
buildActionMask = 2147483647;
603606
files = (
607+
2D02E93C2056FAA700A13797 /* AudioToolboxSPI.h in Headers */,
604608
0C7785891F45130F00F4EBB6 /* AVFoundationSPI.h in Headers */,
605609
0C2DA13E1F3BEB4900DBC317 /* AVKitSPI.h in Headers */,
606610
0C2DA06D1F33CA8400DBC317 /* CFLocaleSPI.h in Headers */,
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
/*
2+
* Copyright (C) 2018 Apple Inc. All rights reserved.
3+
*
4+
* Redistribution and use in source and binary forms, with or without
5+
* modification, are permitted provided that the following conditions
6+
* are met:
7+
* 1. Redistributions of source code must retain the above copyright
8+
* notice, this list of conditions and the following disclaimer.
9+
* 2. Redistributions in binary form must reproduce the above copyright
10+
* notice, this list of conditions and the following disclaimer in the
11+
* documentation and/or other materials provided with the distribution.
12+
*
13+
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14+
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15+
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16+
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17+
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18+
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19+
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20+
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21+
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22+
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23+
* THE POSSIBILITY OF SUCH DAMAGE.
24+
*/
25+
26+
#if USE(APPLE_INTERNAL_SDK)
27+
28+
#import <AudioToolbox/AudioComponentPriv.h>
29+
30+
#endif

Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
#include "Logging.h"
4040
#include "RuntimeApplicationChecks.h"
4141
#include <AudioToolbox/AudioServices.h>
42+
#include <pal/spi/cocoa/AudioToolboxSPI.h>
4243
#include <wtf/HashSet.h>
4344
#include <wtf/NeverDestroyed.h>
4445
#include <wtf/SoftLinking.h>

Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "Logging.h"
3434

3535
#include <pal/cf/CoreMediaSoftLink.h>
36+
#include <pal/spi/cocoa/AudioToolboxSPI.h>
3637

3738
#if ENABLE(VIDEO_TRACK) && ENABLE(MEDIA_STREAM)
3839

0 commit comments

Comments
 (0)