Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit dceaae6

Browse files
JSC should produce a module map.
https://bugs.webkit.org/show_bug.cgi?id=206717 Reviewed by Mark Lam. * Configurations/JavaScriptCore.xcconfig: * JavaScriptCore.modulemap: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@255086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 6de874e commit dceaae6

File tree

3 files changed

+12
-15
lines changed

3 files changed

+12
-15
lines changed

Source/JavaScriptCore/ChangeLog

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,13 @@
1+
2020-01-24 Keith Miller <[email protected]>
2+
3+
JSC should produce a module map.
4+
https://bugs.webkit.org/show_bug.cgi?id=206717
5+
6+
Reviewed by Mark Lam.
7+
8+
* Configurations/JavaScriptCore.xcconfig:
9+
* JavaScriptCore.modulemap:
10+
111
2020-01-24 Commit Queue <[email protected]>
212

313
Unreviewed, rolling out r255052.

Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@
2424
#include "FeatureDefines.xcconfig"
2525
#include "Version.xcconfig"
2626

27-
DEFINES_MODULE = $(DEFINES_MODULE_$(WK_PLATFORM_NAME))
28-
DEFINES_MODULE_maccatalyst = YES;
29-
DEFINES_MODULE_macosx = YES;
30-
DEFINES_MODULE_ = NO;
27+
DEFINES_MODULE = YES;
3128
MODULEMAP_FILE = $(SRCROOT)/JavaScriptCore.modulemap;
3229

3330
// Prevent C++ standard library operator new, delete and their related exception types from being exported as weak symbols.
Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,8 @@
1-
framework module JavaScriptCore {
1+
framework module JavaScriptCore [extern_c] {
22
umbrella header "JavaScriptCore.h"
33

44
export *
55
module * {
66
export *
77
}
8-
9-
explicit module JSVirtualMachine {
10-
// FIXME: 32-bit x86 is a poor way to say "fragile Objective-C ABI"
11-
requires x86_32
12-
exclude header "JSValue.h"
13-
exclude header "JSContext.h"
14-
exclude header "JSExport.h"
15-
exclude header "JSManagedValue.h"
16-
exclude header "JSVirtualMachine.h"
17-
}
188
}

0 commit comments

Comments
 (0)