Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit d1ba651

Browse files
[WinCairo][CURL] NetworkProcess consumes CPU resource greedily
https://bugs.webkit.org/show_bug.cgi?id=214383 Reviewed by Fujii Hironori. Add PolicyAction::Ignore handling routine in NetworkDataTaskCurl::invokeDidReceiveResponse() If we don't cancel the ignored requests the worker thread for curl scheduler goes busy-looping because the fds of the requests continue to be monitored. No tests needed as existing tests cover this change. * NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@264485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 64b86ab commit d1ba651

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

Source/WebKit/ChangeLog

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2020-07-16 Takashi Komori <[email protected]>
2+
3+
[WinCairo][CURL] NetworkProcess consumes CPU resource greedily
4+
https://bugs.webkit.org/show_bug.cgi?id=214383
5+
6+
Reviewed by Fujii Hironori.
7+
8+
Add PolicyAction::Ignore handling routine in NetworkDataTaskCurl::invokeDidReceiveResponse()
9+
If we don't cancel the ignored requests the worker thread for curl scheduler goes busy-looping because the fds of the requests continue to be monitored.
10+
11+
No tests needed as existing tests cover this change.
12+
13+
* NetworkProcess/curl/NetworkDataTaskCurl.cpp:
14+
(WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse):
15+
116
2020-07-16 Tim Horton <[email protected]>
217

318
iPad cursor is sometimes slow to change to I-beam (e.g. on reddit.com)

Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ void NetworkDataTaskCurl::invokeDidReceiveResponse()
236236
m_curlRequest->completeDidReceiveResponse();
237237
break;
238238
case PolicyAction::Ignore:
239+
invalidateAndCancel();
239240
break;
240241
default:
241242
notImplemented();

0 commit comments

Comments
 (0)