Inclusive software: Remove instances of "dumb" from the code

https://bugs.webkit.org/show_bug.cgi?id=217778

Reviewed by Simon Fraser.

Source/JavaScriptCore:

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::unboxBoolean):
* heap/SlotVisitor.h:
* jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitVirtualCall):
(JSC::AssemblyHelpers::emitDumbVirtualCall): Deleted.
* jit/AssemblyHelpers.h:
* jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
* runtime/CachedTypes.cpp:
* runtime/JSCJSValue.h:
* runtime/WriteBarrier.h:
* runtime/WriteBarrierInlines.h:
(JSC::RawValueTraits<Unknown>>::set):
(JSC::DumbValueTraits<Unknown>>::set): Deleted.
* wasm/WasmAirIRGenerator.cpp:
(JSC::Wasm::AirIRGenerator::addCallIndirect):
* wasm/generateWasm.py:
(opcodeIterator):

Source/WebCore:

* Modules/webaudio/AudioNode.h:
* dom/GCReachableRef.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* icu/unicode/caniter.h:
* wtf/Bag.h:
* wtf/CMakeLists.txt:
* wtf/CagedPtr.h:
* wtf/Forward.h:
* wtf/NakedRef.h:
* wtf/RawPtrTraits.h: Renamed from Source/WTF/wtf/DumbPtrTraits.h.
* wtf/RawValueTraits.h: Renamed from Source/WTF/wtf/DumbValueTraits.h.
* wtf/Ref.h:
* wtf/RefCountedArray.h:
* wtf/RefPtr.h:
* wtf/SentinelLinkedList.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/JavaScriptCore/ChangeLog

@@ -1,3 +1,37 @@
+2020-10-26  Alex Christensen  <[email protected]>
+
+        Inclusive software: Remove instances of "dumb" from the code
+        https://bugs.webkit.org/show_bug.cgi?id=217778
+
+        Reviewed by Simon Fraser.
+
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        (JSC::DFG::SpeculativeJIT::emitCall):
+        * dfg/DFGSpeculativeJIT64.cpp:
+        (JSC::DFG::SpeculativeJIT::emitCall):
+        * ftl/FTLLowerDFGToB3.cpp:
+        (JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
+        (JSC::FTL::DFG::LowerDFGToB3::unboxBoolean):
+        * heap/SlotVisitor.h:
+        * jit/AssemblyHelpers.cpp:
+        (JSC::AssemblyHelpers::emitVirtualCall):
+        (JSC::AssemblyHelpers::emitDumbVirtualCall): Deleted.
+        * jit/AssemblyHelpers.h:
+        * jit/JITCall.cpp:
+        (JSC::JIT::compileCallEvalSlowCase):
+        * jit/JITCall32_64.cpp:
+        (JSC::JIT::compileCallEvalSlowCase):
+        * runtime/CachedTypes.cpp:
+        * runtime/JSCJSValue.h:
+        * runtime/WriteBarrier.h:
+        * runtime/WriteBarrierInlines.h:
+        (JSC::RawValueTraits<Unknown>>::set):
+        (JSC::DumbValueTraits<Unknown>>::set): Deleted.
+        * wasm/WasmAirIRGenerator.cpp:
+        (JSC::Wasm::AirIRGenerator::addCallIndirect):
+        * wasm/generateWasm.py:
+        (opcodeIterator):
+
 2020-10-26  Sam Weinig  <[email protected]>
 
         JSC special function forward declarations (e.g. JSC_DECLARE_HOST_FUNCTION) that are internal to a cpp file should be declared with static to avoid external linkage

Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

@@ -824,7 +824,7 @@ void SpeculativeJIT::emitCall(Node* node)
         m_jit.addPtr(TrustedImm32(requiredBytes), JITCompiler::stackPointerRegister);
         m_jit.load32(JITCompiler::calleeFrameSlot(CallFrameSlot::callee).withOffset(PayloadOffset), GPRInfo::regT0);
         m_jit.load32(JITCompiler::calleeFrameSlot(CallFrameSlot::callee).withOffset(TagOffset), GPRInfo::regT1);
-        m_jit.emitDumbVirtualCall(vm(), globalObject, info);
+        m_jit.emitVirtualCall(vm(), globalObject, info);
 
         done.link(&m_jit);
         setResultAndResetStack();

Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp

@@ -816,7 +816,7 @@ void SpeculativeJIT::emitCall(Node* node)
         // This is the part where we meant to make a normal call. Oops.
         m_jit.addPtr(TrustedImm32(requiredBytes), JITCompiler::stackPointerRegister);
         m_jit.load64(JITCompiler::calleeFrameSlot(CallFrameSlot::callee), GPRInfo::regT0);
-        m_jit.emitDumbVirtualCall(vm(), globalObject, callLinkInfo);
+        m_jit.emitVirtualCall(vm(), globalObject, callLinkInfo);
 
         done.link(&m_jit);
         setResultAndResetStack();

Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

@@ -10610,7 +10610,7 @@ class LowerDFGToB3 {
 
                 jit.addPtr(CCallHelpers::TrustedImm32(requiredBytes), CCallHelpers::stackPointerRegister);
                 jit.load64(CCallHelpers::calleeFrameSlot(CallFrameSlot::callee), GPRInfo::regT0);
-                jit.emitDumbVirtualCall(vm, globalObject, callLinkInfo);
+                jit.emitVirtualCall(vm, globalObject, callLinkInfo);
 
                 done.link(&jit);
                 jit.addPtr(
@@ -17948,7 +17948,7 @@ class LowerDFGToB3 {
     LValue unboxBoolean(LValue jsValue)
     {
         // We want to use a cast that guarantees that B3 knows that even the integer
-        // value is just 0 or 1. But for now we do it the dumb way.
+        // value is just 0 or 1. But for now we do it the direct way.
         return m_out.notZero64(m_out.bitAnd(jsValue, m_out.constInt64(1)));
     }
     LValue boxBoolean(LValue value)

Source/JavaScriptCore/heap/SlotVisitor.h

@@ -91,8 +91,8 @@ class SlotVisitor {
     template<typename T, typename Traits> void append(const WriteBarrierBase<T, Traits>&);
     template<typename T, typename Traits> void appendHidden(const WriteBarrierBase<T, Traits>&);
     template<typename Iterator> void append(Iterator begin , Iterator end);
-    void appendValues(const WriteBarrierBase<Unknown, DumbValueTraits<Unknown>>*, size_t count);
-    void appendValuesHidden(const WriteBarrierBase<Unknown, DumbValueTraits<Unknown>>*, size_t count);
+    void appendValues(const WriteBarrierBase<Unknown, RawValueTraits<Unknown>>*, size_t count);
+    void appendValuesHidden(const WriteBarrierBase<Unknown, RawValueTraits<Unknown>>*, size_t count);
 
     // These don't require you to prove that you have a WriteBarrier<>. That makes sense
     // for:

Source/JavaScriptCore/jit/AssemblyHelpers.cpp

@@ -642,7 +642,7 @@ void AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer(EntryFra
 #endif
 }
 
-void AssemblyHelpers::emitDumbVirtualCall(VM& vm, JSGlobalObject* globalObject, CallLinkInfo* info)
+void AssemblyHelpers::emitVirtualCall(VM& vm, JSGlobalObject* globalObject, CallLinkInfo* info)
 {
     move(TrustedImmPtr(info), GPRInfo::regT2);
     move(TrustedImmPtr(globalObject), GPRInfo::regT3);

Source/JavaScriptCore/jit/AssemblyHelpers.h

@@ -1938,7 +1938,7 @@ class AssemblyHelpers : public MacroAssembler {
         functor(TypeofType::Undefined, true);
     }
 
-    void emitDumbVirtualCall(VM&, JSGlobalObject*, CallLinkInfo*);
+    void emitVirtualCall(VM&, JSGlobalObject*, CallLinkInfo*);
 
     void makeSpaceOnStackForCCall();
     void reclaimSpaceOnStackForCCall();

Source/JavaScriptCore/jit/JITCall.cpp

@@ -158,7 +158,7 @@ void JIT::compileCallEvalSlowCase(const Instruction* instruction, Vector<SlowCas
     addPtr(TrustedImm32(registerOffset * sizeof(Register) + sizeof(CallerFrameAndPC)), callFrameRegister, stackPointerRegister);
 
     load64(Address(stackPointerRegister, sizeof(Register) * CallFrameSlot::callee - sizeof(CallerFrameAndPC)), regT0);
-    emitDumbVirtualCall(vm(), m_codeBlock->globalObject(), info);
+    emitVirtualCall(vm(), m_codeBlock->globalObject(), info);
     addPtr(TrustedImm32(stackPointerOffsetFor(m_codeBlock) * sizeof(Register)), callFrameRegister, stackPointerRegister);
     checkStackPointerAlignment();
 

Source/JavaScriptCore/jit/JITCall32_64.cpp

@@ -260,7 +260,7 @@ void JIT::compileCallEvalSlowCase(const Instruction* instruction, Vector<SlowCas
     addPtr(TrustedImm32(registerOffset * sizeof(Register) + sizeof(CallerFrameAndPC)), callFrameRegister, stackPointerRegister);
 
     emitLoad(callee, regT1, regT0);
-    emitDumbVirtualCall(vm(), m_codeBlock->globalObject(), info);
+    emitVirtualCall(vm(), m_codeBlock->globalObject(), info);
     addPtr(TrustedImm32(stackPointerOffsetFor(m_codeBlock) * sizeof(Register)), callFrameRegister, stackPointerRegister);
     checkStackPointerAlignment();
 

Source/JavaScriptCore/runtime/CachedTypes.cpp

@@ -533,7 +533,7 @@ ptrdiff_t CachedPtrOffsets::offsetOffset()
     return OBJECT_OFFSETOF(CachedPtr<void>, m_offset);
 }
 
-template<typename T, typename Source = SourceType<T>, typename PtrTraits = DumbPtrTraits<Source>>
+template<typename T, typename Source = SourceType<T>, typename PtrTraits = RawPtrTraits<Source>>
 class CachedRefPtr : public CachedObject<RefPtr<Source, PtrTraits>> {
 public:
     void encode(Encoder& encoder, const Source* src)