Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit b0c7c41

Browse files
author
[email protected]
committed
Move some initialization code from top-level CMakeLists.txt to WebKitCommon.cmake
https://bugs.webkit.org/show_bug.cgi?id=218069 <rdar://problem/70556952> Reviewed by Fujii Hironori. Moving this initialization code into a central location allows other top-level CMakeLists.txt files to include WebKitCommon.cmake and get that same initialization. * CMakeLists.txt: * Source/cmake/WebKitCommon.cmake: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 2b5979b commit b0c7c41

File tree

3 files changed

+169
-158
lines changed

3 files changed

+169
-158
lines changed

‎CMakeLists.txt

Lines changed: 1 addition & 158 deletions
Original file line numberDiff line numberDiff line change
@@ -1,175 +1,18 @@
11
# -----------------------------------------------------------------------------
22
# Determine CMake version and build type.
33
# -----------------------------------------------------------------------------
4-
#
54
# NOTE: cmake_minimum_required() and project() *MUST* be the two first commands
65
# used, see https://cmake.org/cmake/help/v3.3/command/project.html -- the
76
# latter in particular handles loading a bunch of shared CMake definitions
87
# and loading the cross-compilation settings from CMAKE_TOOLCHAIN_FILE.
98
#
10-
119
cmake_minimum_required(VERSION 3.10)
12-
1310
project(WebKit)
1411

15-
if (NOT CMAKE_BUILD_TYPE)
16-
message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.")
17-
set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE)
18-
else ()
19-
message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
20-
endif ()
21-
22-
set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")
23-
24-
set(ENABLE_WEBCORE ON)
25-
26-
if (NOT DEFINED ENABLE_WEBKIT)
27-
set(ENABLE_WEBKIT ON)
28-
endif ()
29-
30-
if (NOT DEFINED ENABLE_TOOLS AND EXISTS "${CMAKE_SOURCE_DIR}/Tools")
31-
set(ENABLE_TOOLS ON)
32-
endif ()
33-
34-
if (NOT DEFINED ENABLE_WEBINSPECTORUI)
35-
set(ENABLE_WEBINSPECTORUI ON)
36-
endif ()
37-
38-
# -----------------------------------------------------------------------------
39-
# Determine which port will be built
40-
# -----------------------------------------------------------------------------
41-
set(ALL_PORTS
42-
AppleWin
43-
Efl
44-
FTW
45-
GTK
46-
JSCOnly
47-
Mac
48-
PlayStation
49-
WPE
50-
WinCairo
51-
)
52-
set(PORT "NOPORT" CACHE STRING "choose which WebKit port to build (one of ${ALL_PORTS})")
53-
54-
list(FIND ALL_PORTS ${PORT} RET)
55-
if (${RET} EQUAL -1)
56-
message(FATAL_ERROR "Please choose which WebKit port to build (one of ${ALL_PORTS})")
57-
endif ()
58-
59-
string(TOLOWER ${PORT} WEBKIT_PORT_DIR)
60-
61-
# -----------------------------------------------------------------------------
62-
# Determine the compiler
63-
# -----------------------------------------------------------------------------
64-
if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "AppleClang")
65-
set(COMPILER_IS_CLANG ON)
66-
endif ()
67-
68-
if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
69-
if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "7.3.0")
70-
message(FATAL_ERROR "GCC 7.3 or newer is required to build WebKit. Use a newer GCC version or Clang.")
71-
endif ()
72-
endif ()
73-
74-
if (CMAKE_COMPILER_IS_GNUCXX OR COMPILER_IS_CLANG)
75-
set(COMPILER_IS_GCC_OR_CLANG ON)
76-
endif ()
77-
78-
if (MSVC AND COMPILER_IS_CLANG)
79-
set(COMPILER_IS_CLANG_CL ON)
80-
endif ()
81-
82-
# -----------------------------------------------------------------------------
83-
# Determine the target processor
84-
# -----------------------------------------------------------------------------
85-
# Use MSVC_CXX_ARCHITECTURE_ID instead of CMAKE_SYSTEM_PROCESSOR when defined,
86-
# since the later one just resolves to the host processor on Windows.
87-
if (MSVC_CXX_ARCHITECTURE_ID)
88-
string(TOLOWER ${MSVC_CXX_ARCHITECTURE_ID} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
89-
else ()
90-
string(TOLOWER ${CMAKE_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
91-
endif ()
92-
if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^aarch64|^arm64)")
93-
set(WTF_CPU_ARM64 1)
94-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
95-
set(WTF_CPU_ARM 1)
96-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^mips64")
97-
set(WTF_CPU_MIPS64 1)
98-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
99-
set(WTF_CPU_MIPS 1)
100-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(x64|x86_64|amd64)")
101-
# FORCE_32BIT is set in the build script when --32-bit is passed
102-
# on a Linux/intel 64bit host. This allows us to produce 32bit
103-
# binaries without setting the build up as a crosscompilation,
104-
# which is the only way to modify CMAKE_SYSTEM_PROCESSOR.
105-
if (FORCE_32BIT)
106-
set(WTF_CPU_X86 1)
107-
else ()
108-
set(WTF_CPU_X86_64 1)
109-
endif ()
110-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(i[3-6]86|x86)")
111-
set(WTF_CPU_X86 1)
112-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "ppc")
113-
set(WTF_CPU_PPC 1)
114-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64")
115-
set(WTF_CPU_PPC64 1)
116-
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64le")
117-
set(WTF_CPU_PPC64LE 1)
118-
else ()
119-
set(WTF_CPU_UNKNOWN 1)
120-
endif ()
121-
122-
# -----------------------------------------------------------------------------
123-
# Determine the operating system
124-
# -----------------------------------------------------------------------------
125-
if (UNIX)
126-
if (APPLE)
127-
set(WTF_OS_MAC_OS_X 1)
128-
elseif (CMAKE_SYSTEM_NAME MATCHES "Linux")
129-
set(WTF_OS_LINUX 1)
130-
else ()
131-
set(WTF_OS_UNIX 1)
132-
endif ()
133-
elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
134-
set(WTF_OS_WINDOWS 1)
135-
elseif (CMAKE_SYSTEM_NAME MATCHES "Fuchsia")
136-
set(WTF_OS_FUCHSIA 1)
137-
else ()
138-
message(FATAL_ERROR "Unknown OS '${CMAKE_SYSTEM_NAME}'")
139-
endif ()
140-
141-
# -----------------------------------------------------------------------------
142-
# Default library types
143-
# -----------------------------------------------------------------------------
144-
# By default, only the highest-level libraries, WebKitLegacy and WebKit, are
145-
# shared, because properly building shared libraries that depend on each other
146-
# can be tricky. Override these in Options*.cmake for your port as needed.
147-
set(bmalloc_LIBRARY_TYPE STATIC)
148-
set(WTF_LIBRARY_TYPE STATIC)
149-
set(JavaScriptCore_LIBRARY_TYPE STATIC)
150-
set(PAL_LIBRARY_TYPE STATIC)
151-
set(WebCore_LIBRARY_TYPE STATIC)
152-
set(WebKitLegacy_LIBRARY_TYPE SHARED)
153-
set(WebKit_LIBRARY_TYPE SHARED)
154-
set(WebCoreTestSupport_LIBRARY_TYPE STATIC)
155-
156-
set(CMAKE_POSITION_INDEPENDENT_CODE True)
157-
158-
# -----------------------------------------------------------------------------
159-
# Install JavaScript shell
160-
# -----------------------------------------------------------------------------
161-
option(SHOULD_INSTALL_JS_SHELL "generate an installation rule to install the built JavaScript shell")
162-
163-
# -----------------------------------------------------------------------------
164-
# Default output directories, which can be overwritten by ports
165-
#------------------------------------------------------------------------------
166-
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
167-
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
168-
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
169-
17012
# -----------------------------------------------------------------------------
17113
# Common configuration
17214
#------------------------------------------------------------------------------
15+
set(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/Source/cmake")
17316
include(WebKitCommon)
17417

17518
# -----------------------------------------------------------------------------

‎ChangeLog

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
2020-10-26 Keith Rollin <[email protected]>
2+
3+
Move some initialization code from top-level CMakeLists.txt to WebKitCommon.cmake
4+
https://bugs.webkit.org/show_bug.cgi?id=218069
5+
<rdar://problem/70556952>
6+
7+
Reviewed by Fujii Hironori.
8+
9+
Moving this initialization code into a central location allows other
10+
top-level CMakeLists.txt files to include WebKitCommon.cmake and get
11+
that same initialization.
12+
13+
* CMakeLists.txt:
14+
* Source/cmake/WebKitCommon.cmake:
15+
116
2020-10-23 Philippe Normand <[email protected]>
217

318
[GStreamer] Replace USE(WEBAUDIO_GSTREAMER) with USE(GSTREAMER)

‎Source/cmake/WebKitCommon.cmake

Lines changed: 153 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,159 @@
66
if (NOT HAS_RUN_WEBKIT_COMMON)
77
set(HAS_RUN_WEBKIT_COMMON TRUE)
88

9+
if (NOT CMAKE_BUILD_TYPE)
10+
message(WARNING "No CMAKE_BUILD_TYPE value specified, defaulting to RelWithDebInfo.")
11+
set(CMAKE_BUILD_TYPE "RelWithDebInfo" CACHE STRING "Choose the type of build." FORCE)
12+
else ()
13+
message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
14+
endif ()
15+
16+
set(ENABLE_WEBCORE ON)
17+
18+
if (NOT DEFINED ENABLE_WEBKIT)
19+
set(ENABLE_WEBKIT ON)
20+
endif ()
21+
22+
if (NOT DEFINED ENABLE_TOOLS AND EXISTS "${CMAKE_SOURCE_DIR}/Tools")
23+
set(ENABLE_TOOLS ON)
24+
endif ()
25+
26+
if (NOT DEFINED ENABLE_WEBINSPECTORUI)
27+
set(ENABLE_WEBINSPECTORUI ON)
28+
endif ()
29+
30+
# -----------------------------------------------------------------------------
31+
# Determine which port will be built
32+
# -----------------------------------------------------------------------------
33+
set(ALL_PORTS
34+
AppleWin
35+
Efl
36+
FTW
37+
GTK
38+
JSCOnly
39+
Mac
40+
PlayStation
41+
WPE
42+
WinCairo
43+
)
44+
set(PORT "NOPORT" CACHE STRING "choose which WebKit port to build (one of ${ALL_PORTS})")
45+
46+
list(FIND ALL_PORTS ${PORT} RET)
47+
if (${RET} EQUAL -1)
48+
message(FATAL_ERROR "Please choose which WebKit port to build (one of ${ALL_PORTS})")
49+
endif ()
50+
51+
string(TOLOWER ${PORT} WEBKIT_PORT_DIR)
52+
53+
# -----------------------------------------------------------------------------
54+
# Determine the compiler
55+
# -----------------------------------------------------------------------------
56+
if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang" OR ${CMAKE_CXX_COMPILER_ID} STREQUAL "AppleClang")
57+
set(COMPILER_IS_CLANG ON)
58+
endif ()
59+
60+
if (${CMAKE_CXX_COMPILER_ID} STREQUAL "GNU")
61+
if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "7.3.0")
62+
message(FATAL_ERROR "GCC 7.3 or newer is required to build WebKit. Use a newer GCC version or Clang.")
63+
endif ()
64+
endif ()
65+
66+
if (CMAKE_COMPILER_IS_GNUCXX OR COMPILER_IS_CLANG)
67+
set(COMPILER_IS_GCC_OR_CLANG ON)
68+
endif ()
69+
70+
if (MSVC AND COMPILER_IS_CLANG)
71+
set(COMPILER_IS_CLANG_CL ON)
72+
endif ()
73+
74+
# -----------------------------------------------------------------------------
75+
# Determine the target processor
76+
# -----------------------------------------------------------------------------
77+
# Use MSVC_CXX_ARCHITECTURE_ID instead of CMAKE_SYSTEM_PROCESSOR when defined,
78+
# since the later one just resolves to the host processor on Windows.
79+
if (MSVC_CXX_ARCHITECTURE_ID)
80+
string(TOLOWER ${MSVC_CXX_ARCHITECTURE_ID} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
81+
else ()
82+
string(TOLOWER ${CMAKE_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_SYSTEM_PROCESSOR)
83+
endif ()
84+
if (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(^aarch64|^arm64)")
85+
set(WTF_CPU_ARM64 1)
86+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^arm")
87+
set(WTF_CPU_ARM 1)
88+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^mips64")
89+
set(WTF_CPU_MIPS64 1)
90+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "^mips")
91+
set(WTF_CPU_MIPS 1)
92+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(x64|x86_64|amd64)")
93+
# FORCE_32BIT is set in the build script when --32-bit is passed
94+
# on a Linux/intel 64bit host. This allows us to produce 32bit
95+
# binaries without setting the build up as a crosscompilation,
96+
# which is the only way to modify CMAKE_SYSTEM_PROCESSOR.
97+
if (FORCE_32BIT)
98+
set(WTF_CPU_X86 1)
99+
else ()
100+
set(WTF_CPU_X86_64 1)
101+
endif ()
102+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "(i[3-6]86|x86)")
103+
set(WTF_CPU_X86 1)
104+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "ppc")
105+
set(WTF_CPU_PPC 1)
106+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64")
107+
set(WTF_CPU_PPC64 1)
108+
elseif (LOWERCASE_CMAKE_SYSTEM_PROCESSOR MATCHES "ppc64le")
109+
set(WTF_CPU_PPC64LE 1)
110+
else ()
111+
set(WTF_CPU_UNKNOWN 1)
112+
endif ()
113+
114+
# -----------------------------------------------------------------------------
115+
# Determine the operating system
116+
# -----------------------------------------------------------------------------
117+
if (UNIX)
118+
if (APPLE)
119+
set(WTF_OS_MAC_OS_X 1)
120+
elseif (CMAKE_SYSTEM_NAME MATCHES "Linux")
121+
set(WTF_OS_LINUX 1)
122+
else ()
123+
set(WTF_OS_UNIX 1)
124+
endif ()
125+
elseif (CMAKE_SYSTEM_NAME MATCHES "Windows")
126+
set(WTF_OS_WINDOWS 1)
127+
elseif (CMAKE_SYSTEM_NAME MATCHES "Fuchsia")
128+
set(WTF_OS_FUCHSIA 1)
129+
else ()
130+
message(FATAL_ERROR "Unknown OS '${CMAKE_SYSTEM_NAME}'")
131+
endif ()
132+
133+
# -----------------------------------------------------------------------------
134+
# Default library types
135+
# -----------------------------------------------------------------------------
136+
# By default, only the highest-level libraries, WebKitLegacy and WebKit, are
137+
# shared, because properly building shared libraries that depend on each other
138+
# can be tricky. Override these in Options*.cmake for your port as needed.
139+
set(bmalloc_LIBRARY_TYPE STATIC)
140+
set(WTF_LIBRARY_TYPE STATIC)
141+
set(JavaScriptCore_LIBRARY_TYPE STATIC)
142+
set(PAL_LIBRARY_TYPE STATIC)
143+
set(WebCore_LIBRARY_TYPE STATIC)
144+
set(WebKitLegacy_LIBRARY_TYPE SHARED)
145+
set(WebKit_LIBRARY_TYPE SHARED)
146+
set(WebCoreTestSupport_LIBRARY_TYPE STATIC)
147+
148+
set(CMAKE_POSITION_INDEPENDENT_CODE True)
149+
150+
# -----------------------------------------------------------------------------
151+
# Install JavaScript shell
152+
# -----------------------------------------------------------------------------
153+
option(SHOULD_INSTALL_JS_SHELL "generate an installation rule to install the built JavaScript shell")
154+
155+
# -----------------------------------------------------------------------------
156+
# Default output directories, which can be overwritten by ports
157+
#------------------------------------------------------------------------------
158+
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
159+
set(CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib)
160+
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
161+
9162
# -----------------------------------------------------------------------------
10163
# Find common packages (used by all ports)
11164
# -----------------------------------------------------------------------------

0 commit comments

Comments
 (0)