Turn a high-value UI-side-compositing assertion into a release assert

https://bugs.webkit.org/show_bug.cgi?id=194887

Reviewed by Simon Fraser.

* WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
There is absolutely no situation in which this assert should fire
if WebKit is behaving correctly, and it will basically always result
in a UI process crash (or at least confusion), so make it a release assert.
This would have saved us a lot of stress in bug 194845.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@241925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/WebKit/ChangeLog

@@ -1,3 +1,17 @@
+2019-02-21  Tim Horton  <[email protected]>
+
+        Turn a high-value UI-side-compositing assertion into a release assert
+        https://bugs.webkit.org/show_bug.cgi?id=194887
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
+        (WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
+        There is absolutely no situation in which this assert should fire
+        if WebKit is behaving correctly, and it will basically always result
+        in a UI process crash (or at least confusion), so make it a release assert.
+        This would have saved us a lot of stress in bug 194845.
+
 2019-02-21  Don Olmstead  <[email protected]>
 
         [MSVC] Fix compilation errors with lambdas in ResourceLoadStatistics

Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp

@@ -168,7 +168,7 @@ void PlatformCALayerRemote::updateClonedLayerProperties(PlatformCALayerRemote& c
 void PlatformCALayerRemote::recursiveBuildTransaction(RemoteLayerTreeContext& context, RemoteLayerTreeTransaction& transaction)
 {
     ASSERT(!m_properties.backingStore || owner());
-    ASSERT_WITH_SECURITY_IMPLICATION(&context == m_context);
+    RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(&context == m_context);
 
     if (m_properties.backingStore && (!owner() || !owner()->platformCALayerDrawsContent())) {
         m_properties.backingStore = nullptr;