Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit 72a9385

Browse files
Web Inspector: Settings: group titles should vertically align with the first editor
https://bugs.webkit.org/show_bug.cgi?id=193391 Reviewed by Dean Jackson. * UserInterface/Views/SettingsTabContentView.css: (.content-view.settings > .settings-view > .container): (.content-view.settings > .settings-view > .container > .editor-group > .editor): Added. (.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added. (.content-view.settings > .settings-view > .container > .editor-group > .editor select): (.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@239932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 5d60e68 commit 72a9385

File tree

2 files changed

+28
-5
lines changed

2 files changed

+28
-5
lines changed

Source/WebInspectorUI/ChangeLog

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2019-01-14 Devin Rousso <[email protected]>
2+
3+
Web Inspector: Settings: group titles should vertically align with the first editor
4+
https://bugs.webkit.org/show_bug.cgi?id=193391
5+
6+
Reviewed by Dean Jackson.
7+
8+
* UserInterface/Views/SettingsTabContentView.css:
9+
(.content-view.settings > .settings-view > .container):
10+
(.content-view.settings > .settings-view > .container > .editor-group > .editor): Added.
11+
(.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > *): Added.
12+
(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
13+
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
14+
115
2019-01-11 Matt Baker <[email protected]>
216

317
Web Inspector: REGRESSION: deleting an audit puts selection in a selected but invisible state

Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555

5656
.content-view.settings > .settings-view > .container {
5757
display: flex;
58-
align-items: center;
5958
margin-top: 1em;
6059
font-size: 13px;
6160
}
@@ -85,6 +84,14 @@
8584
flex-direction: column;
8685
}
8786

87+
.content-view.settings > .settings-view > .container > .editor-group > .editor {
88+
--settings-editor-child-margin-top: 0;
89+
}
90+
91+
.content-view.settings > .settings-view > .container > .editor-group > .editor:first-child > * {
92+
margin-top: var(--settings-editor-child-margin-top);
93+
}
94+
8895
.content-view.settings > .settings-view > .container > .editor-group > .editor input {
8996
font-size: inherit;
9097
}
@@ -103,16 +110,18 @@
103110
font-size: 16px;
104111

105112
/* Vertically align <select> with the group title text. */
106-
margin-top: 0;
113+
--settings-editor-child-margin-top: -2px;
107114
}
108115

109116
.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"] {
110-
/* Vertically align <input> with the group title text. */
111-
margin-top: -1px;
112-
113117
max-width: 48px;
118+
padding-top: 0;
119+
padding-bottom: 0;
114120
text-align: end;
121+
vertical-align: 1px;
115122

123+
/* Vertically align <input> with the group title text. */
124+
--settings-editor-child-margin-top: -2px;
116125
--settings-input-number-margin-start: 2px;
117126
--settings-input-number-margin-end: 5px;
118127
}

0 commit comments

Comments
 (0)