Use operand names when dumping Bytecode

https://bugs.webkit.org/show_bug.cgi?id=218084

Reviewed by Saam Barati.

For example this would output the following:
  [ 258] put_to_scope       scope:loc7, var:3, value:loc8, getPutInfo:1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, symbolTableOrScopeDepth:0, offset:0
instead of
  [ 258] put_to_scope       loc7, 3, loc8, 1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, 0, 0

* bytecode/BytecodeDumper.h:
(JSC::BytecodeDumperBase::dumpOperand):
* generator/Opcode.rb:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@268871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Author: [email protected]

Source/JavaScriptCore/ChangeLog

@@ -1,3 +1,19 @@
+2020-10-22  Robin Morisset  <[email protected]>
+
+        Use operand names when dumping Bytecode
+        https://bugs.webkit.org/show_bug.cgi?id=218084
+
+        Reviewed by Saam Barati.
+
+        For example this would output the following:
+          [ 258] put_to_scope       scope:loc7, var:3, value:loc8, getPutInfo:1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, symbolTableOrScopeDepth:0, offset:0
+        instead of
+          [ 258] put_to_scope       loc7, 3, loc8, 1048576<DoNotThrowIfNotFound|GlobalProperty|Initialization|NotStrictMode>, 0, 0
+
+        * bytecode/BytecodeDumper.h:
+        (JSC::BytecodeDumperBase::dumpOperand):
+        * generator/Opcode.rb:
+
 2020-10-21  Caitlin Potter  <[email protected]>
 
         [JSC] support op_get_private_name in DFG and FTL

Source/JavaScriptCore/bytecode/BytecodeDumper.h

@@ -47,10 +47,12 @@ class BytecodeDumperBase {
     void printLocationAndOp(InstructionStream::Offset location, const char* op);
 
     template<typename T>
-    void dumpOperand(T operand, bool isFirst = false)
+    void dumpOperand(const char* operandName, T operand, bool isFirst = false)
     {
         if (!isFirst)
             m_out.print(", ");
+        m_out.print(operandName);
+        m_out.print(":");
         dumpValue(operand);
     }
 

Source/JavaScriptCore/generator/Opcode.rb

@@ -269,7 +269,7 @@ def dumper
         dumper->printLocationAndOp(__location, &"**#{@name}"[2 - __sizeShiftAmount]);
 #{print_args { |arg|
 <<-EOF.chomp
-        dumper->dumpOperand(#{arg.field_name}, #{arg.index == 0});
+        dumper->dumpOperand("#{arg.name}", #{arg.field_name}, #{arg.index == 0});
 EOF
     }}
     }