Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Commit 2928fe5

Browse files
Spams system logs with "Current memory footprint: 10 MB"
https://bugs.webkit.org/show_bug.cgi?id=213991 Patch by Michael Catanzaro <[email protected]> on 2020-07-06 Reviewed by Darin Adler. This particular log statement is too much spam in the system journal, since it prints continuously under normal operating conditions. Let's limit it only to Apple platforms, which have had RELEASE_LOG() for a long time and where this is presumably expected. * wtf/MemoryPressureHandler.cpp: (WTF::MemoryPressureHandler::measurementTimerFired): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@263978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 4cada1d commit 2928fe5

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

Source/WTF/ChangeLog

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
2020-07-06 Michael Catanzaro <[email protected]>
2+
3+
Spams system logs with "Current memory footprint: 10 MB"
4+
https://bugs.webkit.org/show_bug.cgi?id=213991
5+
6+
Reviewed by Darin Adler.
7+
8+
This particular log statement is too much spam in the system journal, since it prints
9+
continuously under normal operating conditions. Let's limit it only to Apple platforms,
10+
which have had RELEASE_LOG() for a long time and where this is presumably expected.
11+
12+
* wtf/MemoryPressureHandler.cpp:
13+
(WTF::MemoryPressureHandler::measurementTimerFired):
14+
115
2020-07-06 Sam Weinig <[email protected]>
216

317
Compile-time enable (but leave disabled at runtime by default) date/time input types on macOS to allow testing of cross platform (e.g. DOM) aspects of the controls

Source/WTF/wtf/MemoryPressureHandler.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,9 @@ void MemoryPressureHandler::setMemoryUsagePolicyBasedOnFootprint(size_t footprin
191191
void MemoryPressureHandler::measurementTimerFired()
192192
{
193193
size_t footprint = memoryFootprint();
194+
#if PLATFORM(COCOA)
194195
RELEASE_LOG(MemoryPressure, "Current memory footprint: %zu MB", footprint / MB);
196+
#endif
195197
if (footprint >= thresholdForMemoryKill()) {
196198
shrinkOrDie();
197199
return;

0 commit comments

Comments
 (0)