Reworked generics assertTypes tests to be part of NodeScopeResolverTest

World's simplest code-based type resolver tests!

Author: ondrejmirtes

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -2,9 +2,11 @@
 
 namespace PHPStan\Analyser;
 
+use PhpParser\Node;
 use PhpParser\Node\Expr\Exit_;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Name;
 use PHPStan\Broker\AnonymousClassNameHelper;
 use PHPStan\Cache\Cache;
 use PHPStan\File\FileHelper;
@@ -9165,6 +9167,68 @@ public function testArrayShapesInPhpDoc(
 		);
 	}
 
+	public function dataGenerics(): array
+	{
+		require_once __DIR__ . '/data/generics.php';
+
+		return $this->gatherAssertTypes(__DIR__ . '/data/generics.php');
+	}
+
+	/**
+	 * @dataProvider dataGenerics
+	 * @param ConstantStringType $expectedType
+	 * @param Type $actualType
+	 */
+	public function testGenerics(
+		ConstantStringType $expectedType,
+		Type $actualType,
+		int $line
+	): void
+	{
+		$expected = $expectedType->getValue();
+		$actual = $actualType->describe(VerbosityLevel::precise());
+		$this->assertSame(
+			$expected,
+			$actual,
+			sprintf('Expected type %s, got type %s on line %d.', $expected, $actual, $line)
+		);
+	}
+
+	private function gatherAssertTypes(string $file): array
+	{
+		$types = [];
+		$this->processFile($file, function (Node $node, Scope $scope) use (&$types): void {
+			if (!$node instanceof Node\Expr\FuncCall) {
+				return;
+			}
+
+			$nameNode = $node->name;
+			if (!$nameNode instanceof Name) {
+				return;
+			}
+
+			$assertTypeFunctionName = 'PHPStan\\Analyser\\assertType';
+			if ((string) $nameNode !== $assertTypeFunctionName) {
+				return;
+			}
+
+			if (count($node->args) !== 2) {
+				$this->fail(sprintf(
+					'ERROR: Wrong %s() call on line %d.',
+					$assertTypeFunctionName,
+					$node->getLine()
+				));
+			}
+
+			$expectedTypeString = $scope->getType($node->args[0]->value);
+			$actualType = $scope->getType($node->args[1]->value);
+
+			$types[] = [$expectedTypeString, $actualType, $node->getLine()];
+		});
+
+		return $types;
+	}
+
 	public function dataTryCatchScope(): array
 	{
 		return [

tests/PHPStan/Generics/data/functionsAssertType.php renamed to tests/PHPStan/Analyser/data/generics.php

@@ -2,7 +2,7 @@
 
 namespace PHPStan\Generics\FunctionsAssertType;
 
-use function PHPStan\Generics\assertType;
+use function PHPStan\Analyser\assertType;
 
 /**
  * @template T

tests/PHPStan/Generics/functions.php renamed to tests/PHPStan/Analyser/functions.php

@@ -1,6 +1,6 @@
 <?php declare(strict_types = 1);
 
-namespace PHPStan\Generics;
+namespace PHPStan\Analyser;
 
 /**
  * Asserts the static type of a value.

tests/PHPStan/Generics/AssertTypeRule.php

@@ -9,7 +9,6 @@ public function dataTopics(): array
 	{
 		return [
 			['functions'],
-			['functionsAssertType'],
 			['invalidReturn'],
 			['pick'],
 			['varyingAcceptor'],

tests/PHPStan/Generics/GenericsIntegrationTest.php

@@ -1,7 +1,7 @@
 [
     {
         "message": "Parameter #1 $c of function PHPStan\\Generics\\Pick\\foo expects PHPStan\\Generics\\Pick\\A|PHPStan\\Generics\\Pick\\B, PHPStan\\Generics\\Pick\\A|PHPStan\\Generics\\Pick\\C given.",
-        "line": 26,
+        "line": 24,
         "ignorable": true
     }
 ]

tests/PHPStan/Generics/data/functionsAssertType-0.json

@@ -2,8 +2,6 @@
 
 namespace PHPStan\Generics\Pick;
 
-use function PHPStan\Generics\assertType;
-
 class A {}
 class B {}
 class C {}