-
-
Notifications
You must be signed in to change notification settings - Fork 831
Comparing changes
Open a pull request
base repository: TryGhost/node-sqlite3
base: v5.1.6
head repository: TryGhost/node-sqlite3
compare: master
Commits on May 29, 2023
-
Updated bundled SQLite to v3.42.0
refs https://www.sqlite.org/releaselog/3_42_0.html - sha3-256sum: `643898e9fcc8f6069bcd47b0e6057221c1ed17bbee57da20d2752c79d91274e8`
Configuration menu - View commit details
-
Copy full SHA for 22ac6cc - Browse repository at this point
Copy the full SHA 22ac6ccView commit details -
- Extensively utilized automatic type deduction for improved code rea…
…dability - Implemented RAII to ensure resource safety and exception safety - Leveraged range-based for loops for cleaner and more efficient iteration - Addressed and resolved all project-related warnings for enhanced code quality
Configuration menu - View commit details
-
Copy full SHA for cdf78bf - Browse repository at this point
Copy the full SHA cdf78bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfbe3ba - Browse repository at this point
Copy the full SHA dfbe3baView commit details
Commits on Oct 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 44e570a - Browse repository at this point
Copy the full SHA 44e570aView commit details
Commits on Dec 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7552aa0 - Browse repository at this point
Copy the full SHA 7552aa0View commit details
Commits on Dec 22, 2023
-
Revert "Update actions/setup-node action to v4"
This reverts commit 7552aa0.
Configuration menu - View commit details
-
Copy full SHA for 3aeb548 - Browse repository at this point
Copy the full SHA 3aeb548View commit details -
Updated bundled SQLite to v3.44.2
refs https://www.sqlite.org/releaselog/3_44_2.html - sha3-256sum: `6c427f0547e2f7babe636b748dd5d5a1f2f31601adadef7e2805e7d1f7171861`
Configuration menu - View commit details
-
Copy full SHA for 8d78ce7 - Browse repository at this point
Copy the full SHA 8d78ce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56ad63c - Browse repository at this point
Copy the full SHA 56ad63cView commit details -
- this doesn't do anything because we just rethrow the error
Configuration menu - View commit details
-
Copy full SHA for 10f38fe - Browse repository at this point
Copy the full SHA 10f38feView commit details
Commits on Dec 23, 2023
-
Installed setuptools in CI workflow
- Python 3.12 no longer ships with this and GHA CI has updated to 3.12, which breaks our build scripts - this should fix that until we can update node-gyp
Configuration menu - View commit details
-
Copy full SHA for 080c0d1 - Browse repository at this point
Copy the full SHA 080c0d1View commit details -
- merged pretest and test - removed `pack` as it is not needed
Configuration menu - View commit details
-
Copy full SHA for 93ed997 - Browse repository at this point
Copy the full SHA 93ed997View commit details
Commits on Dec 24, 2023
-
Added CI step to check semver compatibility
- right now our way to check semver compatibility is to run the tests on every version - this is really inefficient as it results in a lot of CI jobs that we don't need - this should run a CI job that ensures the minimum version we accept is Node 10.12.0
Configuration menu - View commit details
-
Copy full SHA for cff38a3 - Browse repository at this point
Copy the full SHA cff38a3View commit details -
- bumped building on Node 16 to Node 18 - removed all matrix executions apart from Node 18
Configuration menu - View commit details
-
Copy full SHA for 9e8b2ee - Browse repository at this point
Copy the full SHA 9e8b2eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c74f267 - Browse repository at this point
Copy the full SHA c74f267View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8482aaf - Browse repository at this point
Copy the full SHA 8482aafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83e282d - Browse repository at this point
Copy the full SHA 83e282dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7674271 - Browse repository at this point
Copy the full SHA 7674271View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2cee71 - Browse repository at this point
Copy the full SHA a2cee71View commit details -
Replaced
@mapbox/node-pre-gyp
in favor ofprebuild
+ `prebuild-in……stall` fixes #1641 fixes #1721 fixes #1714 fixes #1713 fixes #1700 fixes #1704 - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs which our users keep running into - it seems the prebuilt binary world has moved in favor of prebuild + it's various other forms - one option would be to use prebuildify to bundle all binaries into the package, but that's a step too far removed from the current situation for now - instead, we can use prebuild-install to download the binaries, and `prebuild` to build + upload the binaries - this means we can remove node-pre-gyp and fix a bunch of issues! - eventually, we could start providing electron prebuilt binaries too [1]: mapbox/node-pre-gyp#657
Configuration menu - View commit details
-
Copy full SHA for 605c7f9 - Browse repository at this point
Copy the full SHA 605c7f9View commit details -
Updated list of supported targets
- switched to just providing a list of platform + arch instead of the full formatted string
Configuration menu - View commit details
-
Copy full SHA for 2595304 - Browse repository at this point
Copy the full SHA 2595304View commit details -
Extracted common Node-API queuing code into macro
- this fixes building in debug mode because the compiler (at least, on macOS) doesn't like the `assert(status == 0)` - this also DRYs up some common code by moving it into a macro
Configuration menu - View commit details
-
Copy full SHA for c775b81 - Browse repository at this point
Copy the full SHA c775b81View commit details -
Configuration menu - View commit details
-
Copy full SHA for aabd297 - Browse repository at this point
Copy the full SHA aabd297View commit details -
Fixed uploading prebuilt binaries from Docker
- the path here was incorrect
Configuration menu - View commit details
-
Copy full SHA for 5809f62 - Browse repository at this point
Copy the full SHA 5809f62View commit details
Commits on Dec 27, 2023
-
Refactored Database to use macros for method definitions
- this cleans up similar definitions and makes further refactors easier
Configuration menu - View commit details
-
Copy full SHA for 8bda876 - Browse repository at this point
Copy the full SHA 8bda876View commit details -
Configuration menu - View commit details
-
Copy full SHA for 603e468 - Browse repository at this point
Copy the full SHA 603e468View commit details -
Increased number of rows inserted into benchmark database
- the whole benchmark suite needs reworking but this should be a good poor mans method to make the benchmarking suite heavier
Configuration menu - View commit details
-
Copy full SHA for 77b327c - Browse repository at this point
Copy the full SHA 77b327cView commit details -
Improved
RowToJS
performance by removingNapi::String::New
instan……tiation refs https://github.com/nodejs/node-addon-api/blob/main/doc/object.md#set - according to the node-addon-api docs, you can set various things as the key for a Napi::Object, including a std::string ref - instantiating a `Napi::String::New` is quite heavy, especially when we're doing it for every row we return, so we can avoid doing that and speed up the function - locally, this speeds up the benchmark by 5-15% (a lot of variance) but YMMV
Configuration menu - View commit details
-
Copy full SHA for 3372130 - Browse repository at this point
Copy the full SHA 3372130View commit details -
Inlined
init()
functions into class header files- these extra functions aren't really necessary and means there is more redirection occurring - as a bonus, this fixes a variable shadowing issue in the Statement implementation
Configuration menu - View commit details
-
Copy full SHA for e99160a - Browse repository at this point
Copy the full SHA e99160aView commit details -
Removed extraneous parameter to event emit function
- this was never passed to the user because the value below is `1` - our documentation says the close event doesn't emit any parameters, so we can just remove it from the array
Configuration menu - View commit details
-
Copy full SHA for 4ef11bf - Browse repository at this point
Copy the full SHA 4ef11bfView commit details
Commits on Dec 29, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for f792f69 - Browse repository at this point
Copy the full SHA f792f69View commit details -
Configured releases to be created as prereleases
- we don't want to suggest it's released until all the builds are done - also configured verbose logging for uploads
Configuration menu - View commit details
-
Copy full SHA for 83c8c0a - Browse repository at this point
Copy the full SHA 83c8c0aView commit details -
Fixed uploading release assets on Windows
- I foolishly used a bash env var format but Windows uses Powershell - simplest here is just to remove the env var and pass it in directly
Configuration menu - View commit details
-
Copy full SHA for 8b86e41 - Browse repository at this point
Copy the full SHA 8b86e41View commit details -
Fixed uploading assets from Docker
- the folder here has changed since we switched to prebuild
Configuration menu - View commit details
-
Copy full SHA for 8398daa - Browse repository at this point
Copy the full SHA 8398daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03d6e75 - Browse repository at this point
Copy the full SHA 03d6e75View commit details
Commits on Dec 30, 2023
-
Removed Node version from matrix title
- we only run CI on one version so it's not needed any more
Configuration menu - View commit details
-
Copy full SHA for d04c1fb - Browse repository at this point
Copy the full SHA d04c1fbView commit details
Commits on Jan 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ba4ba07 - Browse repository at this point
Copy the full SHA ba4ba07View commit details
Commits on Jan 16, 2024
-
Updated bundled SQLite to v3.45.0
refs https://www.sqlite.org/releaselog/3_45_0.html - sha3-256sum: `9fc2a78088875ae7c112957d58ccc52b1a0a4afa34ac669290be42f352b1aa76`
Configuration menu - View commit details
-
Copy full SHA for 1609684 - Browse repository at this point
Copy the full SHA 1609684View commit details
Commits on Nov 6, 2024
-
Updated
actions/upload-artifact
to v4daniellockyer authoredNov 6, 2024 Loading Loading status checks…Configuration menu - View commit details
-
Copy full SHA for 2f0c799 - Browse repository at this point
Copy the full SHA 2f0c799View commit details
Commits on Jan 20, 2025
-
Co-authored-by: Hannah Wolfe github.erisds@gmail.com
Loading Loading status checks…Configuration menu - View commit details
-
Copy full SHA for 528e15a - Browse repository at this point
Copy the full SHA 528e15aView commit details
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.