Skip to content

Commit 8b86e41

Browse files
committed
Fixed uploading release assets on Windows
- I foolishly used a bash env var format but Windows uses Powershell - simplest here is just to remove the env var and pass it in directly
1 parent 83c8c0a commit 8b86e41

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,8 @@ jobs:
106106
retention-days: 7
107107

108108
- name: Upload binaries to GitHub Release
109-
run: yarn upload
109+
run: yarn upload --upload-all ${{ github.token }}
110110
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
111-
env:
112-
GITHUB_TOKEN: ${{ github.token }}
113111

114112
build-qemu:
115113
runs-on: ubuntu-latest
@@ -162,7 +160,5 @@ jobs:
162160
retention-days: 7
163161

164162
- name: Upload binaries to GitHub Release
165-
run: yarn install --ignore-scripts && yarn upload
163+
run: yarn install --ignore-scripts && yarn upload --upload-all ${{ github.token }}
166164
if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
167-
env:
168-
GITHUB_TOKEN: ${{ github.token }}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"install": "prebuild-install -r napi || node-gyp rebuild",
7070
"prebuild": "prebuild --runtime napi --all --verbose",
7171
"rebuild": "node-gyp rebuild",
72-
"upload": "prebuild --verbose --prerelease --upload-all ${GITHUB_TOKEN}",
72+
"upload": "prebuild --verbose --prerelease",
7373
"test": "node test/support/createdb.js && mocha -R spec --timeout 480000"
7474
},
7575
"license": "BSD-3-Clause",

0 commit comments

Comments
 (0)