fix(nr-web): Fix 5 issues identified by Bugbot

1. HIGH: Fix plus code prefix generation producing malformed location tags
   - Fixed getPlusCodePrefixes to generate valid prefixes like 'XX000000+'
     instead of 'XX00000' (missing + character)

2. LOW: Remove unused exported utility functions
   - Removed hexToNsec, hexToNpub from keys.ts
   - Removed truncate from utils.ts

3. LOW: Remove unused replyingToEvent store state
   - Removed state variable and setter that were never read

4. MEDIUM: Fix race condition causing duplicate events when publishing
   - Added duplicate check in publishEvent before adding to state
   - Prevents double-adding when relay echoes back before publish resolves

5. MEDIUM: Fix modal state persisting between different locations
   - Added useEffect to reset content, error, and isSubmitting state
     when modal opens or location changes

Author: cursoragent

nr-web/src/components/AddNoteModal.tsx

@@ -1,6 +1,6 @@
 "use client";
 
-import { useState } from "react";
+import { useState, useEffect } from "react";
 import { useNostrStore } from "@/store/nostr";
 import { createMapNote } from "@/lib/events";
 import OpenLocationCode from "open-location-code";
@@ -19,6 +19,15 @@ export function AddNoteModal({ isOpen, onClose, location }: AddNoteModalProps) {
   const publishEvent = useNostrStore((state) => state.publishEvent);
   const privateKey = useNostrStore((state) => state.privateKey);
 
+  // Reset state when modal opens or location changes
+  useEffect(() => {
+    if (isOpen) {
+      setContent("");
+      setError(null);
+      setIsSubmitting(false);
+    }
+  }, [isOpen, location]);
+
   if (!isOpen || !location) return null;
 
   const plusCode = OpenLocationCode.encode(location.lat, location.lng, 10);

nr-web/src/lib/keys.ts

@@ -1,5 +1,5 @@
 import { getPublicKey, nip19 } from "nostr-tools";
-import { bytesToHex, hexToBytes } from "@noble/hashes/utils";
+import { bytesToHex } from "@noble/hashes/utils";
 import * as bip39 from "@scure/bip39";
 import { wordlist } from "@scure/bip39/wordlists/english";
 import { HDKey } from "@scure/bip32";
@@ -86,17 +86,3 @@ export function importMnemonic(mnemonic: string): {
     publicKey,
   };
 }
-
-/**
- * Convert hex private key to nsec
- */
-export function hexToNsec(hex: string): string {
-  return nip19.nsecEncode(hexToBytes(hex));
-}
-
-/**
- * Convert hex public key to npub
- */
-export function hexToNpub(hex: string): string {
-  return nip19.npubEncode(hex);
-}

nr-web/src/lib/utils.ts

@@ -62,6 +62,9 @@ export function formatDistanceToNow(timestamp: number): string {
 /**
  * Get plus code prefix tags for an event
  * Returns prefixes from 2 characters up to the full code length
+ * 
+ * Plus codes are formatted as: XXXXXXXX+XX (8 chars, +, 2 chars)
+ * Prefixes should be: XX000000+, XXXX0000+, XXXXXX00+, XXXXXXXX+, XXXXXXXX+XX
  */
 export function getPlusCodePrefixes(plusCode: string): string[] {
   const prefixes: string[] = [];
@@ -72,8 +75,11 @@ export function getPlusCodePrefixes(plusCode: string): string[] {
     const prefix = cleanCode.slice(0, len);
     // Add back the + for proper formatting
     if (len <= 8) {
-      prefixes.push(prefix + "000000+".slice(0, 8 - len + 1));
+      // Pad with zeros and add + at position 8
+      const paddedPrefix = prefix + "0".repeat(8 - len) + "+";
+      prefixes.push(paddedPrefix);
     } else {
+      // For codes longer than 8, format as XXXXXXXX+XX
       prefixes.push(
         prefix.slice(0, 8) + "+" + prefix.slice(8)
       );
@@ -82,11 +88,3 @@ export function getPlusCodePrefixes(plusCode: string): string[] {
 
   return prefixes;
 }
-
-/**
- * Truncate a string with ellipsis
- */
-export function truncate(str: string, maxLength: number): string {
-  if (str.length <= maxLength) return str;
-  return str.slice(0, maxLength - 3) + "...";
-}

nr-web/src/store/nostr.ts

@@ -37,7 +37,6 @@ interface NostrState {
 
   // UI State
   selectedEvent: Event | null;
-  replyingToEvent: Event | null;
 
   // Actions
   connect: () => Promise<void>;
@@ -61,7 +60,6 @@ interface NostrState {
 
   // UI actions
   setSelectedEvent: (event: Event | null) => void;
-  setReplyingToEvent: (event: Event | null) => void;
 }
 
 export const useNostrStore = create<NostrState>()(
@@ -86,7 +84,6 @@ export const useNostrStore = create<NostrState>()(
       },
       developerMode: false,
       selectedEvent: null,
-      replyingToEvent: null,
 
       // Connect to relay
       connect: async () => {
@@ -170,10 +167,13 @@ export const useNostrStore = create<NostrState>()(
 
         await relay.publish(event);
 
-        // Add to local state
-        set((state) => ({
-          events: [...state.events, event],
-        }));
+        // Add to local state only if not already present (avoid race condition with subscription)
+        set((state) => {
+          if (state.events.some((e) => e.id === event.id)) {
+            return state;
+          }
+          return { events: [...state.events, event] };
+        });
       },
 
       // Toggle layer visibility
@@ -221,10 +221,6 @@ export const useNostrStore = create<NostrState>()(
       setSelectedEvent: (event: Event | null) => {
         set({ selectedEvent: event });
       },
-
-      setReplyingToEvent: (event: Event | null) => {
-        set({ replyingToEvent: event });
-      },
     }),
     {
       name: "nostroots-web-storage",