Rename `ALLOW_SELECT` to clarify text selection?

[TomJGooding]

I think ALLOW_SELECT is a confusing name, as it implies selecting the widget itself rather than just its text.

Obviously this would be a breaking change, but I think worth clarifying that this relates to text selection.

[github-actions]

We found the following entry in the FAQ which you may find helpful:

• How can I select and copy text in a Textual app?

Feel free to close this issue if you found an answer in the FAQ. Otherwise, please give us a little time to review.

This is an automated reply, generated by FAQtory

[willmcgugan]

I guess it could be ALLOW_TEXT_SELECTION, but you are still going to need to read the docstring to understand it.

Doesn't the docstring make it clear?

"""Does this widget support automatic text selection? May be further refined with [Widget.allow_select][textual.widget.Widget.allow_select]"""

[TomJGooding]

I guess it could be ALLOW_TEXT_SELECTION, but you are still going to need to read the docstring to understand it.

I'm not sure the docstring really adds much apart from saying it is "automatic"?

For some context, I thought it worth raising this issue following #5770. It just seems confusing setting ALLOW_SELECT = False for buttons and other Textual widgets, as the name implies selecting the widget rather than just its text. There is also the allow_focus method which I think makes allow_select a more confusing name.

But perhaps that's just me. Obviously its entirely up to you and I appreciate this would be a breaking change!

[willmcgugan]

I don't see the source of confusion myself. There is no general mechanism to select a widget, therefore I would think text selection. I know others may differ on that, but there is little benefit in change the name now. Of course, I'm always willing to revisit such things if it turns out to be a common gotcha!

[github-actions]

Don't forget to star the repository!

Follow @textualizeio for Textual updates.