Skip to content

Commit dd08628

Browse files
committed
fix: enum-string 변환 문제 해결
1 parent 164f442 commit dd08628

File tree

6 files changed

+5
-69
lines changed

6 files changed

+5
-69
lines changed

src/main/java/team/mjk/agent/domain/company/application/CompanyService.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@
1919
import team.mjk.agent.domain.mcp.notion.domain.NotionRepository;
2020
import team.mjk.agent.domain.mcp.slack.domain.Slack;
2121
import team.mjk.agent.domain.mcp.slack.domain.SlackRepository;
22-
import team.mjk.agent.domain.member.application.dto.response.MemberGetInfoResponse2;
22+
import team.mjk.agent.domain.member.application.dto.response.MemberInfoGetResponse;
2323
import team.mjk.agent.domain.member.domain.Member;
2424
import team.mjk.agent.domain.member.domain.MemberRepository;
25-
import team.mjk.agent.domain.member.application.dto.response.MemberInfoGetResponse;
26-
import team.mjk.agent.domain.passport.domain.Passport;
2725
import team.mjk.agent.domain.passport.domain.PassportRepository;
2826
import team.mjk.agent.global.util.KmsUtil;
2927

@@ -175,10 +173,10 @@ public CompanyMemberListResponse getMembersInfo(Long memberId) {
175173

176174

177175
log.info("===== [4] MemberInfo 매핑 시작 - 여기서 N+1 문제 발생 =====");
178-
List<MemberGetInfoResponse2> memberInfoGetResponses = members.stream()
176+
List<MemberInfoGetResponse> memberInfoGetResponses = members.stream()
179177
.map(m -> {
180178
log.info("[Lazy Loading] Member(id: {}) 연관 엔티티 접근 -> 추가 쿼리 발생", m.getId());
181-
return MemberGetInfoResponse2.from(m, kmsUtil);
179+
return MemberInfoGetResponse.from(m, kmsUtil);
182180
})
183181
.collect(Collectors.toList());
184182
log.info("===== [4] MemberInfo 매핑 완료. (총 {}개의 Lazy 추가 쿼리 발생) =====\n", members.size());
@@ -187,7 +185,7 @@ public CompanyMemberListResponse getMembersInfo(Long memberId) {
187185
log.info("===== [5] 최종 응답 생성 완료 =====");
188186

189187
return CompanyMemberListResponse.builder()
190-
.members2(memberInfoGetResponses)
188+
.members(memberInfoGetResponses)
191189
.build();
192190
}
193191

src/main/java/team/mjk/agent/domain/company/dto/response/CompanyMemberListResponse.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,11 @@
22

33
import java.util.List;
44
import lombok.Builder;
5-
import team.mjk.agent.domain.member.application.dto.response.MemberGetInfoResponse2;
65
import team.mjk.agent.domain.member.application.dto.response.MemberInfoGetResponse;
76

87
@Builder
98
public record CompanyMemberListResponse(
10-
List<MemberInfoGetResponse> members,
11-
12-
List<MemberGetInfoResponse2> members2
13-
9+
List<MemberInfoGetResponse> members
1410
) {
1511

1612
}

src/main/java/team/mjk/agent/domain/member/application/dto/response/MemberGetInfoResponse2.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

src/main/java/team/mjk/agent/domain/member/domain/MemberRepository.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
import java.util.List;
44
import java.util.Optional;
55

6-
import org.springframework.data.repository.query.Param;
76
import team.mjk.agent.domain.company.domain.Company;
8-
import team.mjk.agent.domain.member.application.dto.response.MemberGetInfoResponse2;
9-
import team.mjk.agent.domain.member.application.dto.response.MemberInfoGetResponse;
107

118
public interface MemberRepository {
129

@@ -22,8 +19,6 @@ public interface MemberRepository {
2219

2320
List<Member> findAllByCompanyId(Long companyId);
2421

25-
List<MemberGetInfoResponse2> findAllMemberInfoByCompanyId(Long companyId);
26-
2722
void delete(Long memberId);
2823

2924
long countByCompanyId(Long companyId);

src/main/java/team/mjk/agent/domain/member/infrastructure/MemberJpaRepository.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
import org.springframework.data.jpa.repository.Query;
88
import org.springframework.data.repository.query.Param;
99
import team.mjk.agent.domain.company.domain.Company;
10-
import team.mjk.agent.domain.member.application.dto.response.MemberGetInfoResponse2;
11-
import team.mjk.agent.domain.member.application.dto.response.MemberInfoGetResponse;
1210
import team.mjk.agent.domain.member.domain.Member;
1311

1412
import java.util.Optional;
@@ -23,15 +21,6 @@ public interface MemberJpaRepository extends JpaRepository<Member, Long> {
2321

2422
List<Member> findAllByCompanyId(@Param("companyId") Long companyId);
2523

26-
@Query("select new team.mjk.agent.domain.member.application.dto.response.MemberGetInfoResponse2(" +
27-
"m.name, m.email, m.firstName, m.lastName, m.phoneNumber, m.gender, m.birthDate, " +
28-
"p.passportNumber, p.passportExpireDate) " +
29-
"from Member m " +
30-
"join m.company c " +
31-
"left join m.passport p " +
32-
"where c.id = :companyId")
33-
List<MemberGetInfoResponse2> findAllMemberInfoByCompanyId(@Param("companyId") Long companyId);
34-
3524
long countByCompanyId(Long companyId);
3625

3726
void deleteAllByCompanyId(Long companyId);

src/main/java/team/mjk/agent/domain/member/infrastructure/MemberRepositoryImpl.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
import lombok.RequiredArgsConstructor;
55
import org.springframework.stereotype.Repository;
66
import team.mjk.agent.domain.company.domain.Company;
7-
import team.mjk.agent.domain.member.application.dto.response.MemberGetInfoResponse2;
8-
import team.mjk.agent.domain.member.application.dto.response.MemberInfoGetResponse;
97
import team.mjk.agent.domain.member.domain.Member;
108
import team.mjk.agent.domain.member.domain.MemberRepository;
119

@@ -49,11 +47,6 @@ public List<Member> findAllByCompanyId(Long companyId) {
4947
return memberJpaRepository.findAllByCompanyId(companyId);
5048
}
5149

52-
@Override
53-
public List<MemberGetInfoResponse2> findAllMemberInfoByCompanyId(Long companyId) {
54-
return memberJpaRepository.findAllMemberInfoByCompanyId(companyId);
55-
}
56-
5750
@Override
5851
public void delete(Long memberId) {
5952
memberJpaRepository.deleteById(memberId);

0 commit comments

Comments
 (0)