Aligning with Cone Node #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlawson02
suggested changes
Mar 19, 2023
cjlawson02
suggested changes
Mar 20, 2023
| fieldRelative = false; | ||
| } | ||
|
|
||
| m_drive.driveInput(translation, rot, fieldRelative); |
There was a problem hiding this comment.
You're feeding an angle into the rotation percent. I think we should make a pid loop similar to the rotation loop that uses the limelight's angle as the error, and the target should be 0 degrees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
There is an if-statement in Robot.java that checks if the right bumper on the driver stick is pressed, and if it is the setTragetRobotAngle() method is called with a pose angle passed in from the limelight.