enabled truthy values

[timothedelion]

enabled is considered falsy only if it is strictly equal to false.

So if you pass undefined or "" to enabled, it will be considered truthy and the query will be triggered. Which is not what I expect intuitively.

What do you think about casting the input value as a Boolean ? Am I missing a part of the picture ?

[TkDodo]

we've had this in v2 and moved away from this in v3. We now:

• have TypeScript that tells you what to do
• throw a runtime error if you try to pass in something that's not a boolean:

query/packages/query-core/src/queryObserver.ts

Lines 176 to 181 in af2e27e

	if (
	typeof this.options.enabled !== 'undefined' &&
	typeof this.options.enabled !== 'boolean'
	) {
	throw new Error('Expected enabled to be a boolean')
	}

I'm not really sure why we don't allow non-booleans. I think being explicit about your intentions doesn't hurt though :)