Skip to content

Update pg package to version 8 or allow ssl configuration? #28

@rosstroha

Description

@rosstroha

Hi there! First, thank you all for taking the time to create this package. It's a huge timesaver, even after dealing with a two day long problem I just figured out. My brain is still swimming with all the different variables and troubleshooting things I had tried, so I apologize if these suggested changes aren't your responsibility!

I'm using Heroku to host the bot and a Heroku Postgres addon. Heroku's documentation states that an ssl config object is needed, as seen here. The problem is that pg@8 is the version that allows one to do it in this exact way. See the breaking changes here. or, as an alternative, add an env var PGSSLMODE=no-verify. This env var only works if pg@8 is installed, apparently.

My problem was this: No connection was being made to the db through botbuilder-storage-postgres. There were no errors. I solved it by explicitly installing pg@8 as well as adding PGSSLMODE=no-verify because I didn't have access to the ssl configuration object through this package. As the lazy developer that I am I relied on pg being installed as a dependency of this package, which it is. However, it's one major version behind; the one that doesn't jive with PGSSLMODE.

  1. Could we be allowed to configure the ssl options?
    or
  2. Could this package be updated to use the latest and greatest pg@8?

Many thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions