Skip to content

Fix Chinese localization split page numbering #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented May 22, 2025

Description of Changes

Please provide a summary of the changes, including:

  • What was changed
    Updated the values of split.desc.6, split.desc.7, and split.desc.8 in src/main/resources/messages_zh_CN.properties to correct the page numbers:

  • Why the change was made
    The previous numbering was inconsistent and would have led to incorrect split outputs in the Chinese UI. This ensures that users splitting a document see the correct page ranges.

  • Translation Method
    The correction of these translation strings was generated and verified using AI assistance.

Closes #3529


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@Copilot Copilot AI review requested due to automatic review settings May 22, 2025 19:45
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 22, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the Chinese localization for split page descriptions by adjusting the page numbers to match the actual split output.

  • Updated split.desc.6 from “第 7 页” to “第 8 页”
  • Updated split.desc.7 from “第 8 页” to “第 9 页”
  • Updated split.desc.8 from “第 9 页和第 10 页” to “第 10 页”

@dosubot dosubot bot added the Bug Something isn't working label May 22, 2025
Copy link
Contributor

🚀 Translation Verification Summary

🔄 Reference Branch: main-branch-messages_en_GB.properties

📃 File Check: messages_zh_CN.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

✅ Overall Check Status: Success

Thanks @Ludy87 for your help in keeping the translations up to date.

@Frooodle Frooodle merged commit f2f1149 into Stirling-Tools:main May 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files. Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Translation error
2 participants