make it not overwrite the versions.properties from included builds

Author: NikkyAI

plugins/core/src/main/kotlin/de/fayard/refreshVersions/core/RefreshVersionsCoreSetup.kt

@@ -3,6 +3,7 @@
 package de.fayard.refreshVersions.core
 
 import de.fayard.refreshVersions.core.extensions.gradle.isBuildSrc
+import de.fayard.refreshVersions.core.extensions.gradle.isIncluded
 import de.fayard.refreshVersions.core.internal.*
 import de.fayard.refreshVersions.core.internal.resolveVersion
 import de.fayard.refreshVersions.core.internal.setupVersionPlaceholdersResolving

plugins/core/src/main/kotlin/de/fayard/refreshVersions/core/RefreshVersionsTask.kt

@@ -56,6 +56,7 @@ open class RefreshVersionsTask : DefaultTask() {
         // will reduce the number of repositories lookups, improving performance a little more.
 
         runBlocking {
+            logger.lifecycle("${project.rootDir.name} task action")
             val lintUpdatingProblemsAsync = async {
                 configureLintIfRunningOnAnAndroidProject(settings, RefreshVersionsConfigHolder.readVersionsMap())
             }

plugins/core/src/main/kotlin/de/fayard/refreshVersions/core/extensions/gradle/Settings.kt

@@ -5,3 +5,6 @@ import org.gradle.api.initialization.Settings
 
 @InternalRefreshVersionsApi
 val Settings.isBuildSrc: Boolean get() = rootProject.name == "buildSrc"
+
+@InternalRefreshVersionsApi
+val Settings.isIncluded: Boolean get() = startParameter.projectDir == null

plugins/core/src/main/kotlin/de/fayard/refreshVersions/core/internal/RefreshVersionsConfigHolder.kt

@@ -1,6 +1,7 @@
 package de.fayard.refreshVersions.core.internal
 
 import de.fayard.refreshVersions.core.extensions.gradle.isBuildSrc
+import de.fayard.refreshVersions.core.extensions.gradle.isIncluded
 import de.fayard.refreshVersions.core.extensions.gradle.isRootProject
 import de.fayard.refreshVersions.core.internal.versions.VersionsPropertiesModel
 import de.fayard.refreshVersions.core.internal.versions.VersionsPropertiesModel.Section.VersionEntry
@@ -25,6 +26,9 @@ object RefreshVersionsConfigHolder {
     internal var isSetupViaPlugin = false
         private set
 
+    private var isInitialized: Boolean = false
+        private set
+
     private val versionKeyReaderDelegate = resettableDelegates.LateInit<ArtifactVersionKeyReader>()
 
     var versionKeyReader: ArtifactVersionKeyReader by versionKeyReaderDelegate
@@ -78,6 +82,9 @@ object RefreshVersionsConfigHolder {
         versionsPropertiesFile: File
     ) {
         require(settings.isBuildSrc.not())
+        if(isInitialized && settings.isIncluded) {
+            return
+        }
         settings.gradle.buildFinished {
             clearStaticState()
         }
@@ -88,6 +95,7 @@ object RefreshVersionsConfigHolder {
         }
         this.artifactVersionKeyRules = artifactVersionKeyRules
         versionKeyReader = ArtifactVersionKeyReader.fromRules(filesContent = artifactVersionKeyRules)
+        isInitialized = true
     }
 
     internal fun initializeBuildSrc(settings: Settings) {
@@ -124,6 +132,7 @@ object RefreshVersionsConfigHolder {
     private fun clearStaticState() {
         httpClient.dispatcher.executorService.shutdown()
         resettableDelegates.reset()
+        isInitialized = false
         // Clearing static state is needed because Gradle holds onto previous builds, yet,
         // duplicates static state.
         // We need to beware of never retaining Gradle objects.

plugins/settings.gradle.kts

@@ -1,12 +1,16 @@
 import de.fayard.refreshVersions.bootstrapRefreshVersions
+import de.fayard.refreshVersions.migrateRefreshVersionsIfNeeded
 
 buildscript {
     repositories {
         gradlePluginPortal()
     }
     dependencies.classpath("de.fayard.refreshVersions:refreshVersions:0.9.7")
+////                                                      # available:0.10.0")
 }
 
+migrateRefreshVersionsIfNeeded("0.9.7") // Will be automatically removed by refreshVersions when upgraded to the latest version.
+
 bootstrapRefreshVersions()
 
 plugins {

sample-include-build/gradle

@@ -27,12 +27,6 @@ repositories {
     google()
 }
 
-fun DependencyHandler.implementations(deps: List<String>) =
-    deps.forEach { implementation(it) }
-
-fun DependencyHandler.testImplementations(deps: List<String>) =
-    deps.forEach { testImplementation(it) }
-
 dependencies {
 //    api(project(":subproject"))
 //    api(project(":subproject2"))

sample-include-build/gradlew

@@ -21,7 +21,7 @@ plugins {
 }
 
 refreshVersions {
-    versionsPropertiesFile = rootDir.parentFile.resolve("versions.properties")
+//    versionsPropertiesFile = rootDir.parentFile.resolve("versions.properties")
     featureFlags {
         enable(LIBS)
         disable(GRADLE_UPDATES)

sample-include-build/gradlew.bat

@@ -26,12 +26,6 @@ repositories {
     google()
 }
 
-fun DependencyHandler.implementations(deps: List<String>) =
-    deps.forEach { implementation(it) }
-
-fun DependencyHandler.testImplementations(deps: List<String>) =
-    deps.forEach { testImplementation(it) }
-
 dependencies {
     api("org.apache.poi:poi:_")
     api("org.apache.poi:poi-ooxml:_")

sample-include-build/included/build.gradle.kts

@@ -0,0 +1,31 @@
+#### Dependencies and Plugin versions with their available updates.
+#### Generated by `./gradlew refreshVersions` version 0.10.1-SNAPSHOT
+####
+#### Don't manually edit or split the comments that start with four hashtags (####),
+#### they will be overwritten by refreshVersions.
+####
+#### suppress inspection "SpellCheckingInspection" for whole file
+#### suppress inspection "UnusedProperty" for whole file
+
+plugin.org.jetbrains.kotlin.jvm=version.kotlin
+
+version.apache.poi=5.0.0
+
+version.kotlin=1.4.32
+## # available=1.5.0-dev-12
+## # available=1.5.0-dev-15
+## # available=1.5.0-M1
+## # available=1.5.0-M2
+## # available=1.5.0-RC
+## # available=1.5.0
+## # available=1.5.10
+## # available=1.5.20-M1
+
+version.kotlinx.collections.immutable=0.3.4
+
+version.okhttp3=4.9.1
+##  # available=4.10.0-RC1
+##  # available=5.0.0-alpha.1
+##  # available=5.0.0-alpha.2
+
+version.org.gradle..gradle-hello-world-plugin=0.2

sample-include-build/included/gradle

@@ -7,6 +7,8 @@
 #### suppress inspection "SpellCheckingInspection" for whole file
 #### suppress inspection "UnusedProperty" for whole file
 
+plugin.org.jetbrains.kotlin.jvm=version.kotlin
+
 version.androidx.browser=1.0.0
 ##           # available=1.2.0-alpha07
 ##           # available=1.2.0-alpha08
@@ -77,6 +79,8 @@ version.kotest=4.1.3
 ## # available=4.6.0
 
 version.kotlin=1.4.32
+## # available=1.5.0-dev-12
+## # available=1.5.0-dev-15
 ## # available=1.5.0-M1
 ## # available=1.5.0-M2
 ## # available=1.5.0-RC