Skip to content
This repository was archived by the owner on Apr 27, 2021. It is now read-only.
This repository was archived by the owner on Apr 27, 2021. It is now read-only.

Knex version 0.20 and above conflicts with no-invalid-await #889

@KristjanTammekivi

Description

@KristjanTammekivi

I want to report a bug.

SonarTS version: 1.9.0

Node.js version: 12.13.0

TypeScript version: 3.7.2

TSLint version: 5.18.0

Rule key: no-invalid-await

Reproducer

interface SomeCallable {
    (cb: Function): Promise<any>;
}

interface Builder {
    then: SomeCallable;
}

async function testme(knex: Builder) {
    await knex; // Type of 'await' operand must either be a valid promise or must not contain a callable 'then' member 
}

Expected behavior

Knex typings were changed in 0.20.0 so they don't inherit from Promise anymore, but there are still .then/.catch methods and should not warn (initially reported this in knex/knex#3516)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions