fix 183 (#184)

Author: gdbarron

RELEASE.md

@@ -1,4 +1,3 @@
-- Fix #172, `Get-ServiceNowRecord -IncludeCustomVariable` not returning values
-- `Get-ServiceNowRecord -IncludeCustomVariable` 'variable.' prefix has been removed from custom variable property name.
-- Add pipeline functionality to `-Id` parameter of `Get-ServiceNowRecord`
-- Fix `Get-ServiceNowRecord -AsValue` causing error with some values
+- Fix [#183](https://github.com/Snow-Shell/servicenow-powershell/issues/183), `Get-ServiceNowRecord -Filter` parameter not applying in some circumstances
+- Update display formats to correctly show values when `-DisplayValue` is false
+- Update `Get-ServiceNowRecord` help

ServiceNow/Public/Get-ServiceNowRecord.ps1

@@ -16,7 +16,7 @@
 
 .PARAMETER ParentId
     The sys_id or number of the parent record.
-    For example, to get catalog tasks for a requested item, provide the RITM number as ParentId.
+    For example, to get catalog tasks for a requested item, provide the RITM number as ParentId and catalog task as the Table.
 
 .PARAMETER Description
     Filter results based on the 'description' field.  The field will be different for each table.
@@ -25,7 +25,7 @@
     The comparison performed is a 'like'.
 
 .PARAMETER Property
-    Return one or more specific fields
+    Return one or more specific fields otherwise all fields will be returned
 
 .PARAMETER Filter
     Array or multidimensional array of fields and values to filter on.
@@ -119,13 +119,16 @@
     Get a specific record by number using the function alias
 
 .INPUTS
-    None
+    Id
 
 .OUTPUTS
-    System.Management.Automation.PSCustomObject
+    PSCustomObject.  If -AsValue is used, the type will be the selected field.
 
 .LINK
     https://docs.servicenow.com/bundle/quebec-platform-user-interface/page/use/common-ui-elements/reference/r_OpAvailableFiltersQueries.html
+
+.LINK
+    https://developer.servicenow.com/dev.do#!/reference/api/sandiego/rest/c_TableAPI#table-GET
 #>
 function Get-ServiceNowRecord {
 
@@ -197,6 +200,7 @@ function Get-ServiceNowRecord {
     begin {
 
         $invokeParams = @{
+            Filter            = $Filter
             Property          = $Property
             Sort              = $Sort
             DisplayValue      = $DisplayValue
@@ -245,8 +249,8 @@ function Get-ServiceNowRecord {
                 $idFilter = @('number', '-eq', $Id)
             }
 
-            if ( $Filter ) {
-                $invokeParams.Filter = $Filter, 'and', $idFilter
+            if ( $invokeParams.Filter ) {
+                $invokeParams.Filter = $invokeParams.Filter, 'and', $idFilter
             }
             else {
                 $invokeParams.Filter = $idFilter
@@ -291,7 +295,7 @@ function Get-ServiceNowRecord {
         $addedSysIdProp = $false
         # we need the sys_id value in order to get custom var data
         # add it in if specific properties were requested and not part of the list
-        if ( $IncludeCustomVariable.IsPresent ) {
+        if ( $IncludeCustomVariable ) {
             if ( $Property -and 'sys_id' -notin $Property ) {
                 $invokeParams.Property += 'sys_id'
                 $addedSysIdProp = $true

ServiceNow/ServiceNow.format.ps1xml

@@ -51,15 +51,23 @@
 							</TableColumnItem>
 							<TableColumnItem>
 								<ScriptBlock>
-									$_.assigned_to.display_value
+									if ($_.assigned_to.display_value) {
+										$_.assigned_to.display_value
+									} else {
+										$_.assigned_to.value
+									}
 								</ScriptBlock>
 							</TableColumnItem>
 							<TableColumnItem>
 								<PropertyName>approval</PropertyName>
 							</TableColumnItem>
 							<TableColumnItem>
 								<ScriptBlock>
-									$_.cmdb_ci.display_value
+									if ($_.cmdb_ci.display_value) {
+										$_.cmdb_ci.display_value
+									} else {
+										$_.cmdb_ci.value
+									}
 								</ScriptBlock>
 							</TableColumnItem>
 							<TableColumnItem>
@@ -116,7 +124,11 @@
 							</TableColumnItem>
 							<TableColumnItem>
 								<ScriptBlock>
-									$_.assigned_to.display_value
+									if ($_.assigned_to.display_value) {
+										$_.assigned_to.display_value
+									} else {
+										$_.assigned_to.value
+									}
 								</ScriptBlock>
 							</TableColumnItem>
 							<TableColumnItem>
@@ -176,7 +188,11 @@
 							</TableColumnItem>
 							<TableColumnItem>
 								<ScriptBlock>
-									$_.assigned_to.display_value
+									if ($_.assigned_to.display_value) {
+										$_.assigned_to.display_value
+									} else {
+										$_.assigned_to.value
+									}
 								</ScriptBlock>
 							</TableColumnItem>
 							<TableColumnItem>
@@ -367,7 +383,11 @@
 							</TableColumnItem>
 							<TableColumnItem>
 								<ScriptBlock>
-									$_.request_item.display_value
+									if ($_.request_item.display_value) {
+										$_.request_item.display_value
+									} else {
+										$_.request_item.value
+									}
 								</ScriptBlock>
 							</TableColumnItem>
 						</TableColumnItems>
@@ -420,7 +440,11 @@
 							</TableColumnItem>
 							<TableColumnItem>
 								<ScriptBlock>
-									$_.change_request.display_value
+									if ($_.change_request.display_value) {
+										$_.change_request.display_value
+									} else {
+										$_.change_request.value
+									}
 								</ScriptBlock>
 							</TableColumnItem>
 						</TableColumnItems>