Skip to content

[Healthcheck] Feature #3583, introduce category.is_anchor config check #3594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

[Healthcheck] Feature #3583, introduce category.is_anchor config check #3594

merged 1 commit into from
May 16, 2025

Conversation

vahonc
Copy link
Collaborator

@vahonc vahonc commented May 5, 2025

No description provided.

@rbayet
Copy link
Collaborator

rbayet commented May 7, 2025

Hello @vahonc,

This sections of the feature is not correctly implemented when the configuration of the attribute is not valid

Test on attribute failed
If the default value of the attribute has been changed
The default value of the category attribute "Is Anchor (is_anchor)" is no longer set to 1 / Yes. This means all future categories created on the site will no longer automatically be "anchor" categories.
If the frontend input is no longer 'hidden'
The category attribute "Is Anchor (is_anchor)" is no longer hidden on the Admin category edit page. This means the admin users can change categories to no longer being "anchor" categories.

At the moment, you only add the common text, ie "This may cause some issues [...] search results pages".

@rbayet rbayet removed their assignment May 7, 2025
@vahonc
Copy link
Collaborator Author

vahonc commented May 12, 2025

Fixed.

@vahonc vahonc assigned rbayet and unassigned vahonc May 12, 2025
@vahonc vahonc force-pushed the feature-3583-healthcheck-category-is-anchor-config-check branch from 83fa932 to 72c5a1f Compare May 12, 2025 14:33
rbayet
rbayet requested changes May 15, 2025
View reviewed changes
@rbayet rbayet assigned vahonc and unassigned rbayet May 15, 2025
@vahonc vahonc force-pushed the feature-3583-healthcheck-category-is-anchor-config-check branch from 72c5a1f to e547039 Compare May 15, 2025 13:45
@vahonc vahonc force-pushed the feature-3583-healthcheck-category-is-anchor-config-check branch from e547039 to 9e0722d Compare May 15, 2025 13:50
@vahonc vahonc assigned rbayet and unassigned vahonc May 15, 2025
@rbayet rbayet merged commit 27b6e1d into Smile-SA:2.10.x May 16, 2025
23 checks passed
@rbayet
Copy link
Collaborator

rbayet commented May 16, 2025

I'll add the finishing touches (i18n)

@rbayet rbayet linked an issue May 16, 2025 that may be closed by this pull request
[Healthcheck] Check default value of category.is_anchor (should be category.is_anchor = 1) #3583
Open
@vahonc vahonc deleted the feature-3583-healthcheck-category-is-anchor-config-check branch May 16, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbayet rbayet rbayet approved these changes

Assignees

@rbayet rbayet

Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Healthcheck] Check default value of category.is_anchor (should be category.is_anchor = 1)
2 participants
@vahonc @rbayet