Skip to content

Magento 2.4.8 compatibility #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vahonc opened this issue Apr 10, 2025 · 2 comments · Fixed by #3586
Closed

Magento 2.4.8 compatibility #3578

vahonc opened this issue Apr 10, 2025 · 2 comments · Fixed by #3586
Assignees
@vahonc
Labels
priority Priority

Comments

@vahonc
Copy link
Collaborator

vahonc commented Apr 10, 2025 •
edited
Loading

The final release of Magento 2.4.8 is already available for partners.

It's already been added to our integration test suite for branch 2.11.x. All tests are working actually which is a good start.

However, we need to check that all features are functioning as expected.

https://experienceleague.adobe.com/docs/commerce-operations/release/notes/adobe-commerce/2-4-8.html

https://developer-stage.adobe.com/commerce/php/development/backward-incompatible-changes/highlights/#248

https://developer-stage.adobe.com/commerce/php/development/backward-incompatible-changes/highlights/#upgraded-php-dependency

So, let's test Elasticsuite compatibility with the new release!
@vahonc vahonc self-assigned this Apr 10, 2025
@vahonc
Copy link
Collaborator Author

vahonc commented Apr 11, 2025

I noticed an issue with PHP 8.4 and many deprecated functionalities in our modules. PHP 8.4 wants to be explicit with nullable types now.

Already working on a fix for this.

@vahonc vahonc added the priority Priority label Apr 11, 2025
vahonc added a commit to vahonc/elasticsuite that referenced this issue Apr 14, 2025
@vahonc
Fix Smile-SA#3578, add supporting PHP 8.4 for ElasticSuite 2.11.x
bd51a44
vahonc added a commit to vahonc/elasticsuite that referenced this issue Apr 14, 2025
@vahonc
Fix Smile-SA#3578, phpcs warnings
e0efdf4
vahonc added a commit to vahonc/elasticsuite that referenced this issue Apr 16, 2025
@vahonc
Fix Smile-SA#3578, phpcs/phpunit issues
0f4ef7b
@rbayet rbayet linked a pull request Apr 22, 2025 that will close this issue
[Compat] Fixes Smile-SA#3578 PHP 8.4 deprecation: Implicitly marking parameter as nullable is deprecated #3586
Merged
@rbayet rbayet closed this as completed in efb9b7b Apr 22, 2025
rbayet added a commit that referenced this issue Apr 22, 2025
@rbayet
Merge pull request #3586 from rbayet/feat_php84_compat_step_by_step
ca58949 
[Compat] Fixes #3578 PHP 8.4 deprecation: Implicitly marking parameter as nullable is deprecated
@rbayet rbayet pinned this issue Apr 22, 2025
@rbayet
Copy link
Collaborator

rbayet commented Apr 24, 2025

PHP 8.4 support in Magento 2.4.8 available through the (just published) release 2.11.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vahonc vahonc

Labels
priority Priority
Projects
None yet
Milestone
No milestone
2 participants
@rbayet @vahonc