Skip to content

Make TRUST_ENDPOINTS_FOR_REQUESTS take hostnames instead of URLs #9990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pwuts opened this issue May 20, 2025 — with Linear · 0 comments
Open

Make TRUST_ENDPOINTS_FOR_REQUESTS take hostnames instead of URLs #9990

Pwuts opened this issue May 20, 2025 — with Linear · 0 comments

Comments

Copy link
Member

Pwuts commented May 20, 2025

If you put e.g. 192.168.1.42 into TRUST_ENDPOINTS_FOR_REQUESTS, it doesn't work because urlparse can't parse URLs without a schema. So instead of converting from URL to hostname in Requests.__init__, we should just make TRUST_ENDPOINTS_FOR_REQUESTS a list of hostnames rather than URLs, and also probably rename it to TRUSTED_HOSTS_FOR_REQUESTS.

@Pwuts Pwuts added the tech debt label May 20, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant