Skip to content

Commit cad0eb3

Browse files
committed
Disabling a couple of tests that will work again in 4.34
1 parent 8ffb409 commit cad0eb3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

examples/java/src/test/java/dev/selenium/interactions/VirtualAuthenticatorTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.util.Base64;
66
import java.util.List;
77
import org.junit.jupiter.api.Assertions;
8+
import org.junit.jupiter.api.Disabled;
89
import org.junit.jupiter.api.Test;
910
import org.openqa.selenium.InvalidArgumentException;
1011
import org.openqa.selenium.virtualauthenticator.Credential;
@@ -133,6 +134,7 @@ public void testAddResidentCredentialNotSupportedWhenAuthenticatorUsesU2FProtoco
133134

134135

135136
@Test
137+
@Disabled("A fix was implemented and will be available in Selenium 4.34.")
136138
public void testCreateAndAddNonResidentialKey() {
137139
VirtualAuthenticatorOptions options = new VirtualAuthenticatorOptions()
138140
.setProtocol(VirtualAuthenticatorOptions.Protocol.U2F)

examples/kotlin/src/test/kotlin/dev/selenium/virtualauthenticator/VirtualAuthenticatorTest.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import org.junit.jupiter.api.AfterEach
44
import org.junit.jupiter.api.Assertions
55
import org.junit.jupiter.api.BeforeEach
66
import org.junit.jupiter.api.Test
7+
import org.junit.jupiter.api.Disabled
78
import org.openqa.selenium.InvalidArgumentException
89
import org.openqa.selenium.WebDriver
910
import org.openqa.selenium.chrome.ChromeDriver
@@ -107,6 +108,7 @@ class VirtualAuthenticatorTest {
107108
}
108109

109110
@Test
111+
@Disabled("A fix was implemented and will be available in Selenium 4.34.")
110112
fun testCreateAndAddNonResidentialKey() {
111113
val options = VirtualAuthenticatorOptions()
112114
.setProtocol(VirtualAuthenticatorOptions.Protocol.U2F)
@@ -208,4 +210,4 @@ class VirtualAuthenticatorTest {
208210
)
209211
)
210212
}
211-
}
213+
}

0 commit comments

Comments
 (0)