Skip to content

Commit 104833b

Browse files
committed
Adding fixes to service test and fixing code references.
1 parent ffbf252 commit 104833b

File tree

5 files changed

+41
-40
lines changed

5 files changed

+41
-40
lines changed

examples/javascript/test/drivers/service.spec.js

Lines changed: 37 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -6,56 +6,57 @@ const {Browser, Builder} = require("selenium-webdriver");
66
const {getBinaryPaths} = require("selenium-webdriver/common/driverFinder");
77

88
describe('Service Test', function () {
9-
it('Default service', async function () {
10-
let service = new Chrome.ServiceBuilder()
11-
12-
let driver = new Builder()
13-
.forBrowser(Browser.CHROME)
14-
.setChromeService(service)
15-
.build();
9+
let driver;
10+
let userDataDir;
11+
let service;
12+
let options;
13+
14+
afterEach(async function () {
15+
if (driver) {
16+
await driver.quit();
17+
driver = null;
18+
}
19+
if (userDataDir) {
20+
fs.rmSync(userDataDir, { recursive: true, force: true });
21+
userDataDir = null;
22+
}
23+
});
1624

25+
it('Default service', async function () {
26+
service = new Chrome.ServiceBuilder();
27+
driver = new Builder()
28+
.forBrowser(Browser.CHROME)
29+
.setChromeService(service)
30+
.build();
1731
await driver.get('https://www.selenium.dev/selenium/web/blank.html');
18-
await driver.quit();
1932
});
2033

2134
it('Set Driver Location', async function () {
22-
23-
let options = new Chrome.Options();
24-
options.setBrowserVersion("stable")
25-
26-
let paths = getBinaryPaths(options)
35+
options = new Chrome.Options();
36+
options.setBrowserVersion("stable");
37+
let paths = getBinaryPaths(options);
2738
let driverPath = paths.driverPath;
2839
let browserPath = paths.browserPath;
29-
30-
options.setChromeBinaryPath(browserPath)
31-
const userDataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'chrome-profile-'));
40+
options.setChromeBinaryPath(browserPath);
41+
userDataDir = fs.mkdtempSync(path.join(os.tmpdir(), 'chrome-profile-'));
3242
options.addArguments(`--user-data-dir=${userDataDir}`);
3343
options.addArguments('--no-sandbox');
3444
options.addArguments('--disable-dev-shm-usage');
35-
36-
let service = new Chrome.ServiceBuilder(driverPath)
37-
38-
let driver = new Builder()
39-
.forBrowser(Browser.CHROME)
40-
.setChromeOptions(options)
41-
.setChromeService(service)
42-
.build();
43-
45+
service = new Chrome.ServiceBuilder(driverPath);
46+
driver = new Builder()
47+
.forBrowser(Browser.CHROME)
48+
.setChromeOptions(options)
49+
.setChromeService(service)
50+
.build();
4451
await driver.get('https://www.selenium.dev/selenium/web/blank.html');
45-
await driver.quit();
46-
// 👉 Cleanup user data dir
47-
fs.rmSync(userDataDir, { recursive: true, force: true });
4852
});
4953

5054
it('Set port', async function () {
51-
let service = new Chrome.ServiceBuilder().setPort(1234)
52-
53-
let driver = new Builder()
54-
.forBrowser(Browser.CHROME)
55-
.setChromeService(service)
56-
.build();
57-
55+
service = new Chrome.ServiceBuilder().setPort(1234);
56+
driver = new Builder()
57+
.forBrowser(Browser.CHROME)
58+
.setChromeService(service)
59+
.build();
5860
await driver.get('https://www.selenium.dev/selenium/web/blank.html');
59-
await driver.quit();
6061
});
6162
});

website_and_docs/content/documentation/webdriver/drivers/_index.en.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ on the local machine.
4141
{{< gh-codeblock path="examples/ruby/spec/drivers/options_spec.rb#L14" >}}
4242
{{< /tab >}}
4343
{{< tab header="JavaScript" >}}
44-
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L32-L36" >}}
44+
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L46-L50" >}}
4545
{{< /tab >}}
4646
{{< tab header="Kotlin" >}}
4747
{{< badge-code >}}

website_and_docs/content/documentation/webdriver/drivers/_index.ja.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ weight: 3
3838
{{< gh-codeblock path="examples/ruby/spec/drivers/options_spec.rb#L14" >}}
3939
{{< /tab >}}
4040
{{< tab header="JavaScript" >}}
41-
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L32-L36" >}}
41+
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L46-L50" >}}
4242
{{< /tab >}}
4343
{{< tab header="Kotlin" >}}
4444
{{< badge-code >}}

website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ on the local machine.
4141
{{< gh-codeblock path="examples/ruby/spec/drivers/options_spec.rb#L14" >}}
4242
{{< /tab >}}
4343
{{< tab header="JavaScript" >}}
44-
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L32-L36" >}}
44+
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L46-L50" >}}
4545
{{< /tab >}}
4646
{{< tab header="Kotlin" >}}
4747
{{< badge-code >}}

website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ weight: 3
3939
{{< gh-codeblock path="examples/ruby/spec/drivers/options_spec.rb#L14" >}}
4040
{{< /tab >}}
4141
{{< tab header="JavaScript" >}}
42-
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L32-L36" >}}
42+
{{< gh-codeblock path="examples/javascript/test/drivers/service.spec.js#L46-L50" >}}
4343
{{< /tab >}}
4444
{{< tab header="Kotlin" >}}
4545
{{< badge-code >}}

0 commit comments

Comments
 (0)