Skip to content

Commit b5eb523

Browse files
committed
[ci]: update for chart template render in deploy stage
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 1b0bb20 commit b5eb523

File tree

3 files changed

+25
-8
lines changed

3 files changed

+25
-8
lines changed

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -901,7 +901,7 @@ chart_test_template:
901901
./tests/charts/bootstrap.sh
902902

903903
chart_render_template:
904-
RENDER_HELM_TEMPLATE_ONLY=true make chart_test_autoscaling_disabled chart_test_autoscaling_deployment_https chart_test_autoscaling_deployment chart_test_autoscaling_job_https chart_test_autoscaling_job_hostname chart_test_autoscaling_job
904+
RENDER_HELM_TEMPLATE_ONLY=true NAMESPACE=$(NAME) KEDA_TAG_VERSION=$(KEDA_TAG_VERSION) BUILD_DATE=$(BUILD_DATE) make chart_test_autoscaling_disabled chart_test_autoscaling_deployment_https chart_test_autoscaling_deployment chart_test_autoscaling_job_https chart_test_autoscaling_job_hostname chart_test_autoscaling_job chart_test_autoscaling_playwright_connect_grid
905905

906906
chart_test_autoscaling_disabled:
907907
PLATFORMS=$(PLATFORMS) TEST_CHROMIUM=true RELEASE_NAME=selenium SELENIUM_GRID_AUTOSCALING=false CHART_ENABLE_TRACING=true \
@@ -915,7 +915,7 @@ chart_test_autoscaling_deployment_https:
915915
SECURE_INGRESS_ONLY_DEFAULT=true INGRESS_DISABLE_USE_HTTP2=true SELENIUM_GRID_PROTOCOL=https CHART_ENABLE_INGRESS_HOSTNAME=true SELENIUM_GRID_PORT=443 \
916916
SELENIUM_GRID_AUTOSCALING_MIN_REPLICA=1 MAX_SESSIONS_FIREFOX=3 MAX_SESSIONS_EDGE=2 MAX_SESSIONS_CHROME=1 TEST_NAME_OVERRIDE=true \
917917
VERSION=$(TAG_VERSION) VIDEO_TAG=$(FFMPEG_TAG_VERSION)-$(BUILD_DATE) KEDA_BASED_NAME=$(KEDA_BASED_NAME) KEDA_BASED_TAG=$(KEDA_BASED_TAG) NAMESPACE=$(NAMESPACE) BINDING_VERSION=$(BINDING_VERSION) \
918-
TEMPLATE_OUTPUT_FILENAME="k8s_fullDistributed_basicAuth_secureIngress_defaultCerts_ingressHostName_disableHttp2_autoScaling_scaledObject_subPath.yaml" \
918+
TEMPLATE_OUTPUT_FILENAME="k8s_fullDistributed_basicAuth_secureIngress_defaultCerts_ingressHostName_disableHttp2_autoScaling_patchKEDA_scaledObject_subPath.yaml" \
919919
./tests/charts/make/chart_test.sh DeploymentAutoscaling
920920

921921
chart_test_autoscaling_deployment:
@@ -938,7 +938,7 @@ chart_test_autoscaling_job_hostname:
938938
PLATFORMS=$(PLATFORMS) CHART_ENABLE_TRACING=true CHART_ENABLE_BASIC_AUTH=true BASIC_AUTH_EMBEDDED_URL=true TEST_PATCHED_KEDA=false \
939939
SECURE_INGRESS_ONLY_DEFAULT=true SECURE_USE_EXTERNAL_CERT=true SELENIUM_GRID_PROTOCOL=https SELENIUM_GRID_HOST=$$(hostname -i) SELENIUM_GRID_PORT=443 \
940940
VERSION=$(TAG_VERSION) VIDEO_TAG=$(FFMPEG_TAG_VERSION)-$(BUILD_DATE) KEDA_BASED_NAME=$(KEDA_BASED_NAME) KEDA_BASED_TAG=$(KEDA_BASED_TAG) NAMESPACE=$(NAMESPACE) BINDING_VERSION=$(BINDING_VERSION) \
941-
TEMPLATE_OUTPUT_FILENAME="k8s_enableTracing_basicAuth_secureIngress_externalCerts_ingressPublicIP_autoScaling_scaledJob_subPath.yaml" \
941+
TEMPLATE_OUTPUT_FILENAME="k8s_enableTracing_basicAuth_secureIngress_externalCerts_ingressPublicIP_autoScaling_originKEDA_scaledJob_subPath.yaml" \
942942
./tests/charts/make/chart_test.sh JobAutoscaling
943943

944944
chart_test_autoscaling_job:
@@ -952,7 +952,7 @@ chart_test_autoscaling_playwright_connect_grid:
952952
PLATFORMS=$(PLATFORMS) CHART_ENABLE_TRACING=true CHART_ENABLE_BASIC_AUTH=true MATRIX_TESTS=CDPTests \
953953
SECURE_INGRESS_ONLY_DEFAULT=true SECURE_USE_EXTERNAL_CERT=true SELENIUM_GRID_PROTOCOL=https SELENIUM_GRID_HOST=$$(hostname -i) SELENIUM_GRID_PORT=443 \
954954
VERSION=$(TAG_VERSION) VIDEO_TAG=$(FFMPEG_TAG_VERSION)-$(BUILD_DATE) KEDA_BASED_NAME=$(KEDA_BASED_NAME) KEDA_BASED_TAG=$(KEDA_BASED_TAG) NAMESPACE=$(NAMESPACE) BINDING_VERSION=$(BINDING_VERSION) \
955-
TEMPLATE_OUTPUT_FILENAME="k8s_playwright_connect_grid_basicAuth_secureIngress_ingressPublicIP_autoScaling.yaml" \
955+
TEMPLATE_OUTPUT_FILENAME="k8s_playwright_connect_grid_basicAuth_secureIngress_ingressPublicIP_autoScaling_patchKEDA.yaml" \
956956
./tests/charts/make/chart_test.sh JobAutoscaling
957957

958958
chart_test_delete:

tests/charts/ci/base-tls-values.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ registrationSecret:
22
enabled: true
33
value: "HappyTestOps"
44

5-
monitoring:
6-
enabled: true
7-
85
kube-prometheus-stack:
96
cleanPrometheusOperatorObjectNames: true
107
defaultRules:

tests/charts/make/chart_test.sh

Lines changed: 21 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ MAX_SESSIONS_EDGE=${MAX_SESSIONS_EDGE:-"1"}
5555
TEST_NAME_OVERRIDE=${TEST_NAME_OVERRIDE:-"false"}
5656
TEST_PATCHED_KEDA=${TEST_PATCHED_KEDA:-"true"}
5757
BASIC_AUTH_EMBEDDED_URL=${BASIC_AUTH_EMBEDDED_URL:-"false"}
58+
SELENIUM_GRID_MONITORING=${SELENIUM_GRID_MONITORING:-"true"}
59+
TEST_EXISTING_PTS=${TEST_EXISTING_PTS:-"false"}
5860

5961
cleanup() {
6062
# Get the list of pods
@@ -94,6 +96,12 @@ if [ "${RENDER_HELM_TEMPLATE_ONLY}" != "true" ]; then
9496
touch tests/tests/describe_all_resources_${MATRIX_BROWSER}.txt
9597
fi
9698

99+
if [ "${RENDER_HELM_TEMPLATE_ONLY}" = "true" ]; then
100+
KEDA_BASED_NAME="${NAMESPACE}"
101+
KEDA_BASED_TAG="${KEDA_TAG_VERSION}-${BUILD_DATE}"
102+
TEST_EXISTING_PTS="true"
103+
fi
104+
97105
if [ -f .env ]
98106
then
99107
export "$(cat .env | xargs)"
@@ -156,6 +164,18 @@ elif [ "${SELENIUM_GRID_AUTOSCALING}" = "true" ] && [ "${TEST_EXISTING_KEDA}" =
156164
"
157165
fi
158166

167+
if [ "${SELENIUM_GRID_MONITORING}" = "true" ] && [ "${TEST_EXISTING_PTS}" = "true" ]; then
168+
HELM_COMMAND_SET_IMAGES="${HELM_COMMAND_SET_IMAGES} \
169+
--set monitoring.enabled=false \
170+
--set monitoring.enabledWithExistingAgent=true \
171+
"
172+
elif [ "${SELENIUM_GRID_MONITORING}" = "true" ] && [ "${TEST_EXISTING_PTS}" = "false" ]; then
173+
HELM_COMMAND_SET_IMAGES="${HELM_COMMAND_SET_IMAGES} \
174+
--set monitoring.enabled=true \
175+
--set monitoring.enabledWithExistingAgent=false \
176+
"
177+
fi
178+
159179
if [ "${SELENIUM_GRID_AUTOSCALING}" = "true" ] && [ -n "${SET_MAX_REPLICAS}" ]; then
160180
HELM_COMMAND_SET_IMAGES="${HELM_COMMAND_SET_IMAGES} \
161181
--set autoscaling.scaledOptions.maxReplicaCount=${SET_MAX_REPLICAS} \
@@ -333,7 +353,7 @@ HELM_COMMAND_SET_BASE_VALUES="${HELM_COMMAND_SET_BASE_VALUES} \
333353
--values ${MATRIX_BROWSER_VALUES_FILE} \
334354
"
335355

336-
if [ "${TEST_EXISTING_KEDA}" = "true" ] && [ "${TEST_UPGRADE_CHART}" != "true" ]; then
356+
if [ "${TEST_EXISTING_KEDA}" = "true" ] && [ "${TEST_UPGRADE_CHART}" != "true" ] && [ "${RENDER_HELM_TEMPLATE_ONLY}" != "true" ]; then
337357
if [ "${TEST_PATCHED_KEDA}" = "true" ]; then
338358
KEDA_SET_IMAGES="--set image.keda.registry=${KEDA_BASED_NAME} --set image.keda.repository=keda --set image.keda.tag=${KEDA_BASED_TAG} \
339359
--set image.metricsApiServer.registry=${KEDA_BASED_NAME} --set image.metricsApiServer.repository=keda-metrics-apiserver --set image.metricsApiServer.tag=${KEDA_BASED_TAG} \

0 commit comments

Comments
 (0)