-
-
Notifications
You must be signed in to change notification settings - Fork 220
PresetTimeCallback #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Towards that end, my most common events are discrete events where the event times are given by parameters. It would be nice to have tstops automatically calculated and setup from them instead of having to remember to pass them separately. |
That is a very reasonable ask. Definitely should get implemented. Should probably wait for the overhaul of the symbolic event interface in v10 for ImplicitDiscreteSystem #3452 and be implemented in that form, but yes we should definitely add that. |
@ChrisRackauckas, if there is someone that knows the new event system that would have time to look at it can we tag this as something to have ready for v10? |
It's not breaking to add it, so I don't see why v10 would be delayed for it. |
@AayushSabharwal I assume this would be quick, just different condition matching the setup in https://github.com/SciML/DiffEqCallbacks.jl/blob/master/src/preset_time.jl but with the symbolic-defined affect!. |
It would be nice if MTK also offered PresetTimeCallback, such that we do not need to add
tstops
to thesolve
manually.The text was updated successfully, but these errors were encountered: